Attachment 105319 Details for Bug 25090 – Bug 25090: Remove references to PatronSelfRegistrationVerifyByEmail syspref

[patch] Bug 25090: Remove references to PatronSelfRegistrationVerifyByEmail syspref

Bug-25090-Remove-references-to-PatronSelfRegistrat.patch (text/plain), 3.98 KB, created by Alex Buckley on 2020-05-25 04:45:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2020-05-25 04:45:25 UTC

Size: 3.98 KB

patch

obsolete

>From ff95677cebc162a2ef75911e4009997bee1357b8 Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Mon, 25 May 2020 04:27:10 +0000
>Subject: [PATCH] Bug 25090: Remove references to
> PatronSelfRegistrationVerifyByEmail syspref
>
>PatronSelfRegistrationVerifyByEmail has been replaced with:
>
>* PatronSelfRegistrationVerifyByEmailToPatron
>* PatronSelfRegistrationVerifyByEmailToLibrary
>
>Test plan:
>1. Go to Administration > Patron attribute types
>2. Add a new patron attribute type and observe the 'Editable in OPAC'
>checkbox references PatronSelfRegistrationVerifyByEmail
>3. Apply patch
>4. Refresh page and observe the said field references/links are replaced
>with references/links to PatronSelfRegistrationVerifyByEmailToPatron and PatronSelfRegistrationVerifyByEmailToLibrary
>5. Select 'Display in OPAC' and 'Editable in OPAC'
>6. Make sure both new PatronSelfRegistration sysprefs are disabled
>7. Go to your patron detail page in OPAC and click on 'your personal
>details' tab
>8. Observe under 'Additional information' the patron attribute is
>visible and editable
>
>[Check display logic]
>9. Observe when either one of the PatronSelfRegistrationVerify sysprefs is
>enabled the attribute is hidden in the OPAC page
>10. Observe when both PatronSelfRegistrationVerify sysprefs are enabled the
>attribute is hidden in OPAC
>
>Sponsored-By: Mental Health Education Resource Centre, NZ
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt       | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
>index 862dad52fc..7fe075b33e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
>@@ -116,7 +116,7 @@
>           [% ELSE %]
>             <input type="checkbox" id="opac_editable" name="opac_editable" />
>           [% END %]
>-            <span>Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work with <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=PatronSelfRegistrationVerifyByEmail" target="_blank">PatronSelfRegistrationVerifyByEmail</a>.)</span>
>+          <span>Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work with <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=PatronSelfRegistrationVerifyByEmailToPatron" target="_blank">PatronSelfRegistrationVerifyByEmailToPatron</a> or <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=PatronSelfRegistrationVerifyByEmailToLibrary" target="_blank">PatronSelfRegistrationVerifyByEmailToLibrary</a>.)</span>
>        </li>
>        <li><label for="staff_searchable">Searchable: </label>
>           [% IF attribute_type AND attribute_type.staff_searchable %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 35af40224f..316d7976f0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -892,7 +892,7 @@
>                     </fieldset>
>                [% END %]
> 
>-                [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && !Koha.Preference('PatronSelfRegistrationVerifyByEmail') ) %]
>+                [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && !Koha.Preference('PatronSelfRegistrationVerifyByEmailToPatron') && !Koha.Preference('PatronSelfRegistrationVerifyByEmailToLibrary')) %]
>                     [% FOREACH pa_class IN patron_attribute_classes %]
>                         [% IF pa_class.class %]
>                             <fieldset id="aai_[% pa_loo.class | html %]" class="rows patron-attributes">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25090: 102845 | 103535 | 103536 | 104380 | 104381 | 104382 | 104383 | 104386 | 104994 | 104996 | 105319 | 112493 | 112494 | 112495 | 112496 | 112497 | 173894 | 173895 | 173896 | 173897 | 173898 | 173899 | 173962 | 173963 | 173964 | 174228 | 174229 | 174230