Created attachment 102845 [details] [review]
Bug 25090: Add sysprefs to define destination of OPAC self reg verification emails

Test plan:
To come

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 103535 [details] [review]
Bug 25090: Add sysprefs to define destination of OPAC self reg verification emails

Online resources such as Ancestry, EBSCO etc. often charge on a usage
basis and for library users to access them they need a Koha OPAC login.

Enabling PatronSelfRegistration syspref allows patrons to immediately
create a Koha patron and have the ability to login to the OPAC.

Enabling PatronSelfRegistrationVerifyByEmail delays when the patron can
login to the OPAC until after they have clicked on the verification
email sent to their entered email address.

Currently there is no way for libraries to moderate self registrations
and prevent certain users (e.g. registrations from outside an
organisation) from having OPAC logins and therefore access to paid
online resources.

This enhancement adds two new system preferences
PatronSelfRegistrationVerificationRecipient and
PatronSelfRegistrationVerificationRecipientAddress.

These new system preferences work in the same way as existing sysprefs
EmailPurchaseSuggestions, EmailAddressForSuggestions, and they keep the
current Koha behaviour as their default.

The former new syspref allows librarians to control where the verification
email (generated after OPAC self registration form is submitted) goes to. The choices are:

A. Self registering patrons selected home library email
B. KohaAdminEmailAddress - Although ReplyToDefault syspref is defaulted
to be used first
C. Email address entered into
PatronSelfRegistrationVerificationRecipientAddress
D. Self registering patron email address - This is the default set for
PatronSelfRegistrationVerificationRecipient.

If A,B,C is selected then a new STAFF_OPAC_REG_VERIFY notice is sent to
the library staff after the OPAC self registration form is submitted.
The library staff can then review the submitted patron information
and if they are happy for that user to have a OPAC login they click the
verification link.

Whereupon a patron account is added to the Koha borrowers table and the 'SELF_REG_APPROVED'
notice containing a password reset link is sent to the patron.

If D is selected then after submitting the OPAC self registration form
is submitted then the patron is emailed the OPAC_REG_VERIFY notice
directly and they can click the verification link whereupon they have a
OPAC login.

Test plan:
1. Enable PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail
sysprefs. Also ensure there are different values in KohaAdminEmailAddress,
ReplyToAddress sysprefs and branch email address (Administration > Libraries)
2. Visit OPAC click registration link
3. Submit form and query the database:
select to_address from message_queue where
letter_code='OPAC_REG_VERIFY';
4. Observe the verification email is sent directly to the email address
entered in step #3
5. Apply patch and restart plack
6. update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
7. Observe 2 new sysprefs:
* PatronSelfRegistrationVerificationRecipient -> Note this has default
value of 'email address of Self registering patron'
* PatronSelfRegistrationVerificationRecipientAddress

8. Repeat steps 2,3,4 and observe the 'OPAC_REG_VERIFY' notices is still
sent directly to the patron

9. Change PatronSelfRegistrationVerificationRecipient to 'email address
of branch'
10. Revisit the OPAC, resubmit the OPAC self registration (setting the
library to a library with a email set in step #1) and observe
text is displayed telling you that your self registration has been sent
to librarians for approval

11. Query the database:
select to_address, content from message_queue where
letter_code='STAFF_OPAC_REG_VERIFY';

Observe that the STAFF_OPAC_REG_VERIFY notice was sent to the individual
library email address and contains:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

12. Query the database and observe the patron added in step 8 doesn't
yet exist in the borrowers table, e.g:
select * from borrowers where email=<email you entered>;

13. Copy the verification link from step #11 into your browser
14. Observe the OPAC is displaying text telling you a password reset
link email was sent to patron
15. Query the database and observe the patron has been added to the
borrowers table now:
select * from borrowers where email=<email you entered>;

16. Query the message_queue table and observe the password reset email
'SELF_REG_APPROVED' has been sent to the patron:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

17. Click on the password reset link in that email and observe the
password reset page in the OPAC loads with the login username and email;
are prefilled.

18. Reset the password and try logging in and observe you are able to.

19. Change PatronSelfRegistrationVerificationRecipient to
'KohaAdminEmailAddress' and repeat steps 10 and 11 and observe the
'STAFF_OPAC_REG_VERIFY' notice has been sent to ReplyToDefault syspref
email
20. Repeat steps 12, 13, 14, 15, 16, 17, 18 and observe they all have
the same outcomes as when PatronSelfRegistrationVerificationRecipient
was set to 'email address of branch'

21. Change PatronSelfRegistrationVerificationRecipient to
'PatronSelfRegistrationVerificationRecipientAddress' and then set a
different email address in
PatronSelfRegistrationVerificationRecipientAddress'

22. Repeat steps 10 and 11 and observe the 'STAFF_OPAC_REG_VERIFY'
notice has been sent to the email you set in
PatronSelfRegistrationVerificationRecipientAddress

23. Repeat steps 12, 13, 14, 15, 16, 17, 18 and observe they all have
the same outcomes as when PatronSelfRegistrationVerificationRecipient
was set to 'email address of branch'

24. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 103536 [details] [review]
Bug 25090: Add sysprefs to define destination of OPAC self reg verification emails

Online resources such as Ancestry, EBSCO etc. often charge on a usage
basis and for library users to access them they need a Koha OPAC login.

Enabling PatronSelfRegistration syspref allows patrons to immediately
create a Koha patron and have the ability to login to the OPAC.

Enabling PatronSelfRegistrationVerifyByEmail delays when the patron can
login to the OPAC until after they have clicked on the verification
email sent to their entered email address.

Currently there is no way for libraries to moderate self registrations
and prevent certain users (e.g. registrations from outside an
organisation) from having OPAC logins and therefore access to paid
online resources.

This enhancement adds two new system preferences
PatronSelfRegistrationVerificationRecipient and
PatronSelfRegistrationVerificationRecipientAddress.

These new system preferences work in the same way as existing sysprefs
EmailPurchaseSuggestions, EmailAddressForSuggestions, and they keep the
current Koha behaviour as their default.

The former new syspref allows librarians to control where the verification
email (generated after OPAC self registration form is submitted) goes to. The choices are:

A. Self registering patrons selected home library email
B. KohaAdminEmailAddress - Although ReplyToDefault syspref is defaulted
to be used first
C. Email address entered into
PatronSelfRegistrationVerificationRecipientAddress
D. Self registering patron email address - This is the default set for
PatronSelfRegistrationVerificationRecipient.

If A,B,C is selected then a new STAFF_OPAC_REG_VERIFY notice is sent to
the library staff after the OPAC self registration form is submitted.
The library staff can then review the submitted patron information
and if they are happy for that user to have a OPAC login they click the
verification link.

Whereupon a patron account is added to the Koha borrowers table and the 'SELF_REG_APPROVED'
notice containing a password reset link is sent to the patron.

If D is selected then after submitting the OPAC self registration form
is submitted then the patron is emailed the OPAC_REG_VERIFY notice
directly and they can click the verification link whereupon they have a
OPAC login.

Test plan:
1. Enable PatronSelfRegistration, PatronSelfRegistrationVerifyByEmail,
and OpacResetPassword sysprefs. Also ensure there are different values in KohaAdminEmailAddress,
ReplyToAddress sysprefs and branch email address (Administration > Libraries)
2. Visit OPAC click registration link
3. Submit form and query the database:
select to_address from message_queue where
letter_code='OPAC_REG_VERIFY';
4. Observe the verification email is sent directly to the email address
entered in step #3
5. Apply patch and restart plack
6. update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
7. Observe 2 new sysprefs:
* PatronSelfRegistrationVerificationRecipient -> Note this has default
value of 'email address of Self registering patron'
* PatronSelfRegistrationVerificationRecipientAddress

8. Repeat steps 2,3,4 and observe the 'OPAC_REG_VERIFY' notices is still
sent directly to the patron

9. Change PatronSelfRegistrationVerificationRecipient to 'email address
of branch'
10. Revisit the OPAC, resubmit the OPAC self registration (setting the
library to a library with a email set in step #1) and observe
text is displayed telling you that your self registration has been sent
to librarians for approval

11. Query the database:
select to_address, content from message_queue where
letter_code='STAFF_OPAC_REG_VERIFY';

Observe that the STAFF_OPAC_REG_VERIFY notice was sent to the individual
library email address and contains:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

12. Query the database and observe the patron added in step 8 doesn't
yet exist in the borrowers table, e.g:
select * from borrowers where email=<email you entered>;

13. Copy the verification link from step #11 into your browser
14. Observe the OPAC is displaying text telling you a password reset
link email was sent to patron
15. Query the database and observe the patron has been added to the
borrowers table now:
select * from borrowers where email=<email you entered>;

16. Query the message_queue table and observe the password reset email
'SELF_REG_APPROVED' has been sent to the patron:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

17. Click on the password reset link in that email and observe the
password reset page in the OPAC loads with the login username and email;
are prefilled.

18. Reset the password and try logging in and observe you are able to.

19. Change PatronSelfRegistrationVerificationRecipient to
'KohaAdminEmailAddress' and repeat steps 10 and 11 and observe the
'STAFF_OPAC_REG_VERIFY' notice has been sent to ReplyToDefault syspref
email
20. Repeat steps 12, 13, 14, 15, 16, 17, 18 and observe they all have
the same outcomes as when PatronSelfRegistrationVerificationRecipient
was set to 'email address of branch'

21. Change PatronSelfRegistrationVerificationRecipient to
'PatronSelfRegistrationVerificationRecipientAddress' and then set a
different email address in
PatronSelfRegistrationVerificationRecipientAddress'

22. Repeat steps 10 and 11 and observe the 'STAFF_OPAC_REG_VERIFY'
notice has been sent to the email you set in
PatronSelfRegistrationVerificationRecipientAddress

23. Repeat steps 12, 13, 14, 15, 16, 17, 18 and observe they all have
the same outcomes as when PatronSelfRegistrationVerificationRecipient
was set to 'email address of branch'

24. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104380 [details] [review]
Bug 25090: OPAC Template changes

* opac-registration-confirmation.tt
* opac-registration-email-sent.tt

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104381 [details] [review]
Bug 25090: Add 2 new sysprefs allowing libraries to approve OPAC registrations

Added:
* PatronSelfRegistrationVerifyByEmailToLibrary - Default value = 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - Default value = "Don't
require"

Removed:
* PatronSelfRegistrationVerifyByEmail

For existing Koha installs if removed
PatronSelfRegistrationVerifyByEmail was enabled then
PatronSelfRegistrationVerifyByEmailToPatron is enabled - they have the
same behaviour when enabled.

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104382 [details] [review]
Bug 25090: Added 3 new notices

* STAFF_VER_OPAC_REG - Sent to library containing registered patron details for library to review
and select verification link if approve patron creation

* PATRON_AND_IB_VER - Sent to patron to inform them they need to verify
their email address via verification link then their registration will
be reviewed by library

* SELF_REG_APPROVED - Sent to patron containing password reset link
after library has approved their registration

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104383 [details] [review]
Bug 25090: Allow libraries to verify OPAC self registrations

These patchsets add two new sysprefs (to replace
PatronSelfRegistrationVerifyByEmail), they are:

* PatronSelfRegistrationVerifyByEmailToLibrary - Library verifies OPAC
self registrations before a record is added to borrowers database table

* PatronSelfRegistrationVerifyByEmailToPatron - Patron must verify
their email before a record is added to borrowers database table

----------

4 possible email verification workflow scenarios:

1) library verification = disabled & patron verification = disabled :
   1a) Patron submits OPAC self reg form
   1b) Patron account created immediately

2) library verification = enabled & patron verification = disabled :
   2a) Patron submits OPAC self reg form
   2b) Koha sends notice to library to review registration
   2c) Library approves reg by clicking verification link in notice
   2d) Patron account is created
   2e) Password reset link emailed to patron

3) library verification = disabled & patron verification = enabled :
   3a) Patron submits OPAC self reg form
   3b) Koha sends verification email to patron
   3c) Patron clicks verification link in notice
   3d) Patron account is created

4) library verification = enabled & patron verification = enabled :
   4a) Patron submits OPAC self reg form
   4b) Koha sends verification email to patron to verify email
   4c) Patron clicks verification link in notice
   4d) Koha sends notice to library to review registration
   4e) Library approves reg by clicking verification link in notice
   4f) Patron account created
   4g) Password reset link emailed to patron

-----------

Test plan (in each test plan step where you must fill in OPAC self reg form please
use a different email address):

1. Apply patch and restart plack
2. Update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
3. Observe 2 new sysprefs in same line in editor (and observe
PatronSelfRegistrationVerifyByEmail syspref has been removed):
* PatronSelfRegistrationVerifyByEmailToLibrary - Set to 'None' by
default
* PatronSelfRegistrationVerifyByEmailToPatron - Set to "Don't require"
by default. (Exception: If PatronSelfRegistrationVerifyByEmail
syspref was enabled before applying this patch then
PatronSelfregistrationVerifyByEmailToPatron will now be enabled).

[Test scenario 1]

4. Set the following sysprefs:
* PatronSelfRegistration - enabled
* OpacResetPassword - enabled
* PatronSelfRegistrationVerifyByEmailToLibrary - 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - "Don't require"

Also set different values in:
* KohaAdminEmailAddress syspref
* ReplyToAddress syspref
* branch email address (Administration > Libraries)

5. Visit OPAC, fill in, submit OPAC registration form
6. Observe your patron account has been created immediately and you can
login

[Test scenario 2]

6. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'email address of
branch'
7. Repeat step 5 and query the database:
select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

8. Observe the verification email's to_address is library branch email
address (i.e. set in Administration > Libraries ) and the notice
contains the following information:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

9. Query database again:
select count(*) from borrowers where email=<email entered in reg form>;

select count(*) from borrower_modifications where email=<email entered in reg form>;

The first query returns 0 (as the patron account has not been added to
borrowers table), the second query has 1 as patron in
borrower_modifications table.

10. Click verification link in notice and query database:
select * from borrowers where email=<email entered in reg form>

11. Observe the patron account has now been added to the borrowers table
12. Query database:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

13. Observe password reset link emailed to patron, click on the link and
observe the password reset page loads with the patrons username and email pre-filled

14. Set PatronSelfRegistrationVerifyByEmailToLibrary to
'KohaAdminEmailAddress'

15. Repeat step 7 observing the verification email's to_address is
ReplytoDefault syspref value (if this is not set then
KohaAdminEmailAddress i.e. fallback same as EmailPurchaseSuggestions
syspref).

16. Repeat steps 9, 10, 11, 12, 13 which should all have the same
outcomes

[Test scenario 3]

17. Set PatronSelfRegistrationVerifyByEmailToPatron to "Require"
        PatronSelfRegistrationVerifyByEmailToLibrary to "None"

18. Repeat step 5
19. Query the database with these 4 queries (explanations of what
outputs to expect are hypehnated below each query:

select to_address, content from message_queue
where letter_code='OPAC_REG_VERIFY';

- You'll see 1 new OPAC_REG_VERIFY notice sent to the patrons inputted email

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (because
PatronSelfRegistrationVerifyByEmailToLibrary is set to "None")

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

20. Click verification link in OPAC_REG_VERIFY notice and query
database:
select count(*) from borrowers where email=<email entered in reg form>

This returns 1 as patron account now in borrowers table

[Test scenario 4]

21. Set PatronSelfRegistrationVerifyByEmailToLibrary = 'email address of
branch'

22. Repeat steps 5 and 19 observing same query outputs

23. Click verification link in OPAC_REG_VERIFY notice

24. Query the database:
select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- Returns no new OPAC_REG_VERIFY notice

select to_address, content from message_queue where
letter_code='PATRON_AND_LIB_VER';

- This returns a row result.  Note it contains patron details for librarians
to review and the to_address is the library branch email.

select count(*) from borrowers where email=<email entered in reg form>;

- This returns 0 as library still hasn't verified patron account can be
created yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- This returns a row result as patron account still in
borrower_modifications table

25. Click on verification link in PATRON_AND_LIB_VERIFY notice

26. Query the database:
select count(*) from borrowers where email=<email entered in reg form>;

- This returns a row result as patron account created

select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

- This returns a row result with the to_address being the patrons email.
Click on the password reset link in the notice and observe the password
reset page pre-fills with the patron username and email.

27. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104386 [details] [review]
Bug 25090: Allow libraries to verify OPAC self registrations

These patchsets add two new sysprefs (to replace
PatronSelfRegistrationVerifyByEmail), they are:

* PatronSelfRegistrationVerifyByEmailToLibrary - Library verifies OPAC
self registrations before a record is added to borrowers database table

* PatronSelfRegistrationVerifyByEmailToPatron - Patron must verify
their email before a record is added to borrowers database table

----------

4 possible email verification workflow scenarios:

1) library verification = disabled & patron verification = disabled :
   1a) Patron submits OPAC self reg form
   1b) Patron account created immediately

2) library verification = enabled & patron verification = disabled :
   2a) Patron submits OPAC self reg form
   2b) Koha sends notice to library to review registration
   2c) Library approves reg by clicking verification link in notice
   2d) Patron account is created
   2e) Password reset link emailed to patron

3) library verification = disabled & patron verification = enabled :
   3a) Patron submits OPAC self reg form
   3b) Koha sends verification email to patron
   3c) Patron clicks verification link in notice
   3d) Patron account is created

4) library verification = enabled & patron verification = enabled :
   4a) Patron submits OPAC self reg form
   4b) Koha sends verification email to patron to verify email
   4c) Patron clicks verification link in notice
   4d) Koha sends notice to library to review registration
   4e) Library approves reg by clicking verification link in notice
   4f) Patron account created
   4g) Password reset link emailed to patron

-----------

Test plan (in each test plan step where you must fill in OPAC self reg form please
use a different email address):

1. Apply patch and restart plack
2. Update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
3. Observe 2 new sysprefs in same line in editor (and observe
PatronSelfRegistrationVerifyByEmail syspref has been removed):
* PatronSelfRegistrationVerifyByEmailToLibrary - Set to 'None' by
default
* PatronSelfRegistrationVerifyByEmailToPatron - Set to "Don't require"
by default. (Exception: If PatronSelfRegistrationVerifyByEmail
syspref was enabled before applying this patch then
PatronSelfregistrationVerifyByEmailToPatron will now be enabled).

[Test scenario 1]

4. Set the following sysprefs:
* PatronSelfRegistration - enabled
* OpacResetPassword - enabled
* PatronSelfRegistrationVerifyByEmailToLibrary - 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - "Don't require"

Also set different values in:
* KohaAdminEmailAddress syspref
* ReplyToAddress syspref
* branch email address (Administration > Libraries)

5. Visit OPAC, fill in, submit OPAC registration form
6. Observe your patron account has been created immediately and you can
login

[Test scenario 2]

6. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'email address of
branch'
7. Repeat step 5 and query the database:
select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

8. Observe the verification email's to_address is library branch email
address (i.e. set in Administration > Libraries ) and the notice
contains the following information:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

9. Query database again:
select count(*) from borrowers where email=<email entered in reg form>;

select count(*) from borrower_modifications where email=<email entered in reg form>;

The first query returns 0 (as the patron account has not been added to
borrowers table), the second query has 1 as patron in
borrower_modifications table.

10. Click verification link in notice and query database:
select * from borrowers where email=<email entered in reg form>

11. Observe the patron account has now been added to the borrowers table
12. Query database:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

13. Observe password reset link emailed to patron, click on the link and
observe the password reset page loads with the patrons username and email pre-filled

14. Set PatronSelfRegistrationVerifyByEmailToLibrary to
'KohaAdminEmailAddress'

15. Repeat step 7 observing the verification email's to_address is
ReplytoDefault syspref value (if this is not set then
KohaAdminEmailAddress i.e. fallback same as EmailPurchaseSuggestions
syspref).

16. Repeat steps 9, 10, 11, 12, 13 which should all have the same
outcomes

[Test scenario 3]

17. Set PatronSelfRegistrationVerifyByEmailToPatron to "Require"
        PatronSelfRegistrationVerifyByEmailToLibrary to "None"

18. Repeat step 5
19. Query the database with these 4 queries (explanations of what
outputs to expect are hypehnated below each query:

select to_address, content from message_queue
where letter_code='OPAC_REG_VERIFY';

- You'll see 1 new OPAC_REG_VERIFY notice sent to the patrons inputted email

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (because
PatronSelfRegistrationVerifyByEmailToLibrary is set to "None")

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

20. Click verification link in OPAC_REG_VERIFY notice and query
database:
select count(*) from borrowers where email=<email entered in reg form>

This returns 1 as patron account now in borrowers table

[Test scenario 4]

21. Set PatronSelfRegistrationVerifyByEmailToLibrary = 'email address of
branch'

22. Repeat steps 5 and query the database:

select to_address, content from message_queue
where letter_code='PATRON_AND_LIB_VER';

- You'll see 1 new PATRON_AND_LIB_VER notice sent to the patrons inputted
email

select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- You'll see no new OPAC_REG_VERIFY notice as when library & patron
verification are both enabled the PATRON_AND_LIB_VER notice is sent to
the patron instead

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (it is generated
later on in the workflow of scenario 4)

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

23. Click verification link in PATRON_AND_LIB_VER notice

24. Query the database:
select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- Returns no new OPAC_REG_VERIFY notice

select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

- This returns a row result.  Note it contains patron details for librarians
to review and the to_address is the library branch email.

select count(*) from borrowers where email=<email entered in reg form>;

- This returns 0 as library still hasn't verified patron account can be
created yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- This returns a row result as patron account still in
borrower_modifications table

25. Click on verification link in STAFF_VER_OPAC_REG notice

26. Query the database:
select count(*) from borrowers where email=<email entered in reg form>;

- This returns a row result as patron account created

select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

- This returns a row result with the to_address being the patrons email.
Click on the password reset link in the notice and observe the password
reset page pre-fills with the patron username and email.

27. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104994 [details] [review]
Bug 25090: Added 3 new notices

* STAFF_VER_OPAC_REG - Sent to library containing registered patron details for library to review
and select verification link if approve patron creation

* PATRON_AND_IB_VER - Sent to patron to inform them they need to verify
their email address via verification link then their registration will
be reviewed by library

* SELF_REG_APPROVED - Sent to patron containing password reset link
after library has approved their registration

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 104996 [details] [review]
Bug 25090: Allow libraries to verify OPAC self registrations

These patchsets add two new sysprefs (to replace
PatronSelfRegistrationVerifyByEmail), they are:

* PatronSelfRegistrationVerifyByEmailToLibrary - Library verifies OPAC
self registrations before a record is added to borrowers database table

* PatronSelfRegistrationVerifyByEmailToPatron - Patron must verify
their email before a record is added to borrowers database table

----------

4 possible email verification workflow scenarios:

1) library verification = disabled & patron verification = disabled :
   1a) Patron submits OPAC self reg form
   1b) Patron account created immediately

2) library verification = enabled & patron verification = disabled :
   2a) Patron submits OPAC self reg form
   2b) Koha sends notice to library to review registration
   2c) Library approves reg by clicking verification link in notice
   2d) Patron account is created
   2e) Password reset link emailed to patron

3) library verification = disabled & patron verification = enabled :
   3a) Patron submits OPAC self reg form
   3b) Koha sends verification email to patron
   3c) Patron clicks verification link in notice
   3d) Patron account is created

4) library verification = enabled & patron verification = enabled :
   4a) Patron submits OPAC self reg form
   4b) Koha sends verification email to patron to verify email
   4c) Patron clicks verification link in notice
   4d) Koha sends notice to library to review registration
   4e) Library approves reg by clicking verification link in notice
   4f) Patron account created
   4g) Password reset link emailed to patron

-----------

Test plan (in each test plan step where you must fill in OPAC self reg form please
use a different email address):

1. Apply patch and restart plack
2. Update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
3. Observe 2 new sysprefs in same line in editor (and observe
PatronSelfRegistrationVerifyByEmail syspref has been removed):
* PatronSelfRegistrationVerifyByEmailToLibrary - Set to 'None' by
default
* PatronSelfRegistrationVerifyByEmailToPatron - Set to "Don't require"
by default. (Exception: If PatronSelfRegistrationVerifyByEmail
syspref was enabled before applying this patch then
PatronSelfregistrationVerifyByEmailToPatron will now be enabled).

[Test scenario 1]

4. Set the following sysprefs:
* PatronSelfRegistration - enabled
* OpacResetPassword - enabled
* PatronSelfRegistrationVerifyByEmailToLibrary - 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - "Don't require"

Also set different values in:
* KohaAdminEmailAddress syspref
* ReplyToAddress syspref
* branch email address (Administration > Libraries)

5. Visit OPAC, fill in, submit OPAC registration form
6. Observe your patron account has been created immediately and you can
login

[Test scenario 2]

6. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'email address of
branch'
7. Repeat step 5 and query the database:
select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

8. Observe the verification email's to_address is library branch email
address (i.e. set in Administration > Libraries ) and the notice
contains the following information:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

9. Query database again:
select count(*) from borrowers where email=<email entered in reg form>;

select count(*) from borrower_modifications where email=<email entered in reg form>;

The first query returns 0 (as the patron account has not been added to
borrowers table), the second query has 1 as patron in
borrower_modifications table.

10. Click verification link in notice and query database:
select * from borrowers where email=<email entered in reg form>

11. Observe the patron account has now been added to the borrowers table
12. Query database:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

13. Observe password reset link emailed to patron, click on the link and
observe the password reset page loads with the patrons username and email pre-filled

14. Set PatronSelfRegistrationVerifyByEmailToLibrary to
'KohaAdminEmailAddress'

15. Repeat step 7 observing the verification email's to_address is
ReplytoDefault syspref value (if this is not set then
KohaAdminEmailAddress i.e. fallback same as EmailPurchaseSuggestions
syspref).

16. Repeat steps 9, 10, 11, 12, 13 which should all have the same
outcomes

[Test scenario 3]

17. Set PatronSelfRegistrationVerifyByEmailToPatron to "Require"
        PatronSelfRegistrationVerifyByEmailToLibrary to "None"

18. Repeat step 5
19. Query the database with these 4 queries (explanations of what
outputs to expect are hypehnated below each query:

select to_address, content from message_queue
where letter_code='OPAC_REG_VERIFY';

- You'll see 1 new OPAC_REG_VERIFY notice sent to the patrons inputted email

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (because
PatronSelfRegistrationVerifyByEmailToLibrary is set to "None")

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

20. Click verification link in OPAC_REG_VERIFY notice and query
database:
select count(*) from borrowers where email=<email entered in reg form>

This returns 1 as patron account now in borrowers table

[Test scenario 4]

21. Set PatronSelfRegistrationVerifyByEmailToLibrary = 'email address of
branch'

22. Repeat steps 5 and query the database:

select to_address, content from message_queue
where letter_code='PATRON_AND_LIB_VER';

- You'll see 1 new PATRON_AND_LIB_VER notice sent to the patrons inputted
email

select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- You'll see no new OPAC_REG_VERIFY notice as when library & patron
verification are both enabled the PATRON_AND_LIB_VER notice is sent to
the patron instead

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (it is generated
later on in the workflow of scenario 4)

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

23. Click verification link in PATRON_AND_LIB_VER notice

24. Query the database:
select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- Returns no new OPAC_REG_VERIFY notice

select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

- This returns a row result.  Note it contains patron details for librarians
to review and the to_address is the library branch email.

select count(*) from borrowers where email=<email entered in reg form>;

- This returns 0 as library still hasn't verified patron account can be
created yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- This returns a row result as patron account still in
borrower_modifications table

25. Click on verification link in STAFF_VER_OPAC_REG notice

26. Query the database:
select count(*) from borrowers where email=<email entered in reg form>;

- This returns a row result as patron account created

select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

- This returns a row result with the to_address being the patrons email.
Click on the password reset link in the notice and observe the password
reset page pre-fills with the patron username and email.

27. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 105319 [details] [review]
Bug 25090: Remove references to PatronSelfRegistrationVerifyByEmail syspref

PatronSelfRegistrationVerifyByEmail has been replaced with:

* PatronSelfRegistrationVerifyByEmailToPatron
* PatronSelfRegistrationVerifyByEmailToLibrary

Test plan:
1. Go to Administration > Patron attribute types
2. Add a new patron attribute type and observe the 'Editable in OPAC'
checkbox references PatronSelfRegistrationVerifyByEmail
3. Apply patch
4. Refresh page and observe the said field references/links are replaced
with references/links to PatronSelfRegistrationVerifyByEmailToPatron and PatronSelfRegistrationVerifyByEmailToLibrary
5. Select 'Display in OPAC' and 'Editable in OPAC'
6. Make sure both new PatronSelfRegistration sysprefs are disabled
7. Go to your patron detail page in OPAC and click on 'your personal
details' tab
8. Observe under 'Additional information' the patron attribute is
visible and editable

[Check display logic]
9. Observe when either one of the PatronSelfRegistrationVerify sysprefs is
enabled the attribute is hidden in the OPAC page
10. Observe when both PatronSelfRegistrationVerify sysprefs are enabled the
attribute is hidden in OPAC

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 112493 [details] [review]
Bug 25090: OPAC Template changes

* opac-registration-confirmation.tt
* opac-registration-email-sent.tt

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 112494 [details] [review]
Bug 25090: Add 2 new sysprefs allowing libraries to approve OPAC registrations

Added:
* PatronSelfRegistrationVerifyByEmailToLibrary - Default value = 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - Default value = "Don't
require"

Removed:
* PatronSelfRegistrationVerifyByEmail

For existing Koha installs if removed
PatronSelfRegistrationVerifyByEmail was enabled then
PatronSelfRegistrationVerifyByEmailToPatron is enabled - they have the
same behaviour when enabled.

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 112495 [details] [review]
Bug 25090: Added 3 new notices

* STAFF_VER_OPAC_REG - Sent to library containing registered patron details for library to review
and select verification link if approve patron creation

* PATRON_AND_IB_VER - Sent to patron to inform them they need to verify
their email address via verification link then their registration will
be reviewed by library

* SELF_REG_APPROVED - Sent to patron containing password reset link
after library has approved their registration

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 112496 [details] [review]
Bug 25090: Allow libraries to verify OPAC self registrations

These patchsets add two new sysprefs (to replace
PatronSelfRegistrationVerifyByEmail), they are:

* PatronSelfRegistrationVerifyByEmailToLibrary - Library verifies OPAC
self registrations before a record is added to borrowers database table

* PatronSelfRegistrationVerifyByEmailToPatron - Patron must verify
their email before a record is added to borrowers database table

----------

4 possible email verification workflow scenarios:

1) library verification = disabled & patron verification = disabled :
   1a) Patron submits OPAC self reg form
   1b) Patron account created immediately

2) library verification = enabled & patron verification = disabled :
   2a) Patron submits OPAC self reg form
   2b) Koha sends notice to library to review registration
   2c) Library approves reg by clicking verification link in notice
   2d) Patron account is created
   2e) Password reset link emailed to patron

3) library verification = disabled & patron verification = enabled :
   3a) Patron submits OPAC self reg form
   3b) Koha sends verification email to patron
   3c) Patron clicks verification link in notice
   3d) Patron account is created

4) library verification = enabled & patron verification = enabled :
   4a) Patron submits OPAC self reg form
   4b) Koha sends verification email to patron to verify email
   4c) Patron clicks verification link in notice
   4d) Koha sends notice to library to review registration
   4e) Library approves reg by clicking verification link in notice
   4f) Patron account created
   4g) Password reset link emailed to patron

-----------

Test plan (in each test plan step where you must fill in OPAC self reg form please
use a different email address):

1. Apply patch and restart plack
2. Update database:
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
3. Observe 2 new sysprefs in same line in editor (and observe
PatronSelfRegistrationVerifyByEmail syspref has been removed):
* PatronSelfRegistrationVerifyByEmailToLibrary - Set to 'None' by
default
* PatronSelfRegistrationVerifyByEmailToPatron - Set to "Don't require"
by default. (Exception: If PatronSelfRegistrationVerifyByEmail
syspref was enabled before applying this patch then
PatronSelfregistrationVerifyByEmailToPatron will now be enabled).

[Test scenario 1]

4. Set the following sysprefs:
* PatronSelfRegistration - enabled
* OpacResetPassword - enabled
* PatronSelfRegistrationVerifyByEmailToLibrary - 'None'
* PatronSelfRegistrationVerifyByEmailToPatron - "Don't require"

Also set different values in:
* KohaAdminEmailAddress syspref
* ReplyToAddress syspref
* branch email address (Administration > Libraries)

5. Visit OPAC, fill in, submit OPAC registration form
6. Observe your patron account has been created immediately and you can
login

[Test scenario 2]

6. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'email address of
branch'
7. Repeat step 5 and query the database:
select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

8. Observe the verification email's to_address is library branch email
address (i.e. set in Administration > Libraries ) and the notice
contains the following information:

* Card number
* Name: title firstname surname
* Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country
* Email
* Phone
* Mobile
* Fax
* Secondary email
* Secondary phone
* Home library
* Temporary patron category

And a verification link

9. Query database again:
select count(*) from borrowers where email=<email entered in reg form>;

select count(*) from borrower_modifications where email=<email entered in reg form>;

The first query returns 0 (as the patron account has not been added to
borrowers table), the second query has 1 as patron in
borrower_modifications table.

10. Click verification link in notice and query database:
select * from borrowers where email=<email entered in reg form>

11. Observe the patron account has now been added to the borrowers table
12. Query database:
select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

13. Observe password reset link emailed to patron, click on the link and
observe the password reset page loads with the patrons username and email pre-filled

14. Set PatronSelfRegistrationVerifyByEmailToLibrary to
'KohaAdminEmailAddress'

15. Repeat step 7 observing the verification email's to_address is
ReplytoDefault syspref value (if this is not set then
KohaAdminEmailAddress i.e. fallback same as EmailPurchaseSuggestions
syspref).

16. Repeat steps 9, 10, 11, 12, 13 which should all have the same
outcomes

[Test scenario 3]

17. Set PatronSelfRegistrationVerifyByEmailToPatron to "Require"
        PatronSelfRegistrationVerifyByEmailToLibrary to "None"

18. Repeat step 5
19. Query the database with these 4 queries (explanations of what
outputs to expect are hypehnated below each query:

select to_address, content from message_queue
where letter_code='OPAC_REG_VERIFY';

- You'll see 1 new OPAC_REG_VERIFY notice sent to the patrons inputted email

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (because
PatronSelfRegistrationVerifyByEmailToLibrary is set to "None")

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

20. Click verification link in OPAC_REG_VERIFY notice and query
database:
select count(*) from borrowers where email=<email entered in reg form>

This returns 1 as patron account now in borrowers table

[Test scenario 4]

21. Set PatronSelfRegistrationVerifyByEmailToLibrary = 'email address of
branch'

22. Repeat steps 5 and query the database:

select to_address, content from message_queue
where letter_code='PATRON_AND_LIB_VER';

- You'll see 1 new PATRON_AND_LIB_VER notice sent to the patrons inputted
email

select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- You'll see no new OPAC_REG_VERIFY notice as when library & patron
verification are both enabled the PATRON_AND_LIB_VER notice is sent to
the patron instead

select to_address, content from message_queue
where letter_code='STAFF_VER_OPAC_REG';

- You'll see no new STAFF_VER_OPAC_REG notice generated (it is generated
later on in the workflow of scenario 4)

select count(*) from borrowers where email=<email entered in reg form>;

- Returns 0 as patron account not added to borrowers table yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- Returns 1 as patron account is in borrower_modifications table

23. Click verification link in PATRON_AND_LIB_VER notice

24. Query the database:
select to_address, content from message_queue where
letter_code='OPAC_REG_VERIFY';

- Returns no new OPAC_REG_VERIFY notice

select to_address, content from message_queue where
letter_code='STAFF_VER_OPAC_REG';

- This returns a row result.  Note it contains patron details for librarians
to review and the to_address is the library branch email.

select count(*) from borrowers where email=<email entered in reg form>;

- This returns 0 as library still hasn't verified patron account can be
created yet

select count(*) from borrower_modifications where email=<email entered
in reg form>;

- This returns a row result as patron account still in
borrower_modifications table

25. Click on verification link in STAFF_VER_OPAC_REG notice

26. Query the database:
select count(*) from borrowers where email=<email entered in reg form>;

- This returns a row result as patron account created

select to_address, content from message_queue where
letter_code='SELF_REG_APPROVED';

- This returns a row result with the to_address being the patrons email.
Click on the password reset link in the notice and observe the password
reset page pre-fills with the patron username and email.

27. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 112497 [details] [review]
Bug 25090: Remove references to PatronSelfRegistrationVerifyByEmail syspref

PatronSelfRegistrationVerifyByEmail has been replaced with:

* PatronSelfRegistrationVerifyByEmailToPatron
* PatronSelfRegistrationVerifyByEmailToLibrary

Test plan:
1. Go to Administration > Patron attribute types
2. Add a new patron attribute type and observe the 'Editable in OPAC'
checkbox references PatronSelfRegistrationVerifyByEmail
3. Apply patch
4. Refresh page and observe the said field references/links are replaced
with references/links to PatronSelfRegistrationVerifyByEmailToPatron and PatronSelfRegistrationVerifyByEmailToLibrary
5. Select 'Display in OPAC' and 'Editable in OPAC'
6. Make sure both new PatronSelfRegistration sysprefs are disabled
7. Go to your patron detail page in OPAC and click on 'your personal
details' tab
8. Observe under 'Additional information' the patron attribute is
visible and editable

[Check display logic]
9. Observe when either one of the PatronSelfRegistrationVerify sysprefs is
enabled the attribute is hidden in the OPAC page
10. Observe when both PatronSelfRegistrationVerify sysprefs are enabled the
attribute is hidden in OPAC

Sponsored-By: Mental Health Education Resource Centre, NZ

Created attachment 173894 [details] [review]
Bug 25090: Update PatronSelfRegistrationVerifyByEmail to include choices

This database update changes PatronSelfRegistrationVerifyByEmail from a YesNo preference to have these options:

* don't require (same as 0 previously)
* patron verifies (same as 1 previously)
* library verifies, based on the EmailPatronRegistrations syspref setting

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173895 [details] [review]
Bug 25090: Add OPAC_REG_VERIFY_LIB notice

This is a bit of a merge between the OPAC_REG and OPAC_REG_VERIFY notices that the EmailPatronRegistrations address would receive if PatronSelfRegistrationVerifyByEmail was set to need that verification

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173896 [details] [review]
Bug 25090 [WIP]: Redirect OPAC self reg verification email to the library

So they can moderate and activate accounts made via OPAC self registration

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173897 [details] [review]
Bug 25090: Update PatronSelfRegistrationVerifyByEmail to include choices

This database update changes PatronSelfRegistrationVerifyByEmail from a YesNo preference to have these options:

* don't require (same as 0 previously)
* patron verifies (same as 1 previously)
* library verifies, based on the EmailPatronRegistrations syspref setting

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173898 [details] [review]
Bug 25090: Add OPAC_REG_VERIFY_LIB notice

This is a bit of a merge between the OPAC_REG and OPAC_REG_VERIFY notices that the EmailPatronRegistrations address would receive if PatronSelfRegistrationVerifyByEmail was set to need that verification

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173899 [details] [review]
Bug 25090 [WIP]: Redirect OPAC self reg verification email to the library

So they can moderate and activate accounts made via OPAC self registration

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173962 [details] [review]
Bug 25090: Update PatronSelfRegistrationVerifyByEmail to include choices

This database update changes PatronSelfRegistrationVerifyByEmail from a YesNo preference to have these options:

* don't require (same as 0 previously)
* patron verifies (same as 1 previously)
* library verifies, based on the EmailPatronRegistrations syspref setting

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173963 [details] [review]
Bug 25090: Add OPAC_REG_VERIFY_LIB notice

This is a bit of a merge between the OPAC_REG and OPAC_REG_VERIFY notices that the EmailPatronRegistrations address would receive if PatronSelfRegistrationVerifyByEmail was set to need that verification

Sponsored-by: Mental Health Education & Resource Centre

Created attachment 173964 [details] [review]
Bug 25090: Redirect OPAC self reg verification email to the library

This enhancement changes the PatronSelfRegistrationVerifyByEmail system preference to have the following options:

* don't require (same as 0 previously)
* patron verifies (same as 1 previously)
* library verifies, based on the EmailPatronRegistrations syspref setting

If the syspref is set to "based on the EmailPatronRegistrations" setting, this allows the library to redirect the verification email so that they can essentially moderate accounts that self-register via the OPAC.

This enhancement also introduces a new notice OPAC_REG_VERIFY_LIB which includes the new account's details and the verification link.

To test:

1. Apply patches, install database updates, and restart services (if using ktd, do `koha-upgrade-schema kohadev` then `restart_all`)
2. Go to the staff interface, Koha administration, system preferences. Go to the OPAC tab and find the self-registration and modification section.
3. By default, the PatronSelfRegistrationVerifyByEmail is set to "not required". Change this to "must verify themselves via email".
4. Change EmailPatronRegistrations to anything other than "none" (we're not specifically testing this functionality).
5. Confirm that PatronSelfRegistration is set to "Allow", as are other required preferences (these should be set by default in ktd).

6. Go to the OPAC in another window. You may be automatically logged in, if so, log out.
7. On the homepage, click the "Create an account" link under the login section.
8. Fill in the required fields and submit.

9. In your commandline, go to the database and view the results from the message_queue table (`koha-mysql kohadev` then `select * from message_queue\G`)

10. Confirm there is a queued message to the new account holder with a verification link. Open the verification link in your browser (you may need to swap out the OPACBaseURL if that isn't set correctly)
11. Confirm the account's registration.
12. Repeat step 9. Confirm there is a queued message to whoever you set EmailPatronRegistrations to, confirming a new account was created.

13. Go to your staff interface tab (you may need to log in again).
14. Go to the staff interface, Koha administration, system preferences. Go to the OPAC tab and find the self-registration and modification section.
15. Change PatronSelfRegistrationVerifyByEmail to "must be verified via email sent to EmailPatronRegistrations"

16. Repeat steps 6-9.
17. Confirm there is a queued message to the EmailPatronRegistrations setting with a verification link. Open the verification link in your browser (you may need to swap out the OPACBaseURL if that isn't set correctly)
18. Confirm the account's registration.
19. Confirm the wording on the screen better reflects that you've confirmed someone else's account and provides the login credentials to send them.

Sponsored-by: Mental Health Education & Resource Centre