Attachment 10540 Details for Bug 7161 – Followup for 7161

[patch] Followup for 7161

patch.txt (text/plain), 3.24 KB, created by Marcel de Rooy on 2012-06-27 12:45:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2012-06-27 12:45:54 UTC

Size: 3.24 KB

patch

obsolete

>From ec437b6f73a1c078c67ebec2acda51562f701931 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 27 Jun 2012 14:34:24 +0200
>Subject: [PATCH] 7161 Followup for indentation openlibrary.js
>Content-Type: text/plain; charset="utf-8"
>
>Only whitespace changes to fix indentation after tab removal.
>---
> koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js |   55 +++++++++++-------------
> 1 files changed, 25 insertions(+), 30 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js b/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js
>index afac4d3..e5b9d28 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js
>+++ b/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js
>@@ -30,42 +30,37 @@ KOHA.OpenLibrary = {
>             "&callback=KOHA.OpenLibrary.olCallBack&jscmd=data");
>         scriptElement.setAttribute("type", "text/javascript");
>         document.documentElement.firstChild.appendChild(scriptElement);
>-
>     },
> 
>-
>-
>     /**
>      * Add cover pages <div
>      * and link to preview if div id is gbs-thumbnail-preview
>      */
>     olCallBack: function(booksInfo) {
>-    for (id in booksInfo) {
>-       var book = booksInfo[id];
>-       var isbn = id.substring(5);
>-       $("."+isbn).each(function() {
>-       var is_opacdetail = /openlibrary-thumbnail-preview/.exec($(this).attr("id"));
>-           var a = document.createElement("a");
>-           a.href = booksInfo.url;
>-           if (book.cover) {
>-               var img = document.createElement("img");
>-               if (is_opacdetail) {
>-        img.src = book.cover.medium;
>-        $(this).append(img);
>-                $(this).append(
>-                       '<div class="results_summary">' + '<a href="' + book.url + '">Preview</a></div>'
>-                   );
>-               } else {
>-            img.src = book.cover.small;
>-            $(this).append(img);
>+        for (id in booksInfo) {
>+            var book = booksInfo[id];
>+            var isbn = id.substring(5);
>+            $("."+isbn).each(function() {
>+                var is_opacdetail = /openlibrary-thumbnail-preview/.exec($(this).attr("id"));
>+                var a = document.createElement("a");
>+                a.href = booksInfo.url;
>+                if (book.cover) {
>+                    var img = document.createElement("img");
>+                    if (is_opacdetail) {
>+                        img.src = book.cover.medium;
>+                        $(this).append(img);
>+                        $(this).append('<div class="results_summary">' + '<a href="' + book.url + '">Preview</a></div>');
>+                    } else {
>+                        img.src = book.cover.small;
>+                        $(this).append(img);
>+                    }
>+                } else {
>+                    var message =  document.createElement("span");
>+                    $(message).attr("class","no-image");
>+                    $(message).html(NO_OL_JACKET);
>+                    $(this).append(message);
>+                }
>+            });
>         }
>-           } else {
>-               var message =  document.createElement("span");
>-               $(message).attr("class","no-image");
>-               $(message).html(NO_OL_JACKET);
>-               $(this).append(message);
>-           }
>-       });
>-   }
>- }
>+    }
> };
>-- 
>1.7.7.6
>

Actions: View | Diff | Splinter Review

Attachments on bug 7161: 6221 | 6227 | 9865 | 9873 | 10539 | 10540 | 11312