Attachment 105456 Details for Bug 25626 – Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin

[patch] Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin

Bug-25626-Fix-untranslatable-strings-on-the-OPAC-p.patch (text/plain), 3.42 KB, created by Jonathan Druart on 2020-06-01 08:27:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-06-01 08:27:44 UTC

Size: 3.42 KB

patch

obsolete

>From ad7d9f71bbf185b77edf10dfb4063efb6a3384f2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 1 Jun 2020 10:19:05 +0200
>Subject: [PATCH] Bug 25626: Fix untranslatable strings on the 'OPAC problem
> reports' admin
>
>The 'Sent to' and 'Status' column values were not translatable.
>
>Test plan:
>Translate the interface
>Report some problems at the OPAC
>Go to the admin page and notice that all the columns are now translated
>---
> .../prog/en/modules/admin/problem-reports.tt   | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt
>index b2e0ea5a08..8d10c3ed5b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt
>@@ -80,10 +80,24 @@
>                                         [% report.content | html %]
>                                     </td>
>                                     <td><a href="[% OPACBaseURL | url %][% report.problempage | url %]">[% OPACBaseURL | url %][% report.problempage | html %]</a></td>
>-                                    <td>[% report.recipient | html %]</td>
>+                                    <td>
>+                                        [% SWITCH report.recipient %]
>+                                        [% CASE 'admin' %]Koha administrator
>+                                        [% CASE 'library' %]A librarian
>+                                        [% END %]
>+                                    </td>
>                                     <td><span title="[% report.created_on | html %]">[% report.created_on | $KohaDates with_hours => 1 %]</span></td>
>                                     <td>[% INCLUDE 'patron-title.inc' patron => report.patron hide_patron_infos_if_needed=1 %]</td>
>-                                    <td class="status[% report.status | html %]" name="status"><span id="status_[% report.reportid | html %]">[% report.status | html %]</span></td>
>+                                    <td class="status[% report.status | html %]" name="status">
>+                                        <span id="status_[% report.reportid | html %]">
>+                                            [% SWITCH report.status %]
>+                                            [% CASE 'New' %]New
>+                                            [% CASE 'Closed' %]Closed
>+                                            [% CASE 'Viewed' %]Viewed
>+                                            [% CASE %]Unknown status ([% report.status | html %])
>+                                            [% END %]
>+                                        </span>
>+                                    </td>
>                                     <td class="actions">
>                                         [% IF ( report.status == 'New' ) %]
>                                             <button name="viewed" data-report_id="[% report.reportid | html %]" class="viewed btn btn-default btn-xs"><i class="fa fa-eye"></i> Mark viewed</button> <button name="closed" data-report_id="[% report.reportid | html %]" class="closed btn btn-default btn-xs"><i class="fa fa-times-circle"></i> Mark closed</button> <button name="new" disabled="disabled" data-report_id="[% report.reportid | html %]" class="new btn btn-default btn-xs"><i class="fa fa-star"></i> Mark new</button>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25626: 105456 | 108343 | 108625