Bugzilla – Attachment 106417 Details for
Bug 25724
Transferred item checked in to shelving cart has cart location removed when transfer is filled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25724: Do not call ModReserveStatus when completing transfer
Bug-25724-Do-not-call-ModReserveStatus-when-comple.patch (text/plain), 1.89 KB, created by
Andrew Fuerste-Henry
on 2020-06-29 18:32:20 UTC
(
hide
)
Description:
Bug 25724: Do not call ModReserveStatus when completing transfer
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2020-06-29 18:32:20 UTC
Size:
1.89 KB
patch
obsolete
>From b39a963aff58a16f2cce744389348a00da6fbe75 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 12 Jun 2020 10:51:36 +0000 >Subject: [PATCH] Bug 25724: Do not call ModReserveStatus when completing > transfer > >I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL >That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due >to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 > >Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. > >ModReserveStatus also calls CartToShelf regardless of what happens here. > >To test: >1 - Set UpdateItemLocationOnCheckin to: > _ALL_: CART >2 - SetAutomaticItemReturn = Do >3 - Check an item in at a different branch than it's homebranch to create a transfer >4 - Check the item in at it's homebranch >5 - View the item details page >6 - Item is not in CART location >7 - Apply patch >8 - Repeat >9 - Item is in CART location after completion of transfer > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> > >Signed-off-by: Jason Robb <jrobb@sekls.org> >--- > C4/Circulation.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 67a986b417..5d842f9c8e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2027,8 +2027,6 @@ sub AddReturn { > "UPDATE branchtransfers SET datearrived = now() WHERE itemnumber= ? AND datearrived IS NULL" > ); > $sth->execute( $item->itemnumber ); >- # if we have a reservation with valid transfer, we can set it's status to 'W' >- C4::Reserves::ModReserveStatus($item->itemnumber, 'W'); > } else { > $messages->{'WrongTransfer'} = $tobranch; > $messages->{'WrongTransferItem'} = $item->itemnumber; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25724
:
105790
|
105791
|
106416
|
106417
|
107372
|
107373