Bug 25724 - Transferred item checked in to shelving cart has cart location removed when transfer is filled
Summary: Transferred item checked in to shelving cart has cart location removed when t...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-12 10:50 UTC by Nick Clemens
Modified: 2020-06-29 18:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25724: Unit tests (1.61 KB, patch)
2020-06-12 11:16 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25724: Do not call ModReserveStatus when completing transfer (1.78 KB, patch)
2020-06-12 11:16 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 25724: Unit tests (1.72 KB, patch)
2020-06-29 18:32 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25724: Do not call ModReserveStatus when completing transfer (1.89 KB, patch)
2020-06-29 18:32 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-06-12 10:50:53 UTC
To recreate:
1 - Set  UpdateItemLocationOnCheckin  to:
    _ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
Comment 1 Nick Clemens 2020-06-12 11:16:18 UTC
Created attachment 105790 [details] [review]
Bug 25724: Unit tests
Comment 2 Nick Clemens 2020-06-12 11:16:20 UTC
Created attachment 105791 [details] [review]
Bug 25724: Do not call ModReserveStatus when completing transfer

I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL
That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due
to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0

Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status.

ModReserveStatus also calls CartToShelf regardless of what happens here.

To test:
1 - Set  UpdateItemLocationOnCheckin  to:
    _ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
7 - Apply patch
8 - Repeat
9 - Item is in CART location after completion of transfer
Comment 3 Andrew Fuerste-Henry 2020-06-29 18:32:17 UTC
Created attachment 106416 [details] [review]
Bug 25724: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Jason Robb <jrobb@sekls.org>
Comment 4 Andrew Fuerste-Henry 2020-06-29 18:32:20 UTC
Created attachment 106417 [details] [review]
Bug 25724: Do not call ModReserveStatus when completing transfer

I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL
That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due
to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0

Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status.

ModReserveStatus also calls CartToShelf regardless of what happens here.

To test:
1 - Set  UpdateItemLocationOnCheckin  to:
    _ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
7 - Apply patch
8 - Repeat
9 - Item is in CART location after completion of transfer

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Jason Robb <jrobb@sekls.org>