Attachment 108654 Details for Bug 22343 – Bug 22343: Prevent passing password to the UI

[patch] Bug 22343: Prevent passing password to the UI

Bug-22343-Prevent-passing-password-to-the-UI.patch (text/plain), 1.91 KB, created by Kyle M Hall (khall) on 2020-08-19 15:17:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-08-19 15:17:02 UTC

Size: 1.91 KB

patch

obsolete

>From 467092a2c8a1a2a3b6f8ece766acdb72802fb3f3 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 10 Aug 2020 12:57:45 -0300
>Subject: [PATCH] Bug 22343: Prevent passing password to the UI
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> admin/smtp_servers.pl                                         | 3 +++
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/admin/smtp_servers.pl b/admin/smtp_servers.pl
>index 8733f3fa07..becdfb9d66 100755
>--- a/admin/smtp_servers.pl
>+++ b/admin/smtp_servers.pl
>@@ -165,6 +165,9 @@ elsif ( $op eq 'edit_save' ) {
>         my $password   = $input->param('smtp_password') || undef;
>         my $debug      = ( scalar $input->param('smtp_debug_mode') ) ? 1 : 0;
> 
>+        $password = undef
>+            if defined $password and $password eq '****';
>+
>         try {
>             $smtp_server->password( $password )
>                 if $password;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>index cac27fa5be..5a53431da9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>@@ -193,7 +193,7 @@
>                 </li>
>                 <li>
>                     <label for="smtp_password">Password: </label>
>-                    <input type="password" name="smtp_password" id="smtp_password" size="60"  value="[%- smtp_server.password | html -%]"/>
>+                    <input type="password" name="smtp_password" id="smtp_password" size="60"  value="****"/>
>                 </li>
>                 <li>
>                     <label for="smtp_debug_mode">Debug mode: </label>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 22343: 107598 | 107599 | 107600 | 107601 | 107602 | 107603 | 107604 | 107605 | 107987 | 107988 | 107989 | 107990 | 107991 | 107992 | 107993 | 107994 | 107995 | 107996 | 107997 | 107998 | 107999 | 108009 | 108107 | 108108 | 108109 | 108110 | 108111 | 108112 | 108113 | 108114 | 108115 | 108116 | 108117 | 108118 | 108119 | 108131 | 108132 | 108133 | 108134 | 108135 | 108136 | 108137 | 108138 | 108139 | 108140 | 108141 | 108142 | 108143 | 108529 | 108537 | 108538 | 108539 | 108540 | 108541 | 108542 | 108543 | 108544 | 108545 | 108546 | 108547 | 108548 | 108549 | 108609 | 108638 | 108642 | 108643 | 108644 | 108645 | 108646 | 108647 | 108648 | 108649 | 108650 | 108651 | 108652 | 108653 | 108654 | 108655 | 108656 | 108715 | 108716 | 109003 | 109004 | 109005 | 109006 | 109007 | 109008 | 109009 | 109010 | 109011 | 109012 | 109013 | 109014 | 109015 | 109016 | 109017 | 109018 | 109155 | 109156 | 109157 | 109158 | 109159 | 109160 | 109161 | 109162 | 109163 | 109164 | 109165 | 109166 | 109167 | 109168 | 109169 | 109170 | 109601 | 109602 | 109603 | 109604 | 109605 | 109606 | 109607 | 109608 | 109609 | 109610 | 109611 | 109612 | 109613 | 109614 | 109615 | 109616 | 109723 | 109724 | 109725 | 109726 | 109727 | 109728 | 109729 | 109730 | 109731 | 109732 | 109733 | 109734 | 109735 | 109736 | 109737 | 109738 | 109739 | 109740 | 109787 | 109788 | 111048 | 111087 | 111088 | 111089 | 111090 | 111154 | 111165 | 111166 | 111175 | 111176 | 111213 | 111215 | 111216 | 111442 | 111482 | 113240 | 113827 | 113847