Bugzilla – Attachment 11372 Details for
Bug 8172
Missing dereference marker for buildQuery parameter in addbooks.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8172: Followup: Removes useless empty params
Bug-8172-Followup-Removes-useless-empty-params.patch (text/plain), 1.82 KB, created by
Chris Cormack
on 2012-08-06 08:08:33 UTC
(
hide
)
Description:
Bug 8172: Followup: Removes useless empty params
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-08-06 08:08:33 UTC
Size:
1.82 KB
patch
obsolete
>From b5ffd4d27f34bd400731ef3da994f9ca929d2b56 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 2 Jul 2012 16:14:35 +0200 >Subject: [PATCH] Bug 8172: Followup: Removes useless empty params > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > C4/Search.pm | 2 +- > cataloguing/addbooks.pl | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index fd81610..9f843c3 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1792,7 +1792,7 @@ sub searchResults { > # XSLT processing of some stuff > use C4::Charset; > SetUTF8Flag($marcrecord); >- $debug && warn $marcrecord->as_formatted; >+ warn $marcrecord->as_formatted if $DEBUG; > my $interface = $search_context eq 'opac' ? 'OPAC' : ''; > if (!$scan && C4::Context->preference($interface . "XSLTResultsDisplay")) { > $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display($oldbiblio->{biblionumber}, $marcrecord, $interface."XSLTResultsDisplay", 1, \@hiddenitems); >diff --git a/cataloguing/addbooks.pl b/cataloguing/addbooks.pl >index 5f3b7d3..7bca2f3 100755 >--- a/cataloguing/addbooks.pl >+++ b/cataloguing/addbooks.pl >@@ -70,8 +70,7 @@ if ($query) { > > # build query > my @operands = $query; >- my (@operators, @indexes, @sort_by, @limits) = (); >- my ( $builterror,$builtquery,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$stopwords_removed,$query_type) = buildQuery(\@operators,\@operands,\@indexes,\@limits,\@sort_by,undef,undef); >+ my ( $builterror,$builtquery,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$stopwords_removed,$query_type) = buildQuery(undef,\@operands); > > # find results > my ( $error, $marcresults, $total_hits ) = SimpleSearch($builtquery, $results_per_page * ($page - 1), $results_per_page); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8172
:
10564
|
10576
|
10606
| 11372