Bugzilla – Attachment 11406 Details for
Bug 8575
Number of items expected is wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8575: Expected items count should not include cancelled orders
Bug-8575-Expected-items-count-should-not-include-c.patch (text/plain), 1.42 KB, created by
Chris Cormack
on 2012-08-07 08:28:11 UTC
(
hide
)
Description:
Bug 8575: Expected items count should not include cancelled orders
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-08-07 08:28:11 UTC
Size:
1.42 KB
patch
obsolete
>From 934975eae5864fdad1a2f45fd70574b5efa22f1b Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 6 Aug 2012 14:20:25 +0200 >Subject: [PATCH] Bug 8575: Expected items count should not include cancelled > orders > >To test: > 1/ create a new basket with 2 orders, one with 1 item, another with 2 > items > 2/ look at booksellers.pl page, you should see that 3 items are > expected > 3/ cancel the order with 1 item > 4/ refresh booksellers.pl page, it should remains 2 expected items > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Works exactly as designed >--- > C4/Acquisition.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 9678ffc..f6f5805 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -565,7 +565,12 @@ sub GetBasketsInfosByBookseller { > SELECT aqbasket.*, > SUM(aqorders.quantity) AS total_items, > COUNT(DISTINCT aqorders.biblionumber) AS total_biblios, >- SUM(IF(aqorders.datereceived IS NULL, aqorders.quantity, 0)) AS expected_items >+ SUM( >+ IF(aqorders.datereceived IS NULL >+ AND aqorders.datecancellationprinted IS NULL >+ , aqorders.quantity >+ , 0) >+ ) AS expected_items > FROM aqbasket > LEFT JOIN aqorders ON aqorders.basketno = aqbasket.basketno > WHERE booksellerid = ? >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8575
:
11380
| 11406