Bugzilla – Attachment 114806 Details for
Bug 27034
$c->objects->search shouldn't use path parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27034: (follow-up) Remove unneeded params tweak
Bug-27034-follow-up-Remove-unneeded-params-tweak.patch (text/plain), 1.09 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-01-04 15:26:43 UTC
(
hide
)
Description:
Bug 27034: (follow-up) Remove unneeded params tweak
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-01-04 15:26:43 UTC
Size:
1.09 KB
patch
obsolete
>From b3e5ab9f33fb98418e3b1e6a5c77bf4f2aa54a6a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 4 Jan 2021 12:23:46 -0300 >Subject: [PATCH] Bug 27034: (follow-up) Remove unneeded params tweak > >As $c->objects->search doesn't consider path params anymore, there's no >need to manually tweak the query parameters. > >To test: >1. Run: > $ kshell > k$ prove t/db_dependent/api/v1/holds.t >=> SUCCESS: Tests pass! >2. Apply this patch >3. Repeat 1 >=> SUCCESS: Tests still pass! >4. Sign off :-D >--- > Koha/REST/V1/Holds.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm >index ea233ffb32..7d8eb6e813 100644 >--- a/Koha/REST/V1/Holds.pm >+++ b/Koha/REST/V1/Holds.pm >@@ -445,8 +445,6 @@ sub pickup_locations { > my $c = shift->openapi->valid_input or return; > > my $hold_id = $c->validation->param('hold_id'); >- # FIXME: We should really skip the path params in $c->objects->search >- delete $c->validation->output->{hold_id}; > my $hold = Koha::Holds->find( $hold_id, { prefetch => [ 'patron' ] } ); > > unless ($hold) { >-- >2.30.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27034
:
114777
|
114806
|
115796
|
115797
|
115805
|
115806