Bugzilla – Attachment 116100 Details for
Bug 27538
Cells in the bottom filtering row of the "Holds to pull" table shifted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27538: fix correlation of fields in Holds to Pull table
Bug-27538-fix-correlation-of-fields-in-Holds-to-Pu.patch (text/plain), 3.63 KB, created by
Katrin Fischer
on 2021-01-31 13:16:18 UTC
(
hide
)
Description:
Bug 27538: fix correlation of fields in Holds to Pull table
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-01-31 13:16:18 UTC
Size:
3.63 KB
patch
obsolete
>From 404220f5c7e42b8f87280fd85198f51bba5200d6 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Sun, 24 Jan 2021 21:42:10 +0200 >Subject: [PATCH] Bug 27538: fix correlation of fields in Holds to Pull table > >Bottom filtering row of "Holds to pull" table do not correlate to other >ones, columns diverged from "Call numbers" cell: it should be under >"Available call numbers" while it's under "Available barcodes", and so >on to the last cell (while number of cells still adjusted). > >To reproduce: > 1) Head to the Holds to Pull page, check that bottom filtering row > shifted to the left by one, starting from the "Call number" > column and don't correlate to the upper table (for example, "Call > numbers" cell should be under "Available call numbers" while it's > under "Available barcodes"), and so on for all cells till the end > of the filtering row. > 2) Apply patch. > 3) Refresh Holds to Pull page and ensure that all filtering row > columns correlate to other rows columns correctly. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/circ/pendingreserves.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 1ee212e321..bfa73814b9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -205,14 +205,14 @@ > <td><input type="text" class="filter" data-column_num="3" placeholder="Patron name" style="width:95%"/></td> > <td><input type="text" class="filter" data-column_num="4" placeholder="Title" style="width:95%"/></td> > <td id="homebranchfilter"></td> >- <td><input type="text" class="filter" data-column_num="6" placeholder="Call number" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="7" placeholder="Available copy" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="8" placeholder="Available enumeration" style="width:95%"/></td> >+ <td></td> >+ <td><input type="text" class="filter" data-column_num="7" placeholder="Call number" style="width:95%"/></td> >+ <td><input type="text" class="filter" data-column_num="8" placeholder="Available copy" style="width:95%"/></td> >+ <td><input type="text" class="filter" data-column_num="9" placeholder="Available enumeration" style="width:95%"/></td> > <td id="itemtype-filter"></td> > <td id="locationfilter"></td> > <td></td> > <td></td> >- <td></td> > </tr> > </tfoot> > </table> >@@ -309,15 +309,15 @@ > }); > }); > $("#itemtype-filter").each( function () { >- $(this).html( createSelect( holdst.fnGetColumnData(9) ) ); >+ $(this).html( createSelect( holdst.fnGetColumnData(10) ) ); > $('select', this).change( function () { >- holdst.fnFilter( $(this).val(), 9 ); >+ holdst.fnFilter( $(this).val(), 10 ); > }); > }); > $("#locationfilter").each( function () { >- $(this).html( createSelect( holdst.fnGetColumnData(10) ) ); >+ $(this).html( createSelect( holdst.fnGetColumnData(11) ) ); > $('select', this).change( function () { >- holdst.fnFilter( $(this).val(), 10 ); >+ holdst.fnFilter( $(this).val(), 11 ); > }); > }); > }); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27538
:
115730
|
115777
| 116100