Attachment 118262 Details for Bug 24194 – Bug 24194: (follow-up) Link references to new preference

[patch] Bug 24194: (follow-up) Link references to new preference

Bug-24194-follow-up-Link-references-to-new-prefere.patch (text/plain), 4.50 KB, created by Aleisha Amohia on 2021-03-16 01:41:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2021-03-16 01:41:20 UTC

Size: 4.50 KB

patch

obsolete

>From fa17a6b2dd199c76fa4e40d90bf2f4e9d0676ec2 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 19 Feb 2021 17:18:35 +0000
>Subject: [PATCH] Bug 24194: (follow-up) Link references to new preference
>
>As was done in Bug 27263, references to one system preference in another
>system preference's description should be a link back to the mentioned
>preference.
>
>To test, apply the patch go to Administration -> Global system
>preferences.
>
>- Search for "ReserveExpiration."
>- Besides the preference itself, you should get four other preferences
> which have mentions of "ReserveExpiration" in their descriptions.
>- Confirm that each mention in the description is a link to a search for
> "ReserveExpiration."
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=24914
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index ac275868a8..ab9ce1901a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -726,18 +726,18 @@ Circulation:
> - Mark a hold as problematic if it has been waiting for more than
> - pref: ReservesMaxPickUpDelay
> class: integer
>- - "days. NOTE: If ReserveExpiration is disabled, holds marked as problematic must be dealt with manually as they will never automatically expire."
>+ - 'days. NOTE: If <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReserveExpiration">ReserveExpiration</a> is disabled, holds marked as problematic must be dealt with manually as they will never automatically expire.'
> -
> - pref: ExpireReservesMaxPickUpDelay
> choices:
> 1: Allow
> 0: "Don't allow"
>- - 'holds to expire automatically if they have not been picked by within the time period specified in the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReservesMaxPickUpDelay">ReservesMaxPickUpDelay</a> system preference. NOTE: This system preference requires the <code>misc/cronjobs/holds/cancel_expired_holds.pl</code> cronjob. Ask your system administrator to schedule it. NOTE: This will not apply if ReserveExpiration is disabled."'
>+ - 'holds to expire automatically if they have not been picked by within the time period specified in the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReservesMaxPickUpDelay">ReservesMaxPickUpDelay</a> system preference. NOTE: This system preference requires the <code>misc/cronjobs/holds/cancel_expired_holds.pl</code> cronjob. Ask your system administrator to schedule it. NOTE: This will not apply if <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReserveExpiration">ReserveExpiration</a> is disabled.'
> -
> - If using <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ExpireReservesMaxPickUpDelay">ExpireReservesMaxPickUpDelay</a>, charge a patron who allows their waiting hold to expire a fee of
> - pref: ExpireReservesMaxPickUpDelayCharge
> class: currency
>- - ". NOTE: This will not apply if ReserveExpiration is disabled."
>+ - '. NOTE: This will not apply if <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReserveExpiration">ReserveExpiration</a> is disabled.'
> -
> - Satisfy holds using items from the libraries
> - pref: StaticHoldsQueueWeight
>@@ -819,7 +819,7 @@ Circulation:
> choices:
> 1: Allow
> 0: "Don't allow"
>- - expired holds to be canceled on days the library is closed. NOTE: This will not apply if ReserveExpiration is disabled.
>+ - 'expired holds to be canceled on days the library is closed. NOTE: This will not apply if <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ReserveExpiration">ReserveExpiration</a> is disabled.'
> -
> - pref: ExcludeHolidaysFromMaxPickUpDelay
> choices:
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24194: 96120 | 96121 | 98048 | 98368 | 100927 | 110082 | 110127 | 111443 | 113284 | 113285 | 116626 | 116627 | 117016 | 117085 | 117089 | 117097 | 117098 | 117099 | 117100 | 117101 | 118258 | 118259 | 118260 | 118261 | 118262 | 118263 | 128301 | 128302 | 128303 | 128304 | 128305 | 128306 | 128307 | 128308 | 140646 | 140647 | 144076 | 147527 | 147528 | 150799 | 150800 | 159060 | 159061 | 167796 | 167797 | 169174 | 174650 | 174651 | 174652