Created attachment 96120 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide'
5) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
6) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.

Sponsored-by: Horowhenua Library Trust

Created attachment 96121 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide'
5) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
6) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Created attachment 98048 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set HideReserveExpiration system preference to 'Hide'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Created attachment 98368 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set HideReserveExpiration system preference to 'Hide'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 100927 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 110082 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 110127 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 111443 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 113284 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 113285 [details] [review]
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

Created attachment 116626 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 116627 [details] [review]
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

Created attachment 117016 [details] [review]
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

Created attachment 117085 [details] [review]
Bug 24194: (follow-up) Correct some missing instances

This patch fixes some instances where hold expiration dates are set or
referenced.

To test, apply the patch and test the following pages with the
ReserveExpiration preference both on and off to confirm that expiration
dates are shown or hidden correctly.

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Created attachment 117089 [details] [review]
Bug 24194: (follow-up) Link references to new preference

As was done in Bug 27263, references to one system preference in another
system preference's description should be a link back to the mentioned
preference.

To test, apply the patch go to Administration -> Global system
preferences.

- Search for "ReserveExpiration."
- Besides the preference itself, you should get four other preferences
  which have mentions of "ReserveExpiration" in their descriptions.
- Confirm that each mention in the description is a link to a search for
  "ReserveExpiration."

Created attachment 117097 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Created attachment 117098 [details] [review]
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

https://bugs.koha-community.org/show_bug.cgi?id=24194

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 117099 [details] [review]
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 117100 [details] [review]
Bug 24194: (follow-up) Correct some missing instances

This patch fixes some instances where hold expiration dates are set or
referenced.

To test, apply the patch and test the following pages with the
ReserveExpiration preference both on and off to confirm that expiration
dates are shown or hidden correctly.

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 117101 [details] [review]
Bug 24194: (follow-up) Link references to new preference

As was done in Bug 27263, references to one system preference in another
system preference's description should be a link back to the mentioned
preference.

To test, apply the patch go to Administration -> Global system
preferences.

- Search for "ReserveExpiration."
- Besides the preference itself, you should get four other preferences
  which have mentions of "ReserveExpiration" in their descriptions.
- Confirm that each mention in the description is a link to a search for
  "ReserveExpiration."

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118258 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118259 [details] [review]
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

https://bugs.koha-community.org/show_bug.cgi?id=24194

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118260 [details] [review]
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118261 [details] [review]
Bug 24194: (follow-up) Correct some missing instances

This patch fixes some instances where hold expiration dates are set or
referenced.

To test, apply the patch and test the following pages with the
ReserveExpiration preference both on and off to confirm that expiration
dates are shown or hidden correctly.

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118262 [details] [review]
Bug 24194: (follow-up) Link references to new preference

As was done in Bug 27263, references to one system preference in another
system preference's description should be a link back to the mentioned
preference.

To test, apply the patch go to Administration -> Global system
preferences.

- Search for "ReserveExpiration."
- Besides the preference itself, you should get four other preferences
  which have mentions of "ReserveExpiration" in their descriptions.
- Confirm that each mention in the description is a link to a search for
  "ReserveExpiration."

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 118263 [details] [review]
Bug 24194: (follow-up) Use ReservesExpiration in other places

Created attachment 128301 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 128302 [details] [review]
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

https://bugs.koha-community.org/show_bug.cgi?id=24194

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 128303 [details] [review]
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 128304 [details] [review]
Bug 24194: (follow-up) Correct some missing instances

This patch fixes some instances where hold expiration dates are set or
referenced.

To test, apply the patch and test the following pages with the
ReserveExpiration preference both on and off to confirm that expiration
dates are shown or hidden correctly.

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 128305 [details] [review]
Bug 24194: (follow-up) Link references to new preference

As was done in Bug 27263, references to one system preference in another
system preference's description should be a link back to the mentioned
preference.

To test, apply the patch go to Administration -> Global system
preferences.

- Search for "ReserveExpiration."
- Besides the preference itself, you should get four other preferences
  which have mentions of "ReserveExpiration" in their descriptions.
- Confirm that each mention in the description is a link to a search for
  "ReserveExpiration."

Signed-off-by: David Nind <david@davidnind.com>

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 128306 [details] [review]
Bug 24194: (follow-up) Use ReservesExpiration in other places

Created attachment 128307 [details] [review]
Bug 24194: (follow-up) Use ExpireReservesMaxPickUpDelay when setting hold waiting

If ExpireReservesMaxPickUpDelay is disabled then we don't need to set an
expiration date when setting a hold as waiting

Created attachment 128308 [details] [review]
Bug 24194: (follow-up) Throw an error if expiration date used

Created attachment 140646 [details] [review]
Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 140647 [details] [review]
Bug 24194: (follow-up) Throw an error if expiration date used

Created attachment 144076 [details] [review]
Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 147527 [details] [review]
Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 147528 [details] [review]
Bug 24194: (follow-up) Throw an error if expiration date used

Created attachment 150799 [details] [review]
Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>

Created attachment 150800 [details] [review]
Bug 24194: (follow-up) Throw an error if expiration date used

Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>