Bug 24194 - Add system preference to disable the use of expiration dates for reserves
Summary: Add system preference to disable the use of expiration dates for reserves
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-09 20:23 UTC by Aleisha Amohia
Modified: 2020-03-17 22:41 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves (7.75 KB, patch)
2019-12-09 20:46 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves (7.85 KB, patch)
2019-12-09 21:41 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves (11.29 KB, patch)
2020-01-29 03:08 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves (11.38 KB, patch)
2020-02-04 09:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves (11.87 KB, patch)
2020-03-17 22:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2019-12-09 20:23:41 UTC
Some libraries do not need to set expiration dates for reserves (this functionality is used).
Add the ability to hide these options when placing reserves in staff client and OPAC.
Comment 1 Aleisha Amohia 2019-12-09 20:46:05 UTC
Created attachment 96120 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide'
5) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
6) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.

Sponsored-by: Horowhenua Library Trust
Comment 2 ByWater Sandboxes 2019-12-09 21:41:41 UTC
Created attachment 96121 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide'
5) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
6) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 3 Jonathan Druart 2019-12-27 14:55:02 UTC
Should not it be hidden locally in CSS or JS instead?
Comment 4 Aleisha Amohia 2020-01-29 03:08:33 UTC
Created attachment 98048 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set HideReserveExpiration system preference to 'Hide'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust
Comment 5 Aleisha Amohia 2020-01-29 03:10:00 UTC
(In reply to Jonathan Druart from comment #3)
> Should not it be hidden locally in CSS or JS instead?

It turns out the library wants to not use expiration dates for reserves at all, so the latest patch now includes not setting an expiration date when setting a reserve as waiting, and nullifying an expiration date when reverting waiting status. Back to needs signoff, with a new test plan.
Comment 6 Katrin Fischer 2020-01-29 07:12:44 UTC
(In reply to Aleisha Amohia from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Should not it be hidden locally in CSS or JS instead?
> 
> It turns out the library wants to not use expiration dates for reserves at
> all, so the latest patch now includes not setting an expiration date when
> setting a reserve as waiting, and nullifying an expiration date when
> reverting waiting status. Back to needs signoff, with a new test plan.

Hi Aleisha, can you please update the bug title? Sounds like quite a different thing now!
Comment 7 Aleisha Amohia 2020-01-29 19:55:36 UTC
(In reply to Katrin Fischer from comment #6)
> (In reply to Aleisha Amohia from comment #5)
> > (In reply to Jonathan Druart from comment #3)
> > > Should not it be hidden locally in CSS or JS instead?
> > 
> > It turns out the library wants to not use expiration dates for reserves at
> > all, so the latest patch now includes not setting an expiration date when
> > setting a reserve as waiting, and nullifying an expiration date when
> > reverting waiting status. Back to needs signoff, with a new test plan.
> 
> Hi Aleisha, can you please update the bug title? Sounds like quite a
> different thing now!

Fair enough Katrin, have updated!
Comment 8 David Nind 2020-02-04 09:50:40 UTC
Created attachment 98368 [details] [review]
Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set HideReserveExpiration system preference to 'Hide'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2020-02-04 09:53:02 UTC
I worked through the test plan and I think everything works as expected. But it may require sign-off or review from someone who is more familiar with holds/reserves!
Comment 10 Jonathan Druart 2020-03-17 14:46:10 UTC
It's much more than "hide"/"show". I think we should rename the pref and update its description to explain a bit more this new enhancement.
Comment 11 Aleisha Amohia 2020-03-17 22:41:42 UTC
Created attachment 100927 [details] [review]
Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david@davidnind.com>