Bugzilla – Attachment 120918 Details for
Bug 28345
Patron attributes no longer have option to select empty class
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28345: Patron attributes no longer have option to select empty class
Bug-28345-Patron-attributes-no-longer-have-option-.patch (text/plain), 1.88 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-05-13 11:08:49 UTC
(
hide
)
Description:
Bug 28345: Patron attributes no longer have option to select empty class
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-05-13 11:08:49 UTC
Size:
1.88 KB
patch
obsolete
>From 9dc6db9f0e618c4628efcb97e7daff8c036e8ded Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 13 May 2021 10:39:38 +0000 >Subject: [PATCH] Bug 28345: Patron attributes no longer have option to select > empty class > >This patch adds the "empty" parameter to the PROCESS directive which >builds the "Class" dropdown. This allows the user to choose a blank >option when creating or editing a patron attribute. > >To test, apply the patch and go to Administration -> Patron attribute >types -> Add patron attribute type. > >In the entry form the "Class" dropdown should have a blank option. When >editing an existing attribute with a class defined, the correct class >should still be preselected. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >index 04cf5ca8b6d..22c65fc19cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >@@ -231,7 +231,7 @@ Patron attribute types › Administration › Koha > </li> > <li> > <label for="class">Class: </label> >- [% PROCESS 'av-build-dropbox.inc' name="class", category="PA_CLASS" default=attribute_type.class %] >+ [% PROCESS 'av-build-dropbox.inc' name="class", category="PA_CLASS" default=attribute_type.class empty=1 %] > <div class="hint"> > [% IF ( CAN_user_parameters_manage_auth_values ) %] > Group attributes types with a block title (based on <a target="_blank" href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=PA_CLASS">authorized values category 'PA_CLASS'</a>) >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28345
:
120916
|
120918
|
120945