Bug 20443 changed how the "class" dropdown was created, now using av-build-dropbox.inc to build the <select>. This introduced a minor regression: It's no longer possible to select an empty value for the class. The PROCESS directive needs to pass the "empty" parameter to enable a blank option.
Created attachment 120916 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected.
Created attachment 120918 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 120945 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.