Bugzilla – Attachment 121342 Details for
Bug 27899
Missing description for libraryNotPickupLocation on request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27899: Missing description for libraryNotPickupLocation on request.pl
Bug-27899-Missing-description-for-libraryNotPickup.patch (text/plain), 2.49 KB, created by
Victor Grousset/tuxayo
on 2021-05-24 16:43:25 UTC
(
hide
)
Description:
Bug 27899: Missing description for libraryNotPickupLocation on request.pl
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2021-05-24 16:43:25 UTC
Size:
2.49 KB
patch
obsolete
>From 630a1f23e975a5213b7bfb661b2e57a9155f73b7 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 15 Mar 2021 14:07:26 +0000 >Subject: [PATCH] Bug 27899: Missing description for libraryNotPickupLocation > on request.pl > >This patch adds text to the holds template in the staff client so that >if a particular item is at a library which isn't a hold location the >error message is descriptive. > >To test, apply the patch and go to Administration -> Libraries. > > - Change one of your libraries so that "Pickup location" is set to > "No." > - Locate a title in the catalog which has an item at that location. > - The "pick up at" list will exclude the library so and additional steps > must be taken to get the message > - Select a patron and set their library to the one we can't pick up at. > - Start the process of placing a hold on the title. > - After selecting the patron to place the hold for, look at the table of > items under "Place a hold on a specific item." > - The item located at the library you modified should show an error > message in the "Hold" column, "Library is not a pickup location." > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 9598f41c87..023049f011 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -629,6 +629,8 @@ > Only pickup locations within the same hold group are allowed > [% ELSIF itemloo.not_holdable == 'noReservesAllowed' %] > No reserves are allowed on this item >+ [% ELSIF itemloo.not_holdable == 'libraryNotPickupLocation' %] >+ Library is not a pickup location > [% ELSE %] > [% itemloo.not_holdable | html %] > [% END %] >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27899
:
117944
|
118235
|
118240
|
119186
|
120864
| 121342