As the attached screenshot highlights, there's no description for that error status.
Created attachment 117944 [details] screenshot
Created attachment 118235 [details] [review] Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "PLace a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location."
Created attachment 118240 [details] [review] Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "PLace a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I think I am missing something in the test plan: - I am using "Fairview" for testing. - I have set Fairview to be no pickup location in libraries. - I have made sure that there are no other rules blocking a hold on the items. - In the pick-up location pull down, Fairview no longer shows up. Therefore... there is no error for any item specific hold? I am not sure what I am missing here in order to trigger the error. I think there was some recent work on pick-up locations - maybe something changed?
Created attachment 119186 [details] Screenshot showing more context You're on the right track but you're looking at the wrong area of the page. See the attached screenshot, in the section with the heading "Place a hold on a specific item."
Hi Owen, sorry, I did check there, but it was not showing. I only got the general message "No items can be blaced on hold" IIRC. Maybe something different in configuration? Not unhappy if someone else wants to try their hand at this.
Same as Katrin for me, or there is something missing in the test plan or it's related to bug 28118.
Created attachment 120864 [details] [review] Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "Place a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Rebased for additional testing.
Switch back to NQA.
Created attachment 121342 [details] [review] Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - The "pick up at" list will exclude the library so and additional steps must be taken to get the message - Select a patron and set their library to the one we can't pick up at. - Start the process of placing a hold on the title. - After selecting the patron to place the hold for, look at the table of items under "Place a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, code looks good, change makes sense, QA script happy Passed QA :D
Also added a step in the test plan to be sure to get the message: - The "pick up at" list will exclude the library so and additional steps must be taken to get the message - Select a patron and set their library to the one we can't pick up at.
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.07
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.