Bugzilla – Attachment 121724 Details for
Bug 28382
'Reserve' should be passed through as transfer reason appropriately in branchtransfers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer
Bug-28382-Set-trigger-to-Reserve-when-actioning-a-.patch (text/plain), 2.14 KB, created by
Joonas Kylmälä
on 2021-06-08 13:41:40 UTC
(
hide
)
Description:
Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-06-08 13:41:40 UTC
Size:
2.14 KB
patch
obsolete
>From 95ee993fee29ced6e199afbd553c8620ffee433a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 19 May 2021 09:37:35 +0100 >Subject: [PATCH] Bug 28382: Set trigger to 'Reserve' when actioning a reserve > transfer >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch sets the transfer trigger to 'Reserve' when the staff user >confirms they are transfering to fulfil a reserve. > >Test plan >1 - Place a hold for delivery at Library B >2 - Sign in at Library A >3 - Browse to Circulation->Transfers >4 - Attempt to transfer an item on the title with the hold to Library B >5 - You get a notice that hold was found >6 - You have the option transfer the for the hold - click it >7 - Confirm hold is set to transit and transfer generated >8 - Check the branchtransfers table and confirm the 'reason' is > 'Reserve' not 'Manual'. > >Signed-off-by: David Nind <david@davidnind.com> >JK: fix typo resver -> reserve >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > circ/branchtransfers.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index ca14276e09..9a652750de 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -82,6 +82,7 @@ my $settransit; > my $request = $query->param('request') || ''; > my $borrowernumber = $query->param('borrowernumber') || 0; > my $tobranchcd = $query->param('tobranchcd') || ''; >+my $trigger = 'Manual'; > > my $ignoreRs = 0; > ############ >@@ -105,6 +106,7 @@ elsif ( $request eq "SetTransit" ) { > $ignoreRs = 1; > $settransit = 1; > $reqmessage = 1; >+ $trigger = 'Reserve'; > } > elsif ( $request eq 'KillReserved' ) { > my $biblionumber = $query->param('biblionumber'); >@@ -132,7 +134,7 @@ if ($barcode) { > to_branch => $tobranchcd, > barcode => $barcode, > ignore_reserves => $ignoreRs, >- trigger => 'Manual' >+ trigger => $trigger > }); > my $item = Koha::Items->find({ barcode => $barcode }); > $found = $messages->{'ResFound'} unless $settransit; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28382
:
121145
|
121152
| 121724