The 'branchtransfers' script can be used to initiate a transfer, but it is currently hard coded to always record the transfer trigger as 'Manual'.. in some cases the transfer prompts the user that a reserve has been found and allows them to make the decision that the transfer if to satisfy the reserve.. as such we should pass through the trigger in this case.
Created attachment 121145 [details] [review] Bug 28382: Set trigger to 'Reserve' when actioning a resver transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'.
Created attachment 121152 [details] [review] Bug 28382: Set trigger to 'Reserve' when actioning a resver transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind <david@davidnind.com>
Can/Should we turn "Reserve" into "hold" to follow terminology guidelines?
It's pre-existing, and it's a code that translates in templates to a suitable string.. I'm not too worried either way really.. it might be nice, but at the same time I think it should be done on it's own bug..?
(In reply to Martin Renvoize from comment #4) > It's pre-existing, and it's a code that translates in templates to a > suitable string.. I'm not too worried either way really.. it might be nice, > but at the same time I think it should be done on it's own bug..? I was nore sure if it was introduced here or reused - if it's preexisting I completely agree that it's out of scope here.
Created attachment 121724 [details] [review] Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind <david@davidnind.com> JK: fix typo resver -> reserve Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
PQA and switching status to bug because the reason was not right previously.
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.01
Depends on Bug 27064 not in 20.11.x