Attachment 12476 Details for Bug 8811 – [SIGNED-OFF] Bug 8811 - can't run report after saving

[patch] [SIGNED-OFF] Bug 8811 - can't run report after saving

SIGNED-OFF-Bug-8811---cant-run-report-after-saving.patch (text/plain), 1.79 KB, created by Nicole C. Engard on 2012-09-24 14:58:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-09-24 14:58:58 UTC

Size: 1.79 KB

patch

obsolete

>From c69460cd5a81e6e5948d14d9e591cafadbcb627e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 24 Sep 2012 10:47:27 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8811 - can't run report after saving
>
>The fix for Bug 7993 removed some lines from guided_reports.pl
>which passed a new report's name and id to the template after
>saving. For some reason this was removed, making it impossible
>to run or edit a new report immediately after saving.
>
>This patch adds back that part of the script which passes those
>variables to the template. Before this patch, after adding a new
>SQL report you would not see a "run this report" link. The
>"run this report" and "edit" buttons in the toolbar would not
>work. After applying the patch these should work.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>Tested creating reports and was able to run them after saving.
>---
> reports/guided_reports.pl |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index 00f52ef..de18072 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -501,7 +501,7 @@ elsif ( $phase eq 'Save Report' ) {
>         );
>     }
>     else {
>-        save_report( {
>+        my $id = save_report( {
>                 borrowernumber => $borrowernumber,
>                 sql            => $sql,
>                 name           => $name,
>@@ -513,7 +513,11 @@ elsif ( $phase eq 'Save Report' ) {
>                 cache_expiry   => $cache_expiry,
>                 public         => $public,
>             } );
>-        $template->param( 'save_successful' => 1, );
>+        $template->param(
>+            'save_successful' => 1,
>+            'reportname'      => $name,
>+            'id'              => $id,
>+        );
>     }
> }
> 
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8811: 12472 | 12474 | 12475 | 12476