Bug 8811 - can't run report after saving
Summary: can't run report after saving
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Mason James
URL:
Keywords:
Depends on: 7993
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-24 14:12 UTC by Nicole C. Engard
Modified: 2013-12-05 20:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
run report after saving (22.79 KB, image/png)
2012-09-24 14:12 UTC, Nicole C. Engard
Details
run report in 3.8.4 (28.00 KB, image/png)
2012-09-24 14:17 UTC, Nicole C. Engard
Details
Bug 8811 - can't run report after saving (1.69 KB, patch)
2012-09-24 14:52 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8811 - can't run report after saving (1.79 KB, patch)
2012-09-24 14:58 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-09-24 14:12:10 UTC
Created attachment 12472 [details]
run report after saving

After saving a new report, the link to run this report is gone, but the button remains (which is good), however if you click the button to run report it brings you to a blank screen that just has the 'New' button on it.
Comment 1 Nicole C. Engard 2012-09-24 14:17:57 UTC
Created attachment 12474 [details]
run report in 3.8.4

The link was there in 3.8.4
Comment 2 Nicole C. Engard 2012-09-24 14:39:20 UTC
From IRC:


[10:29]  <oleonard> nengard: The link doesn't appear because [% id %] is not present in the template, and the button doesn't work because [% id %] isn't present in the template
[10:30]  <oleonard> the edit button won't work either for the same reason
Comment 3 Owen Leonard 2012-09-24 14:52:53 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2012-09-24 14:58:58 UTC
Created attachment 12476 [details] [review]
[SIGNED-OFF] Bug 8811 - can't run report after saving

The fix for Bug 7993 removed some lines from guided_reports.pl
which passed a new report's name and id to the template after
saving. For some reason this was removed, making it impossible
to run or edit a new report immediately after saving.

This patch adds back that part of the script which passes those
variables to the template. Before this patch, after adding a new
SQL report you would not see a "run this report" link. The
"run this report" and "edit" buttons in the toolbar would not
work. After applying the patch these should work.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested creating reports and was able to run them after saving.
Comment 5 Mason James 2012-10-03 22:41:27 UTC
(In reply to comment #4)
> Created attachment 12476 [details] [review]
> [SIGNED-OFF] Bug 8811 - can't run report after saving
> 
> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
> Tested creating reports and was able to run them after saving.

works well, passing QA...

$ koha-qa.pl -c 1 

testing 1 commit(s) (applied to commit 6c18204)
 * d42ef70 Bug 8811 - can't run report after saving
      reports/guided_reports.pl

* reports/guided_reports.pl                                                OK
Comment 6 Paul Poulain 2012-10-05 15:26:31 UTC
Patch pushed to master. This patch is a bugfix for an ENH in 3.10, so not relevant for 3.8
Comment 7 Chris Cormack 2013-04-21 00:27:32 UTC
Released in 3.10.0