Attachment 12609 Details for Bug 8680 – [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.

[patch] [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.

SIGNED-OFF-Bug-8680-Z3950-ISBN-Search-is-problemat.patch (text/plain), 3.91 KB, created by Marc Véron on 2012-09-29 17:12:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2012-09-29 17:12:48 UTC

Size: 3.91 KB

patch

obsolete

>From 0e7625e9960ad72f6471574704b2364c15349f96 Mon Sep 17 00:00:00 2001
>From: Joseph Alway <jbalway@gmail.com>
>Date: Thu, 20 Sep 2012 12:39:28 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.
>Content-Type: text/plain; charset="utf-8"
>
>The changes here are duplicate fixes.
>The cataloguing directory had the same bugs as the acqui directory.
>The bugs in the cataloguing files of the same name were fixed in Bug 8550.
>The bugs in the acqui files had not been fixed.
>This will fix Bug 8680 which is in the Acquisitions Module.
>
>Changes to the z3950_search.pl file:
>Rather than treating ISBN and ISSN as the same, this patch breaks
>them out into separate parts of the query, as well as changing
>the truncation attribute to enable right truncation (the correct
>behavior for the ISBN field in MARC21, and valid behavior in
>UNIMARC).
>
>Changes to the z3950_search.tt file:
>Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search
>page, and the ISBN field replaced with a combined ISBN/ISSN field. Since
>this breaks ISBN search for most Z39.50 targets (due to the
>differing treatment of ISBN vs. ISSN), this is a bug not a feature.
>
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Works as expected.
>---
> acqui/z3950_search.pl                              |   12 ++++++++----
> .../prog/en/modules/acqui/z3950_search.tt          |    3 ++-
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/acqui/z3950_search.pl b/acqui/z3950_search.pl
>index 9dc8b6e..a1cdce4 100755
>--- a/acqui/z3950_search.pl
>+++ b/acqui/z3950_search.pl
>@@ -148,10 +148,14 @@ if ( $op ne "do_search" ) {
>     my $s = 0;
>     my $query;
>     my $nterms;
>-    if ($isbn || $issn) {
>-        $term=$isbn if ($isbn);
>-        $term=$issn if ($issn);
>-        $query .= " \@or \@attr 1=8 \"$term\" \@attr 1=7 \"$term\" ";
>+    if ($isbn) {
>+        $term=$isbn;
>+        $query .= " \@attr 1=7 \@attr 5=1 \"$term\" ";
>+        $nterms++;
>+    }
>+    if ($issn) {
>+        $term=$issn;
>+        $query .= " \@attr 1=8 \@attr 5=1 \"$term\" ";
>         $nterms++;
>     }
>     if ($title) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>index 0d4ef2e..7bb9241 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>@@ -75,7 +75,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
>     <div class="yui-u first">
> 	    <fieldset class="rows">
> 		 <ol><li><label for="searchtitle">Title: </label> <input type="text" id="searchtitle"  name="title" value="[% title |html %]" /></li>
>-		 <li><label for="isbn">ISBN/ISSN: </label> <input type="text" id="isbn" name="isbn" value="[% isbn %]" /></li>
>+		 <li><label for="isbn">ISBN: </label> <input type="text" id="isbn" name="isbn" value="[% isbn %]" /></li>
>          <li><label for="lccall">LC call number: </label> <input type="text" id="lccall" name="lccall" value="" /></li>
>          <li><label for="controlnumber">Control no.: </label> <input type="text" id="controlnumber" name="controlnumber" value="" /></li>
> </ol>
>@@ -83,6 +83,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
> 	    </div>
>     <div class="yui-u">
> 	<fieldset class="rows">		 <ol><li><label for="author">Author: </label> <input type="text" id="author" name="author" value="[% author %]" /></li>
>+         <li><label for="issn">ISSN: </label> <input type="text" id="issn" name="issn" value="[% issn %]" /></li>
>          <li> <label for="subject">Subject heading: </label> <input type="text" id="subject" name="subject" value="" /></li>
> 		 <li><label for="dewey">Dewey: </label> <input type="text" id="dewey" name="dewey" value="" /></li></ol></fieldset>
> 	     <fieldset class="rows" >
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8680: 12401 | 12609