Bugzilla – Attachment 12636 Details for
Bug 8861
Undefined variables in batchMod.pl trigger error logs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix inconsequential error loggling in batchMod.pl (3.8, 3.6)
0001-Bug-8861-Undefined-variables-in-batchMod.pl-trigger-.patch (text/plain), 1.44 KB, created by
Mark Tompsett
on 2012-10-02 13:47:37 UTC
(
hide
)
Description:
Fix inconsequential error loggling in batchMod.pl (3.8, 3.6)
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-10-02 13:47:37 UTC
Size:
1.44 KB
patch
obsolete
>From c6b88804890548601d54ba5d3c3b47e55ea899c0 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 2 Oct 2012 21:28:29 +0800 >Subject: [PATCH] Bug 8861 - Undefined variables in batchMod.pl trigger error > logs >Content-Type: text/plain; charset="utf-8" > >Initialized $op, and changed lines like "$op => 1" and >"$error => 1" into separate, conditional template param calls. >--- > tools/batchMod.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 5469496..00bf5cb 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -51,6 +51,7 @@ my $template_flag; > if (!defined $op) { > $template_name = "tools/batchMod.tmpl"; > $template_flag = { tools => '*' }; >+ $op = q{}; > } else { > $template_name = ($del) ? "tools/batchMod-del.tmpl" : "tools/batchMod-edit.tmpl"; > $template_flag = ($del) ? { tools => 'items_batchdel' } : { tools => 'items_batchmod' }; >@@ -432,8 +433,8 @@ foreach my $tag (sort keys %{$tagslib}) { > $template->param(%$items_display_hashref) if $items_display_hashref; > $template->param( > op => $nextop, >- $op => 1, > ); >+$template->param( $op => 1 ) if $op; > > if ($op eq "action") { > >@@ -449,7 +450,7 @@ if ($op eq "action") { > } > > foreach my $error (@errors) { >- $template->param($error => 1); >+ $template->param($error => 1) if $error; > } > output_html_with_http_headers $input, $cookie, $template->output; > exit; >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8861
:
12635
|
12636
|
12708
|
12709