Attachment 126408 Details for Bug 29242 – Bug 29242: Flatpickr - Should autocomplete be turned off?

[patch] Bug 29242: Flatpickr - Should autocomplete be turned off?

Bug-29242-Flatpickr---Should-autocomplete-be-turne.patch (text/plain), 1.56 KB, created by David Nind on 2021-10-16 18:35:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-10-16 18:35:33 UTC

Size: 1.56 KB

patch

obsolete

>From 9239de54b5fb7bd496933b79cf6ff0f23271eeaf Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 14 Oct 2021 17:56:23 +0000
>Subject: [PATCH] Bug 29242: Flatpickr - Should autocomplete be turned off?
>
>This patch adds a step to Flatpickr initialization to add an
>autocomplete attribute set to "off" so that browsers' built-in
>autocomplete menus do not obscure the calendar.
>
>To test you must be using a browser which has form history enabled.
>
>Locate a form that includes a Flatpickr input field, e.g.  Reports
>-> Catalog statistics.
>
>Fill the date fields and submit the form. Go back to the form and click
>one of the form fields you previously filled out (once in Chrome, twice
>in Firefox). The browser should not show its native form history
>dropdown.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>index aef5938d8e..23cd1cb77b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>@@ -40,6 +40,7 @@
>             $(instance.input)
>                 /* Add a wrapper element so that we can prevent the clear button from wrapping */
>                 .wrap("<span class='flatpickr_wrapper'></span>")
>+                .attr("autocomplete", "off")
>                 .after( $("<a/>")
>                     .attr("href","#")
>                     .addClass("clear_date")
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29242: 126302 | 126408 | 127140