Without autocomplete turned off: https://usercontent.irccloud-cdn.com/file/9NZax9ln/image.png Should we turn it off? On Chrome it appears right after the input has the focus, on Firefox you have to double click.
I like having the browser's autocomplete, but that may just be because I'm almost always in testing mode rather that using it live. We could set the autocomplete attribute upon initialization of the Flatpickr instance and avoid making any changes to the templates. Another idea is to tie into the "keydown" function we already have and set autocomplete to "on" if the user types a key other than an arrow key. Probably overkill.
Created attachment 126302 [details] [review] Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown.
Created attachment 126408 [details] [review] Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 127140 [details] [review] Bug 29242: Flatpickr - Should autocomplete be turned off? This patch adds a step to Flatpickr initialization to add an autocomplete attribute set to "off" so that browsers' built-in autocomplete menus do not obscure the calendar. To test you must be using a browser which has form history enabled. Locate a form that includes a Flatpickr input field, e.g. Reports -> Catalog statistics. Fill the date fields and submit the form. Go back to the form and click one of the form fields you previously filled out (once in Chrome, twice in Firefox). The browser should not show its native form history dropdown. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!