Bugzilla – Attachment 126410 Details for
Bug 29257
Redundant slash in the URL appear during item level hold placing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29257: Redundant slash in the URL appear during item level hold placing
Bug-29257-Redundant-slash-in-the-URL-appear-during.patch (text/plain), 1.69 KB, created by
Andrii Veremeienko
on 2021-10-17 13:12:59 UTC
(
hide
)
Description:
Bug 29257: Redundant slash in the URL appear during item level hold placing
Filename:
MIME Type:
Creator:
Andrii Veremeienko
Created:
2021-10-17 13:12:59 UTC
Size:
1.69 KB
patch
obsolete
>From 6a3ccc5c988e7374c531bb5fe75a3d27ad590cc9 Mon Sep 17 00:00:00 2001 >From: Andrii Veremeienko <averemeienko@jabra.com> >Date: Sun, 17 Oct 2021 14:43:34 +0300 >Subject: [PATCH] Bug 29257: Redundant slash in the URL appear during item > level hold placing > >The solution was to get rid of adding slash to $biblionumbers directly and >join slash only in place when it's needed. > >How to test: >1. Search for an item; >2. Select single item, click 'Place hold'; >3. Enter a patron card number; >4. Complete hold placing by clicking 'Place hold'; >5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; > >E.g.: >request.pl?biblionumbers=233 >--- > reserve/placerequest.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 5ee8dce2f6..3dd7bfb4b1 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -53,7 +53,7 @@ my $borrower = Koha::Patrons->find( $borrowernumber ); > $borrower = $borrower->unblessed if $borrower; > > my $biblionumbers = $input->param('biblionumbers'); >-$biblionumbers ||= $biblionumber . '/'; >+$biblionumbers ||= $biblionumber; > > my $bad_bibs = $input->param('bad_bibs'); > my $holds_to_place_count = $input->param('holds_to_place_count') || 1; >@@ -164,10 +164,11 @@ if ( $type eq 'str8' && $borrower ) { > } > } > >+ > if ($bad_bibs) { >- $biblionumbers .= $bad_bibs; >+ push @biblionumbers, $bad_bibs; > } >- print $input->redirect("request.pl?biblionumbers=$biblionumbers"); >+ print $input->redirect("request.pl?biblionumbers=" . join('/', @biblionumbers)); > } > elsif ( $borrowernumber eq '' ) { > print $input->header(); >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29257
:
126409
|
126410
|
126411
|
126412