After placing hold user is redirected to a link containing a redundant slash in the end, which leads to unexpected consequences. Steps to reproduce: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber); E.g.: request.pl?biblionumbers=233/
Created attachment 126409 [details] [review] Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233
Created attachment 126410 [details] [review] Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233
Created attachment 126411 [details] [review] Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233
Created attachment 126412 [details] [review] Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 Signed-off-by: David Nind <david@davidnind.com>
I haven't looked into this in-depth, but I'm wary of this one, especially in the context of item-specific multi-holds. I'm not going to look into it right now, but just sharing my thoughts. It would be worth expanding this test plan to different hold scenarios.
(In reply to David Cook from comment #5) > I haven't looked into this in-depth, but I'm wary of this one, especially in > the context of item-specific multi-holds. > > I'm not going to look into it right now, but just sharing my thoughts. It > would be worth expanding this test plan to different hold scenarios. I've taken a bit more of a look in light of bug 28782, and it looks the slashes are only important for the OPAC and not for the Staff Interface, so my objection withdrawn.
Just noting down here as well, if bug 28782 gets pushed then this bug is fixed as well.
(In reply to Joonas Kylmälä from comment #7) > Just noting down here as well, if bug 28782 gets pushed then this bug is > fixed as well. Yes, I think we should favor bug 28782's solution over this one. Or we based it on top of this one to make this patch backportable.
Will be fixed globally on bug 28782. *** This bug has been marked as a duplicate of bug 28782 ***