Bugzilla – Attachment 127140 Details for
Bug 29242
Flatpickr - Turn autocomplete off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29242: Flatpickr - Should autocomplete be turned off?
Bug-29242-Flatpickr---Should-autocomplete-be-turne.patch (text/plain), 1.61 KB, created by
Katrin Fischer
on 2021-10-31 14:42:29 UTC
(
hide
)
Description:
Bug 29242: Flatpickr - Should autocomplete be turned off?
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-10-31 14:42:29 UTC
Size:
1.61 KB
patch
obsolete
>From fcc12718ad87859ae050e090c7014d9eacade256 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 14 Oct 2021 17:56:23 +0000 >Subject: [PATCH] Bug 29242: Flatpickr - Should autocomplete be turned off? > >This patch adds a step to Flatpickr initialization to add an >autocomplete attribute set to "off" so that browsers' built-in >autocomplete menus do not obscure the calendar. > >To test you must be using a browser which has form history enabled. > >Locate a form that includes a Flatpickr input field, e.g. Reports >-> Catalog statistics. > >Fill the date fields and submit the form. Go back to the form and click >one of the form fields you previously filled out (once in Chrome, twice >in Firefox). The browser should not show its native form history >dropdown. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >index bd8c9e7b86..ca7bb3bc45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >@@ -34,6 +34,7 @@ > $(instance.input) > /* Add a wrapper element so that we can prevent the clear button from wrapping */ > .wrap("<span class='flatpickr_wrapper'></span>") >+ .attr("autocomplete", "off") > .after( $("<a/>") > .attr("href","#") > .addClass("clear_date") >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29242
:
126302
|
126408
| 127140