Bugzilla – Attachment 127324 Details for
Bug 29180
System preference RequestOnOpac should be renamed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests
Bug-29180-Rename-syspref-RequestOnOpac-with-OPACHo.patch (text/plain), 22.58 KB, created by
Andrew Fuerste-Henry
on 2021-11-04 17:26:36 UTC
(
hide
)
Description:
Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2021-11-04 17:26:36 UTC
Size:
22.58 KB
patch
obsolete
>From 1148a08d23762df3edc9c6bb790eee72e55b03ca Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 4 Nov 2021 14:39:28 +0100 >Subject: [PATCH] Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests > >It is a confusing name because we have 'Article Request' as a feature, >and this does not follow Koha terminology. > >Test plan: >`updatedatabase` and confirm that the syspref has been renamed >`git grep RequestOnOpac` => No occurrence in the code > >QA: The syspref's value is always retrieved using Koha.Preference from >.tt files, we don't need to send it from controllers or C4::Auth > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > C4/Auth.pm | 1 - > C4/UsageStats.pm | 2 +- > installer/data/mysql/atomicupdate/bug_29180.pl | 15 +++++++++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 2 +- > installer/data/mysql/update22to30.pl | 2 +- > installer/html-template-to-template-toolkit.pl | 2 +- > .../prog/en/modules/admin/preferences/opac.pref | 2 +- > .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- > .../bootstrap/en/includes/title-actions-menu.inc | 4 ++-- > .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- > .../bootstrap/en/modules/opac-opensearch.tt | 2 +- > .../bootstrap/en/modules/opac-results.tt | 10 +++++----- > .../bootstrap/en/modules/opac-sendbasketform.tt | 2 +- > .../bootstrap/en/modules/opac-sendshelfform.tt | 2 +- > .../bootstrap/en/modules/opac-shelves.tt | 6 +++--- > .../bootstrap/en/modules/opac-topissues.tt | 2 +- > opac/opac-ISBDdetail.pl | 1 - > opac/opac-MARCdetail.pl | 6 ------ > opac/opac-detail.pl | 1 - > opac/opac-reserve.pl | 4 ++-- > 20 files changed, 38 insertions(+), 32 deletions(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_29180.pl > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index b531ab4a6a..8606e64bb8 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -597,7 +597,6 @@ sub get_template_and_user { > OPACPrivacy => C4::Context->preference("OPACPrivacy"), > OPACFinesTab => C4::Context->preference("OPACFinesTab"), > OpacTopissue => C4::Context->preference("OpacTopissue"), >- RequestOnOpac => C4::Context->preference("RequestOnOpac"), > 'Version' => C4::Context->preference('Version'), > hidelostitems => C4::Context->preference("hidelostitems"), > mylibraryfirst => ( C4::Context->preference("SearchMyLibraryFirst") && C4::Context->userenv ) ? C4::Context->userenv->{'branch'} : '', >diff --git a/C4/UsageStats.pm b/C4/UsageStats.pm >index 2ff5303bcb..ef610b76bd 100644 >--- a/C4/UsageStats.pm >+++ b/C4/UsageStats.pm >@@ -305,7 +305,7 @@ sub _shared_preferences { > OpacTopissue > opacuserlogin > QuoteOfTheDay >- RequestOnOpac >+ OPACHoldRequests > OPACComments > ShowReviewer > ShowReviewerPhoto >diff --git a/installer/data/mysql/atomicupdate/bug_29180.pl b/installer/data/mysql/atomicupdate/bug_29180.pl >new file mode 100755 >index 0000000000..82e7c3039c >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_29180.pl >@@ -0,0 +1,15 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "29180", >+ description => "Rename system preference RequestOnOpac with OPACHoldRequests", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ $dbh->do(q{ >+ UPDATE systempreferences >+ SET variable="OPACHoldRequests" >+ WHERE variable="RequestOnOpac" >+ }); >+ }, >+} >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 9789af312e..fdc383b2b3 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -564,7 +564,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('RentalsInNoissuesCharge','1',NULL,'Rental charges block checkouts (added to noissuescharge).','YesNo'), > ('ReplyToDefault','',NULL,'Use this email address as the replyto in emails','Free'), > ('ReportsLog','0',NULL,'If ON, log information about reports.','YesNo'), >-('RequestOnOpac','1',NULL,'If ON, globally enables patron holds on OPAC','YesNo'), >+('OPACHoldRequests','1',NULL,'If ON, globally enables patron holds on OPAC','YesNo'), > ('RequireStrongPassword','1','','Require a strong login password for staff and patrons','YesNo'), > ('ReservesControlBranch','PatronLibrary','ItemHomeLibrary|PatronLibrary','Branch checked for members reservations rights','Choice'), > ('ReservesMaxPickUpDelay','7','','Define the Maximum delay to pick up an item on hold','Integer'), >diff --git a/installer/data/mysql/update22to30.pl b/installer/data/mysql/update22to30.pl >index c5a183dae9..7592c9b626 100755 >--- a/installer/data/mysql/update22to30.pl >+++ b/installer/data/mysql/update22to30.pl >@@ -414,7 +414,7 @@ my $DBversion = "3.00.00.000"; > }, > { > uniquefieldrequired => 'variable', >- variable => 'RequestOnOpac', >+ variable => 'OPACHoldRequests', > value => '1', > forceupdate => { 'explanation' => 1, > 'type' => 1}, >diff --git a/installer/html-template-to-template-toolkit.pl b/installer/html-template-to-template-toolkit.pl >index c1ad8a4917..f76c87c904 100755 >--- a/installer/html-template-to-template-toolkit.pl >+++ b/installer/html-template-to-template-toolkit.pl >@@ -27,7 +27,7 @@ my $tmpl_out_dir = 'koha-tt'; > # template toolkit variables NOT to scope, in other words, variables that need to remain global (case sensitive) > my @globals = ( "themelang","JacketImages","OPACAmazonCoverImages","GoogleJackets","BakerTaylorEnabled", > "SyndeticsEnabled", "OpacRenewalAllowed", "item_level_itypes","noItemTypeImages", >- "virtualshelves", "RequestOnOpac", "COinSinOPACResults", "OPACXSLTResultsDisplay", >+ "virtualshelves", "OPACHoldRequests", "COinSinOPACResults", "OPACXSLTResultsDisplay", > "OPACItemsResultsDisplay", "LibraryThingForLibrariesID", "opacuserlogin", "TagsEnabled", > "TagsShowOnList", "TagsInputOnList","loggedinusername","opacbookbag", > "OPACAmazonEnabled", "SyndeticsCoverImages" ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index c3e793794c..253cec7a06 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -474,7 +474,7 @@ OPAC: > 0: Hide > - reviewer's avatar beside comments in OPAC. The avatar will be searched on <a href="https://www.libravatar.org" target="_blank">Libravatar</a> using the patron's e-mail address. > - >- - pref: RequestOnOpac >+ - pref: OPACHoldRequests > choices: > 1: Allow > 0: "Don't allow" >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >index a110d73a2a..09c4e49456 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >@@ -3,7 +3,7 @@ > <ul id="action"> > [% UNLESS ( norequests ) %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] >- [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >+ [% IF Koha.Preference( 'OPACHoldRequests' ) == 1 %] > [% IF ( ReservableItems ) %] > <li><a class="reserve btn btn-link btn-lg" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></li> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >index 55ff553370..fb7312a17f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >@@ -1,5 +1,5 @@ > <div class="actions-menu noprint"> >- [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >+ [% IF Koha.Preference( 'OPACHoldRequests' ) == 1 %] > [% UNLESS ( items.norequests ) %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] > [% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %] >@@ -15,7 +15,7 @@ > [% END %] > [% END # / IF opacuserlogin %] > [% END # / UNLESS items.norequests %] >- [% END # / RequestOnOpac %] >+ [% END # / OPACHoldRequests %] > > [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %] > [% IF items.artreqpossible %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >index 3becf590f8..5c3e6beaa9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >@@ -60,7 +60,7 @@ > [% IF ( ( Koha.Preference( 'virtualshelves' ) == 1 ) && loggedinusername ) %] > <a href="#" class="btn btn-link btn-sm newshelf disabled" aria-disabled="true"><i class="fa fa-fw fa-list" aria-hidden="true"></i> Add to a list</a> > [% END %] >- [% IF ( Koha.Preference( 'RequestOnOpac' ) == 1 ) %] >+ [% IF ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) %] > <a href="#" class="btn btn-link btn-sm hold disabled" aria-disabled="true"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a> > [% END %] > [% IF ( TagsInputEnabled && loggedinusername ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >index 3d3ac81ed5..de69346dc4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >@@ -75,7 +75,7 @@ > [% IF ( SEARCH_RESULT.size ) %] [% SEARCH_RESULT.size | html %]. [% END %] > [% IF ( SEARCH_RESULT.isbn ) %] [% SEARCH_RESULT.isbn | html %][% END %] > </p> >-[% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >+[% IF Koha.Preference( 'OPACHoldRequests' ) == 1 %] > <p><a href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-reserve.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]">Place hold on <em>[% SEARCH_RESULT.title | html %]</em></a></p> > [% END %] > ]]></description> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index c71015b2cd..28b4bdef6c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -272,7 +272,7 @@ > </span> > [% END # /IF opacbookbag || virtualshelves %] > >- [% IF ( ( Koha.Preference( 'RequestOnOpac' ) == 1 ) && ( Koha.Preference( 'opacuserlogin' ) == 1 ) && DisplayMultiPlaceHold ) %] >+ [% IF ( ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) && ( Koha.Preference( 'opacuserlogin' ) == 1 ) && DisplayMultiPlaceHold ) %] > <button class="btn btn-link btn-sm hold disabled" type="button"> > <i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold > </button> >@@ -318,12 +318,12 @@ > [% IF Koha.Preference( 'virtualshelves' ) == 1 %] > <input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" aria-label="Select search result: [% check_title | html %]"/> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label> > [% ELSE %] >- [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >+ [% IF Koha.Preference( 'OPACHoldRequests' ) == 1 %] > [% UNLESS ( SEARCH_RESULT.norequests ) %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]<input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" aria-label="Select search result: [% check_title | html %]"/> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label> > [% END %] > [% END %] >- [% END # IF RequestOnOpac %] >+ [% END # IF OPACHoldRequests %] > [% END # IF virtualshelves %] > [% END # IF opacbookbag%] > </td> >@@ -597,7 +597,7 @@ > [% END %] > > <script> >- [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'RequestOnOpac' ) == 1 ) %] >+ [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) %] > function holdMultiple() { > var checkedBiblioNums = ""; // Separated by "/" > var checkedCount = 0; >@@ -622,7 +622,7 @@ > $("#hold_form_biblios").attr("value", numList); > $("#hold_form").submit(); > } >- [% END # /IF opacuserlogin && RequestOnOpac %] >+ [% END # /IF opacuserlogin && OPACHoldRequests %] > > [% IF ( TagsInputEnabled && loggedinusername ) %] > function tagSelected() { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >index 8066fdd034..907d930995 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt >@@ -37,7 +37,7 @@ > <input type="hidden" name="bib_list" value="[% bib_list | html %]" /> > <input type="hidden" name="csrf_token" value="[% csrf_token | html %]" /> > </fieldset> >- [% IF Koha.Preference('RequestOnOpac') || Koha.Preference('OpacRenewalAllowed') %]<p id="donotrequestbymail">Please do not use this mail to request or renew books.</p>[% END %] >+ [% IF Koha.Preference('OPACHoldRequests') || Koha.Preference('OpacRenewalAllowed') %]<p id="donotrequestbymail">Please do not use this mail to request or renew books.</p>[% END %] > <fieldset class="action"> > <input type="submit" class="btn btn-primary" value="Send" /> > <a class="cancel close" href="#">Cancel</a> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >index 9436385d15..b7eb7d7fb8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt >@@ -41,7 +41,7 @@ > > <input type="hidden" name="shelfid" value="[% shelfid | html %]" /> > </fieldset> >- [% IF Koha.Preference('RequestOnOpac') || Koha.Preference('OpacRenewalAllowed') %]<p id="donotrequestbymail">Please do not use this mail to request or renew books.</p>[% END %] >+ [% IF Koha.Preference('OPACHoldRequests') || Koha.Preference('OpacRenewalAllowed') %]<p id="donotrequestbymail">Please do not use this mail to request or renew books.</p>[% END %] > <fieldset class="action"> > <input type="submit" value="Send" class="btn btn-primary" /> > <a class="cancel close" href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% shelfid | html %]">Cancel</a> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 936a178442..1bab159c07 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -337,7 +337,7 @@ > </div> > <div class="links"> > <span class="selections">Select titles to: </span> >- [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'RequestOnOpac' ) == 1 ) ) %] >+ [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) ) %] > <span id="placehold"> > <a href="#" class="btn btn-link hold tag_hides disabled"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a> > </span> >@@ -765,7 +765,7 @@ var MSG_REMOVE_ONE_FROM_LIST = _("Are you sure you want to remove this item from > var MSG_CONFIRM_DELETE_LIST = _("Are you sure you want to delete this list?"); > var MSG_CONFIRM_REMOVE_SHARE = _("Are you sure you want to remove this share?"); > >-[% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'RequestOnOpac' ) == 1 ) ) %] >+[% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) ) %] > function holdSelections() { > var checkedBoxes = $("input:checkbox:checked"); > if ($(checkedBoxes).size() == 0) { >@@ -838,7 +838,7 @@ function enableCheckboxActions(){ > $(function() { > [% IF Koha.Preference( 'opacbookbag' ) == 1 %]$(".addtocart,.cartRemove").removeClass("hidden");[% END %] > >- [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'RequestOnOpac' ) == 1 ) ) %] >+ [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'OPACHoldRequests' ) == 1 ) ) %] > $(".selections-toolbar a.hold").click(function(e){ > e.preventDefault(); > holdSelections(); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >index 443b06f416..62301c9586 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >@@ -121,7 +121,7 @@ > </td> > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] > <td> >- [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >+ [% IF Koha.Preference( 'OPACHoldRequests' ) == 1 %] > [% UNLESS ( result.norequests ) %] > <a class="btn btn-link btn-sm hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% result.biblionumber | uri %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a> > [% END %] >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index dada1a2744..9335ea4ccd 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -188,7 +188,6 @@ if( $allow_onshelf_holds || CountItemsIssued($biblionumber) || $biblio->has_item > my $norequests = ! $items->filter_by_for_hold->count; > > $template->param( >- RequestOnOpac => C4::Context->preference("RequestOnOpac"), > norequests => $norequests, > ISBD => $res, > biblio => $biblio, >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index 4d9b5efbf3..0133784d39 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -155,12 +155,6 @@ if( $allow_onshelf_holds || CountItemsIssued($biblionumber) || $biblio->has_item > $template->param( ReservableItems => 1 ); > } > >-# adding the $RequestOnOpac param >-my $RequestOnOpac; >-if (C4::Context->preference("RequestOnOpac")) { >- $RequestOnOpac = 1; >-} >- > # fill arrays > my @loop_data = (); > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 69b791e1d5..3b47a19628 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -800,7 +800,6 @@ my $norequests = ! $biblio->items->filter_by_for_hold->count; > $template->param( > MARCNOTES => $marcnotesarray, > norequests => $norequests, >- RequestOnOpac => C4::Context->preference("RequestOnOpac"), > itemdata_ccode => $itemfields{ccode}, > itemdata_materials => $itemfields{materials}, > itemdata_enumchron => $itemfields{enumchron}, >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 721981bb2a..a7391e2327 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -47,8 +47,8 @@ my $maxreserves = C4::Context->preference("maxreserves"); > > my $query = CGI->new; > >-# if RequestOnOpac (for placing holds) is disabled, leave immediately >-if ( ! C4::Context->preference('RequestOnOpac') ) { >+# if OPACHoldRequests (for placing holds) is disabled, leave immediately >+if ( ! C4::Context->preference('OPACHoldRequests') ) { > print $query->redirect("/cgi-bin/koha/errors/404.pl"); > exit; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29180
:
127318
|
127324
|
127351
|
127352
|
127353