It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology Possibly, 'AllowHoldsOnOpac'?
(In reply to Nick Clemens from comment #0) > Possibly, 'AllowHoldsOnOpac'? +1
Hm, I suggest AllowOpacHolds - but yes, took me ages to remember that one...
OPACHoldRequests? (don't we usually prefix OPAC sysprefs by 'OPAC'?)
(In reply to Jonathan Druart from comment #3) > OPACHoldRequests? (don't we usually prefix OPAC sysprefs by 'OPAC'?) +1
Created attachment 127318 [details] [review] Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth
Created attachment 127324 [details] [review] Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 127351 [details] [review] Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 127352 [details] [review] Bug 29180: (QA follow-up) Alphabetize sysprefs.sql Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 127353 [details] [review] Bug 29180: (QA follow-up) Don't alter old DB up date Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Thanks Nick, good catches!
Pushed to master for 21.11, thanks to everybody involved!
Changes for this bug are now incorporated in the manual. Here are the changes made: renamed system preference RequestOnOpac to OPACHoldRequests in OPAC preferences, OPAC and Implementation checklist (see https://gitlab.com/koha-community/koha-manual/-/commit/f669393bf840c9e0b0a4cf54e38bff4fb289c8d5)