Bugzilla – Attachment 127388 Details for
Bug 27741
Accessibility: Staff Client - Headings should have correct tags and hierarchy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27741: ill folder
Bug-27741-ill-folder.patch (text/plain), 8.71 KB, created by
Owen Leonard
on 2021-11-05 14:58:56 UTC
(
hide
)
Description:
Bug 27741: ill folder
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-11-05 14:58:56 UTC
Size:
8.71 KB
patch
obsolete
>From e8f06a4cafab1e2799d0c657418ce5a524463494 Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Tue, 8 Jun 2021 05:45:41 +0000 >Subject: [PATCH] Bug 27741: ill folder > >Bug 27631 corrected the <h1> tags in each of the pages in the staff >client. This bug deals with correcting the hierarchy of each of the >other headings. > >To test: >1) Apply patch and dependencies >2) Go to each of the pages and check the headings under <h1> are in > the correct order and hierarchy > >Sponsored-by: Catalyst IT > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/ill/ill-requests.tt | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 39dbd67819..e785aee790 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -59,7 +59,7 @@ > <aside> > <form method="get" id="illfilter_form"> > <fieldset class="brief"> >- <h3>Filters</h3> >+ <h2>Filters</h2> > <ol> > <li> > <label for="illfilter_keyword">Keyword:</label> >@@ -360,11 +360,11 @@ > <div class="modal-content"> > <div class="modal-header"> > <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >- <h3 id="partnerSearchLabel"> Search partners</h3> >+ <h2 id="partnerSearchLabel"> Search partners</h2> > </div> > <div class="modal-body"> > [% FOR service IN services %] >- <h4 class="ill_availability_sourcename">[% service.name | html %]</h4> >+ <h3 class="ill_availability_sourcename">[% service.name | html %]</h3> > [% INCLUDE 'ill-availability-table.inc' service=service %] > [% END %] > <span id="service_id_restrict" data-service_id_restrict_plugin="ILL availability - z39.50" data-service_id_restrict_ids=""></span> >@@ -473,7 +473,7 @@ > [% ELSIF query_type == 'delete_confirm' %] > > <div class="dialog alert"> >- <h3>Are you sure you wish to delete this request?</h3> >+ <h1>Are you sure you wish to delete this request?</h1> > <form action="/cgi-bin/koha/ill/ill-requests.pl" method="post"> > <input type="hidden" name="method" value="delete" /> > <input type="hidden" name="confirmed" value="1" /> >@@ -601,10 +601,10 @@ > </div> > <div class="ill-view-panel panel panel-default"> > <div class="panel-heading"> >- <h3>Request details</h3> >+ <h2>Request details</h2> > </div> > <div class="panel-body"> >- <h4>Details from library</h4> >+ <h3>Details from library</h3> > <div class="rows"> > <ol> > <li class="orderid"> >@@ -674,7 +674,7 @@ > </ol> > </div> > <div class="rows"> >- <h4>Details from supplier ([% request.backend | html %])</h4> >+ <h2>Details from supplier ([% request.backend | html %])</h2> > <ol> > [% FOREACH meta IN request.metadata %] > <li class="requestmeta-[% meta.key.replace('\s','_') | html %]"> >@@ -692,7 +692,7 @@ > <div class="modal-content"> > <div class="modal-header"> > <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >- <h3 id="dataPreviewLabel"> Supplier metadata</h3> >+ <h2 id="dataPreviewLabel"> Supplier metadata</h2> > </div> > <div class="modal-body"> > <div id="requestattributes"> >@@ -716,7 +716,7 @@ > <div class="modal-content"> > <div class="modal-header"> > <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >- <h3 id="requestLogLabel"> Request log</h3> >+ <h2 id="requestLogLabel"> Request log</h2> > </div> > <div class="modal-body"> > [% IF request.logs.size > 0 %] >@@ -737,22 +737,22 @@ > > <div class="ill-view-panel panel panel-default"> > <div class="panel-heading"> >- <h3>[% request.illcomments.count | html %] comments</h3> >+ <h2>[% request.illcomments.count | html %] comments</h2> > </div> > <div class="panel-body"> > [% IF request.illcomments.count && request.illcomments.count > 0 %] > [% FOREACH comment IN request.illcomments %] > <div class="rows comment_[% comment.patron.categorycode | html %]"> >- <h5>Comment by: >+ <h3>Comment by: > <a href="[% borrowerlink | url %]" title="View borrower details"> > [% comment.patron.firstname _ " " _ comment.patron.surname _ " [" _ comment.patron.cardnumber _ "]" | html %]</a> >- [% comment.timestamp | $KohaDates with_hours => 1 %]</h5> >+ [% comment.timestamp | $KohaDates with_hours => 1 %]</h3> > <p>[% comment.comment | html %]</p> > </div> > [% END %] > [% END %] > <div class="rows"> >- <h3><a id="toggle_addcomment" href="#">Add comment</a></h3> >+ <h2><a id="toggle_addcomment" href="#">Add comment</a></h2> > <div id="addcomment" class="content_hidden"> > <form class="validated" method="post" action="/cgi-bin/koha/ill/ill-requests.pl"> > <input type="hidden" value="save_comment" name="method"> >@@ -780,7 +780,7 @@ > <!-- illlist --> > <h1>View ILL requests</h1> > <div id="results"> >- <h3>Details for all requests</h3> >+ <h2>Details for all requests</h2> > [% INCLUDE 'ill-list-table.inc' %] > > </div> <!-- /#results --> >@@ -788,7 +788,7 @@ > <!-- availability --> > <h1>Availability</h1> > <div id="results"> >- <h3>Displaying availability results</h3> >+ <h2>Displaying availability results</h2> > <form method="POST" action="/cgi-bin/koha/ill/ill-requests.pl"> > [% FOREACH key IN whole.keys %] > [% value = whole.$key %] >@@ -814,7 +814,7 @@ > </div> > </form> > [% FOR service IN services %] >- <h4 class="ill_availability_sourcename">[% service.name | html %]</h4> >+ <h2 class="ill_availability_sourcename">[% service.name | html %]</h2> > [% INCLUDE 'ill-availability-table.inc' service=service %] > [% END %] > </div> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27741
:
120192
|
120193
|
120194
|
120195
|
120197
|
120198
|
121344
|
121346
|
121347
|
121348
|
121349
|
121350
|
121351
|
121357
|
121358
|
121365
|
121400
|
121402
|
121403
|
121404
|
121509
|
121510
|
121521
|
121534
|
121560
|
121622
|
121642
|
121643
|
121644
|
121645
|
121646
|
121699
|
121700
|
121701
|
122018
|
127369
|
127370
|
127371
|
127372
|
127373
|
127374
|
127375
|
127376
|
127377
|
127378
|
127379
|
127380
|
127381
|
127382
|
127383
|
127384
|
127385
|
127386
|
127387
| 127388 |
127389
|
127390
|
127391
|
127392
|
127393
|
127394
|
127395