Bug 27741 - Accessibility: Staff Client - Headings should have correct tags and hierarchy
Summary: Accessibility: Staff Client - Headings should have correct tags and hierarchy
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: wainuiwitikapark
QA Contact: Testopia
URL:
Keywords: accessibility
Depends on: 27631
Blocks: 27877 28243 28532
  Show dependency treegraph
 
Reported: 2021-02-21 21:07 UTC by wainuiwitikapark
Modified: 2021-12-01 15:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Large patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27741: admin folder (37.16 KB, patch)
2021-04-27 07:07 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: admin folder (41.06 KB, patch)
2021-04-27 07:15 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: admin folder (42.49 KB, patch)
2021-04-27 07:22 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: admin folder (45.80 KB, patch)
2021-04-27 07:46 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: authorities folder (1.61 KB, patch)
2021-04-27 08:01 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: basket folder (2.41 KB, patch)
2021-04-27 08:06 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: admin folder (46.71 KB, patch)
2021-05-25 01:22 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: authorities folder (1.61 KB, patch)
2021-05-25 01:43 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: basket folder (2.41 KB, patch)
2021-05-25 01:46 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: catalogue folder (10.75 KB, patch)
2021-05-25 02:58 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: cataloguing folder (13.73 KB, patch)
2021-05-25 03:57 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: clubs folder (3.29 KB, patch)
2021-05-25 07:07 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: common folder (1.43 KB, patch)
2021-05-25 07:13 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: course_reserves folder (2.69 KB, patch)
2021-05-25 08:12 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: virtualshelves folder (2.23 KB, patch)
2021-05-25 08:32 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: patron_lists folder (1.53 KB, patch)
2021-05-25 08:50 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: pos folder (6.01 KB, patch)
2021-05-25 23:46 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: suggestion folder (3.48 KB, patch)
2021-05-26 02:25 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: tags folder (3.38 KB, patch)
2021-05-26 02:35 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: patroncards folder (5.00 KB, patch)
2021-05-26 02:58 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: labels folder (5.58 KB, patch)
2021-05-30 04:05 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: members folder (29.11 KB, patch)
2021-05-30 05:35 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: serials folder (6.70 KB, patch)
2021-06-01 01:23 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: reports folder (15.72 KB, patch)
2021-06-02 03:36 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: circ folder (34.29 KB, patch)
2021-06-03 03:08 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: tools folder (37.16 KB, patch)
2021-06-04 01:48 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: acqui folder (21.18 KB, patch)
2021-06-06 04:52 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: onboarding folder (3.28 KB, patch)
2021-06-06 05:08 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: reserve folder (3.72 KB, patch)
2021-06-06 05:32 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: about.tt (22.57 KB, patch)
2021-06-06 10:50 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: main page (2.60 KB, patch)
2021-06-06 10:57 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: tools folder (36.13 KB, patch)
2021-06-08 04:23 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: installer folder (7.25 KB, patch)
2021-06-08 05:27 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: ill folder (8.67 KB, patch)
2021-06-08 05:47 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: circ folder (34.22 KB, patch)
2021-06-16 01:58 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 27741: admin folder (46.79 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: authorities folder (1.66 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: basket folder (2.46 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: catalogue folder (10.73 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: cataloguing folder (13.72 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: clubs folder (3.32 KB, patch)
2021-11-05 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: common folder (1.48 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: virtualshelves folder (2.27 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: patron_lists folder (1.59 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: pos folder (6.06 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: suggestion folder (3.53 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: tags folder (3.44 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: patroncards folder (5.03 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: labels folder (5.60 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: serials folder (6.93 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: onboarding folder (3.25 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: about.tt (22.69 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: main page (2.62 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: installer folder (6.95 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: ill folder (8.71 KB, patch)
2021-11-05 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: tools folder (36.26 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: circ folder (33.21 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: reserve folder (3.76 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: reports folder (15.69 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: acqui folder (21.36 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: members folder (29.12 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27741: course_reserves folder (3.13 KB, patch)
2021-11-05 14:59 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description wainuiwitikapark 2021-02-21 21:07:15 UTC
Each page of the Staff Client should contain correct headings with correct heading tags and hierarchy. Please see https://www.w3.org/WAI/tutorials/page-structure/headings/ for more information.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 dealt with changing the logo on each page to be a <div> instead of an <h1> and then ensuring each page has one <h1> that tells users what the page is about.

This bug will deal with ensuring the rest of the headings in each page follow the correct heading hierarchy, and headings don't skip a level.
Comment 1 wainuiwitikapark 2021-04-27 07:07:13 UTC Comment hidden (obsolete)
Comment 2 wainuiwitikapark 2021-04-27 07:15:33 UTC Comment hidden (obsolete)
Comment 3 wainuiwitikapark 2021-04-27 07:17:15 UTC
I changed the admin menu headings to <h2>. These can be amended in the scss files if required.
Comment 4 wainuiwitikapark 2021-04-27 07:22:38 UTC Comment hidden (obsolete)
Comment 5 wainuiwitikapark 2021-04-27 07:46:16 UTC Comment hidden (obsolete)
Comment 6 wainuiwitikapark 2021-04-27 07:48:02 UTC
I changed the includes/admin-menu.inc headings and includes/acquisitions-menu.inc headings to <h2>. These are large but can be amended in the scss files if required.
Comment 7 wainuiwitikapark 2021-04-27 08:01:41 UTC Comment hidden (obsolete)
Comment 8 wainuiwitikapark 2021-04-27 08:06:03 UTC Comment hidden (obsolete)
Comment 9 wainuiwitikapark 2021-05-25 01:22:29 UTC
Created attachment 121344 [details] [review]
Bug 27741: admin folder

Bug 27631 corrected the <h1> tags in each of the pages in the staf client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 10 wainuiwitikapark 2021-05-25 01:43:13 UTC
Created attachment 121346 [details] [review]
Bug 27741: authorities folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 11 wainuiwitikapark 2021-05-25 01:46:57 UTC
Created attachment 121347 [details] [review]
Bug 27741: basket folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 12 wainuiwitikapark 2021-05-25 02:58:34 UTC
Created attachment 121348 [details] [review]
Bug 27741: catalogue folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 13 wainuiwitikapark 2021-05-25 03:57:49 UTC
Created attachment 121349 [details] [review]
Bug 27741: cataloguing folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 14 wainuiwitikapark 2021-05-25 07:07:34 UTC
Created attachment 121350 [details] [review]
Bug 27741: clubs folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 15 wainuiwitikapark 2021-05-25 07:13:38 UTC
Created attachment 121351 [details] [review]
Bug 27741: common folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 16 wainuiwitikapark 2021-05-25 08:12:10 UTC
Created attachment 121357 [details] [review]
Bug 27741: course_reserves folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 17 wainuiwitikapark 2021-05-25 08:32:08 UTC
Created attachment 121358 [details] [review]
Bug 27741: virtualshelves folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 18 wainuiwitikapark 2021-05-25 08:50:03 UTC
Created attachment 121365 [details] [review]
Bug 27741: patron_lists folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 19 wainuiwitikapark 2021-05-25 23:46:20 UTC
Created attachment 121400 [details] [review]
Bug 27741: pos folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 20 wainuiwitikapark 2021-05-26 02:25:38 UTC
Created attachment 121402 [details] [review]
Bug 27741: suggestion folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 21 wainuiwitikapark 2021-05-26 02:35:05 UTC
Created attachment 121403 [details] [review]
Bug 27741: tags folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 22 wainuiwitikapark 2021-05-26 02:58:34 UTC
Created attachment 121404 [details] [review]
Bug 27741: patroncards folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 23 wainuiwitikapark 2021-05-26 03:04:52 UTC
So yeah, with all the menus and things on the sides, I have made them <h2>. These can be amended in the css to make them appear smaller as they were before.
Comment 24 wainuiwitikapark 2021-05-30 04:05:59 UTC
Created attachment 121509 [details] [review]
Bug 27741: labels folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 25 wainuiwitikapark 2021-05-30 05:35:41 UTC
Created attachment 121510 [details] [review]
Bug 27741: members folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 26 wainuiwitikapark 2021-06-01 01:23:19 UTC
Created attachment 121521 [details] [review]
Bug 27741: serials folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 27 wainuiwitikapark 2021-06-02 03:36:49 UTC
Created attachment 121534 [details] [review]
Bug 27741: reports folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 28 wainuiwitikapark 2021-06-03 03:08:45 UTC Comment hidden (obsolete)
Comment 29 wainuiwitikapark 2021-06-04 01:48:40 UTC Comment hidden (obsolete)
Comment 30 wainuiwitikapark 2021-06-06 04:52:29 UTC
Created attachment 121642 [details] [review]
Bug 27741: acqui folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 31 wainuiwitikapark 2021-06-06 05:08:37 UTC
Created attachment 121643 [details] [review]
Bug 27741: onboarding folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 32 wainuiwitikapark 2021-06-06 05:32:51 UTC
Created attachment 121644 [details] [review]
Bug 27741: reserve folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 33 wainuiwitikapark 2021-06-06 10:50:49 UTC
Created attachment 121645 [details] [review]
Bug 27741: about.tt

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 34 wainuiwitikapark 2021-06-06 10:57:41 UTC
Created attachment 121646 [details] [review]
Bug 27741: main page

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to the main page of the staff client and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 35 wainuiwitikapark 2021-06-08 04:23:45 UTC
Created attachment 121699 [details] [review]
Bug 27741: tools folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 36 wainuiwitikapark 2021-06-08 05:27:18 UTC
Created attachment 121700 [details] [review]
Bug 27741: installer folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 37 wainuiwitikapark 2021-06-08 05:47:30 UTC
Created attachment 121701 [details] [review]
Bug 27741: ill folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 38 wainuiwitikapark 2021-06-16 01:58:53 UTC
Created attachment 122018 [details] [review]
Bug 27741: circ folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT
Comment 39 Owen Leonard 2021-09-30 16:51:41 UTC
I'm not sure if it was my rebase of Bug 27631 or something else, but this doesn't apply: 

Applying: Bug 27741: admin folder
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 27741: admin folder
Comment 40 Owen Leonard 2021-11-05 14:57:39 UTC
Created attachment 127369 [details] [review]
Bug 27741: admin folder

Bug 27631 corrected the <h1> tags in each of the pages in the staf
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 41 Owen Leonard 2021-11-05 14:57:43 UTC
Created attachment 127370 [details] [review]
Bug 27741: authorities folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This
bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 42 Owen Leonard 2021-11-05 14:57:47 UTC
Created attachment 127371 [details] [review]
Bug 27741: basket folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 43 Owen Leonard 2021-11-05 14:57:50 UTC
Created attachment 127372 [details] [review]
Bug 27741: catalogue folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 44 Owen Leonard 2021-11-05 14:57:54 UTC
Created attachment 127373 [details] [review]
Bug 27741: cataloguing folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 45 Owen Leonard 2021-11-05 14:57:58 UTC
Created attachment 127374 [details] [review]
Bug 27741: clubs folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 46 Owen Leonard 2021-11-05 14:58:02 UTC
Created attachment 127375 [details] [review]
Bug 27741: common folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 47 Owen Leonard 2021-11-05 14:58:06 UTC
Created attachment 127376 [details] [review]
Bug 27741: virtualshelves folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 48 Owen Leonard 2021-11-05 14:58:10 UTC
Created attachment 127377 [details] [review]
Bug 27741: patron_lists folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 49 Owen Leonard 2021-11-05 14:58:14 UTC
Created attachment 127378 [details] [review]
Bug 27741: pos folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 50 Owen Leonard 2021-11-05 14:58:18 UTC
Created attachment 127379 [details] [review]
Bug 27741: suggestion folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 51 Owen Leonard 2021-11-05 14:58:23 UTC
Created attachment 127380 [details] [review]
Bug 27741: tags folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 52 Owen Leonard 2021-11-05 14:58:27 UTC
Created attachment 127381 [details] [review]
Bug 27741: patroncards folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 53 Owen Leonard 2021-11-05 14:58:31 UTC
Created attachment 127382 [details] [review]
Bug 27741: labels folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 54 Owen Leonard 2021-11-05 14:58:35 UTC
Created attachment 127383 [details] [review]
Bug 27741: serials folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 55 Owen Leonard 2021-11-05 14:58:39 UTC
Created attachment 127384 [details] [review]
Bug 27741: onboarding folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 56 Owen Leonard 2021-11-05 14:58:44 UTC
Created attachment 127385 [details] [review]
Bug 27741: about.tt

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This
bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 57 Owen Leonard 2021-11-05 14:58:48 UTC
Created attachment 127386 [details] [review]
Bug 27741: main page

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This
bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to the main page of the staff client and check the headings under <h1> are
   in the correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 58 Owen Leonard 2021-11-05 14:58:52 UTC
Created attachment 127387 [details] [review]
Bug 27741: installer folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff client. This
bug deals with correcting the hierarchy of each of the other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the correct
   order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 59 Owen Leonard 2021-11-05 14:58:56 UTC
Created attachment 127388 [details] [review]
Bug 27741: ill folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in
   the correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 60 Owen Leonard 2021-11-05 14:59:00 UTC
Created attachment 127389 [details] [review]
Bug 27741: tools folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 61 Owen Leonard 2021-11-05 14:59:04 UTC
Created attachment 127390 [details] [review]
Bug 27741: circ folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 62 Owen Leonard 2021-11-05 14:59:07 UTC
Created attachment 127391 [details] [review]
Bug 27741: reserve folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 63 Owen Leonard 2021-11-05 14:59:12 UTC
Created attachment 127392 [details] [review]
Bug 27741: reports folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 64 Owen Leonard 2021-11-05 14:59:19 UTC
Created attachment 127393 [details] [review]
Bug 27741: acqui folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 65 Owen Leonard 2021-11-05 14:59:23 UTC
Created attachment 127394 [details] [review]
Bug 27741: members folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 66 Owen Leonard 2021-11-05 14:59:29 UTC
Created attachment 127395 [details] [review]
Bug 27741: course_reserves folder

Bug 27631 corrected the <h1> tags in each of the pages in the staff
client. This bug deals with correcting the hierarchy of each of the
other headings.

To test:
1) Apply patch and dependencies
2) Go to each of the pages and check the headings under <h1> are in the
   correct order and hierarchy

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 67 Jonathan Druart 2021-12-01 15:40:25 UTC
Comment on attachment 127372 [details] [review]
Bug 27741: catalogue folder

Review of attachment 127372 [details] [review]:
-----------------------------------------------------------------

<h2>[% title | html %]</h2>
-    [% IF ( subtitle ) %]<h4>[% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %]</h4>[% END %]
-    [% IF ( author ) %]<h4>by [% author | html %]</h4>[% END %]
+    <h2>
+    [% IF ( subtitle ) %][% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %][% END %]
+    [% IF ( author ) %]by [% author | html %][% END %]
+    </h2>

Is this correct? Shouldn't be h3?
Comment 68 Jonathan Druart 2021-12-01 15:42:22 UTC
Impressive work Wainui!
How did you process? Has all been done manually or you managed to catch them using a specific tool?
We will certainly need something automated once pushed to catch regressions.