Bugzilla – Attachment 127392 Details for
Bug 27741
Accessibility: Staff Client - Headings should have correct tags and hierarchy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27741: reports folder
Bug-27741-reports-folder.patch (text/plain), 15.69 KB, created by
Owen Leonard
on 2021-11-05 14:59:12 UTC
(
hide
)
Description:
Bug 27741: reports folder
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-11-05 14:59:12 UTC
Size:
15.69 KB
patch
obsolete
>From 7a11e4373d45b43ad03671f7ccd17e3b739169aa Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 4 Nov 2021 18:17:04 +0000 >Subject: [PATCH] Bug 27741: reports folder > >Bug 27631 corrected the <h1> tags in each of the pages in the staff >client. This bug deals with correcting the hierarchy of each of the >other headings. > >To test: >1) Apply patch and dependencies >2) Go to each of the pages and check the headings under <h1> are in the > correct order and hierarchy > >Sponsored-by: Catalyst IT > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/includes/guided-reports-view.inc | 6 ++--- > .../prog/en/includes/reports-menu.inc | 12 ++++----- > .../prog/en/modules/reports/catalogue_out.tt | 6 ++--- > .../prog/en/modules/reports/convert_report.tt | 4 +-- > .../prog/en/modules/reports/dictionary.tt | 10 +++---- > .../modules/reports/guided_reports_start.tt | 26 +++++++++---------- > .../prog/en/modules/reports/reports-home.tt | 2 +- > 7 files changed, 33 insertions(+), 33 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc >index 94b73fd44e..b4dcaa1e47 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/guided-reports-view.inc >@@ -2,15 +2,15 @@ > <div id="navmenu"> > <div id="navmenulist"> > >-<h5>Run reports</h5> >+<h2>Run reports</h2> > <ul> > [% IF ( CAN_user_reports_execute_reports ) %]<li><a href="/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved">Saved reports</a></li>[% END %] > </ul> >-<h5>Reports dictionary</h5> >+<h2>Reports dictionary</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/dictionary.pl?phase=View%20Dictionary">View dictionary</a></li> > </ul> >-<h5>Useful resources</h5> >+<h2>Useful resources</h2> > <ul> > <li><a href="http://wiki.koha-community.org/wiki/SQL_Reports_Library" target="blank">Koha report library</a></li> > [% SET koha_version = Koha.Version %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc >index d63b3e923d..ed7e047d80 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc >@@ -3,7 +3,7 @@ > <div id="navmenu"> > <div id="navmenulist"> > >- <h5>Guided reports</h5> >+ <h2>Guided reports</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/guided_reports.pl">Guided reports</a></li> > [% IF ( CAN_user_reports_create_reports ) %] >@@ -17,7 +17,7 @@ > [% END %] > </ul> > >- <h5>Statistics wizards</h5> >+ <h2>Statistics wizards</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/acquisitions_stats.pl">Acquisitions</a></li> > <li><a href="/cgi-bin/koha/reports/borrowers_stats.pl">Patrons</a></li> >@@ -29,26 +29,26 @@ > </ul> > > [% IF Koha.ArePluginsEnabled() %] >- <h5>Report plugins</h5> >+ <h2>Report plugins</h2> > <ul> > <li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=report">Report plugins</a></li> > </ul> > [% END %] > >- <h5>Top lists</h5> >+ <h2>Top lists</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/bor_issues_top.pl">Patrons with the most checkouts</a></li> > <li><a href="/cgi-bin/koha/reports/cat_issues_top.pl">Most-circulated items</a></li> > </ul> > >- <h5>Inactive</h5> >+ <h2>Inactive</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/borrowers_out.pl">Patrons who haven't checked out</a></li> > <li><a href="/cgi-bin/koha/reports/catalogue_out.pl">Items with no checkouts</a></li> > </ul> > > >- <h5>Other</h5> >+ <h2>Other</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/itemslost.pl">Lost items</a></li> > <li><a href="/cgi-bin/koha/reports/orders_by_fund.pl">Orders by fund</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index 522f5cbcca..8d5eaf328d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -48,7 +48,7 @@ > [% END %] > > [% IF ( mainloo.looptables ) %] >- <h3><a name="summary" id="summary"></a>Summary</h3> >+ <h2><a name="summary" id="summary"></a>Summary</h2> > <table id="summary_table"> > <tr><th>Group</th><th>Call number range</th><th>Number of items displayed</th><th>Total items in group</th> > </tr> >@@ -68,9 +68,9 @@ > > [% END %] > [% FOREACH looptable IN mainloo.looptables %] >- <h3><a id="table[% looptable.coltitle | html %]"></a> >+ <h2><a id="table[% looptable.coltitle | html %]"></a> > [% looptable.coltitle | html %] >- </h3> >+ </h2> > <table> > <tr> > <th>#</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >index 8650afff24..27e52dfe65 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >@@ -9,12 +9,12 @@ > There is no valid report for this id. > [% ELSIF msg == 'can_be_updated' %] > <div id="col1"> >- <h3>Existing SQL</h3> >+ <h2>Existing SQL</h2> > <span class="show_sql">[% current_sql | html_entity %]</span> > </div> > > <div id="col2"> >- <h3>Updated SQL</h3> >+ <h2>Updated SQL</h2> > <span class="show_sql">[% updated_sql | html_entity %]</span> > </div> > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >index 47b08c8a25..7c53295426 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >@@ -154,7 +154,7 @@ > [% END %] > > [% IF ( new_dictionary ) %] >-<h3>Add new definition</h3> >+<h2>Add new definition</h2> > <form action="/cgi-bin/koha/reports/dictionary.pl" method="post"> > <fieldset class="rows"><legend>Step 1 of 5: Name the new definition</legend><ol> > <li> >@@ -173,7 +173,7 @@ > [% END %] > > [%- IF ( step_2 ) -%] >-<h3>Add new definition</h3> >+<h2>Add new definition</h2> > <form action="/cgi-bin/koha/reports/dictionary.pl" method="post"> > <fieldset class="rows"> > <legend>Step 2 of 5: Choose the area</legend> >@@ -195,7 +195,7 @@ > [%- END -%] > > [% IF ( step_3 ) %] >-<h3>Add new definition</h3> >+<h2>Add new definition</h2> > <form action="/cgi-bin/koha/reports/dictionary.pl" method="post"> > <fieldset class="rows"> > <legend>Step 3 of 5: Choose a column</legend> >@@ -231,7 +231,7 @@ > [% END %] > > [% IF ( step_4 ) %] >-<h3>Add new definition</h3> >+<h2>Add new definition</h2> > <form action="/cgi-bin/koha/reports/dictionary.pl" method="post"> > <fieldset class="rows"> > <legend>Step 4 of 5: Specify a value</legend> >@@ -287,7 +287,7 @@ > <input type="hidden" name="definition_description" value="[% definition_description | html %]" /> > <input type="hidden" name="columnstring" value="[% columnstring | html %]" /> > >-<h3>Add new definition</h3> >+<h2>Add new definition</h2> > > <fieldset class="rows"> > <legend>Step 5 of 5: Confirm details</legend> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 92756999c5..73e81bdae4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -146,7 +146,7 @@ > <div class="modal-content"> > <div class="modal-header"> > <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >- <h3 id="update_sql_label">Update SQL</h3> >+ <h2 id="update_sql_label">Update SQL</h2> > </div> > <div class="modal-body"> > <div id="loading"> <img src="[% interface | html %]/[% theme | html %]/img/spinner-small.gif" alt="" /> Loading </div> >@@ -170,7 +170,7 @@ > <h1>Guided reports</h1> > <p>Use the guided reports engine to create non standard reports. This feature aims to provide some middle ground between the built in canned reports and writing custom SQL reports.</p> > >- <h3>Build and run reports</h3> >+ <h2>Build and run reports</h2> > > [% IF ( CAN_user_reports_create_reports ) %] > <form action="/cgi-bin/koha/reports/guided_reports.pl"> >@@ -193,7 +193,7 @@ > </form> > [% END %] > >- <h3>Reports Dictionary</h3> >+ <h2>Reports Dictionary</h2> > <p>Use the reports dictionary to define custom criteria to use in your reports</p> > <form action="/cgi-bin/koha/reports/dictionary.pl"> > <input type="hidden" name="phase" value="View Dictionary"/> >@@ -411,7 +411,7 @@ > [% ELSE # IF ( savedreports ) %] > <div class="dialog message"> > [% IF (filter_set || filters.date || filters.author || filters.keyword) %] >- <h4>No saved reports match your criteria. </h4> >+ <h2>No saved reports match your criteria. </h2> > [% IF ( CAN_user_reports_create_reports ) %] > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get"> > <input type="hidden" name="phase" value="Build new" /> >@@ -431,7 +431,7 @@ > </form> > [% END %] > [% ELSE %] >- <h4>There are no saved reports. </h4> >+ <h2>There are no saved reports. </h2> > [% IF ( CAN_user_reports_create_reports ) %] > <a href="/cgi-bin/koha/reports/guided_reports.pl?phase=Build%20new">Build a new report?</a> > [% END %] >@@ -531,7 +531,7 @@ > > [% IF ( build3 ) %] > <h1>Build a report</h1> >- <h3>Step 3 of 6: Select columns for display</h3> >+ <h2>Step 3 of 6: Select columns for display</h2> > <p>Note: Be careful selecting when selecting columns. If your choice is too broad it could result in a very large report that will either not complete, or slow your system down.</p> > > <form id="column_submit" action="/cgi-bin/koha/reports/guided_reports.pl" method="post"> >@@ -673,7 +673,7 @@ > > [% IF ( build5 ) %] > <h1>Build a report</h1> >- <h3>Step 5 of 6: Pick which columns to total</h3> >+ <h2>Step 5 of 6: Pick which columns to total</h2> > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="post"> > <input type="hidden" name="area" value="[% area | html %]" /> > <input type="hidden" name="type" value="[% type | html %]" /> >@@ -711,7 +711,7 @@ > > [% IF ( build6 ) %] > <h1>Build a report</h1> >- <h3>Step 6 of 6: Choose how you want the report ordered</h3> >+ <h2>Step 6 of 6: Choose how you want the report ordered</h2> > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="post"> > <input type="hidden" name="area" value="[% area | html %]" /> > <input type="hidden" name="type" value="[% type | html %]" /> >@@ -796,7 +796,7 @@ > > [% IF ( warn_authval_problem ) %] > <div class="dialog alert"> >- <h3>Errors found when processing parameters for report: [% name | html %]</h3> >+ <h1>Errors found when processing parameters for report: [% name | html %]</h1> > [% FOREACH problematic_authval IN problematic_authvals %] > <p> > <strong>[% problematic_authval.name | html %]:</strong> The authorized value category (<strong>[% problematic_authval.authval | html %]</strong>) >@@ -837,7 +837,7 @@ > [% IF ( auth_val_error ) %] > <input type='hidden' name='phase' value='Edit SQL' /> > <div class="dialog alert"> >- <h3>Errors found when processing parameters for report: [% name | html %]</h3> >+ <h1>Errors found when processing parameters for report: [% name | html %]</h1> > [% FOREACH auth_val_error IN auth_val_errors %] > <p> > <strong>[% auth_val_error.entry | html %]:</strong> The authorized value category (<strong>[% auth_val_error.auth_val | html %]</strong>) >@@ -1340,7 +1340,7 @@ > <input type="hidden" name="phase" value="Use saved" /> > <input type="hidden" name="filter_set" value="1" /> > <fieldset class="brief"> >- <h3>Filter</h3> >+ <h2>Filter</h2> > <ol> > <li> > <label for="filter_date">Date:</label> >@@ -1375,7 +1375,7 @@ > <div class="modal-content"> > <div class="modal-header"> > <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> >- <h4 class="modal-title" id="runtime_parametersLabel">Runtime parameter options</h4> >+ <h2 class="modal-title" id="runtime_parametersLabel">Runtime parameter options</h2> > </div> > <form id="send_runtime_parameter"> > <input type="hidden" name="param_category" id="param_category" /> >@@ -2209,7 +2209,7 @@ > <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close">\ > <span aria-hidden="true">Ã</span>\ > </button>\ >- <h4 class="modal-title">' + title + '</h4>\ >+ <h2 class="modal-title">' + title + '</h2>\ > </div>\ > <div class="modal-body"><textarea id="code' + reportid + '">' + message + '</textarea>\ > <div class="modal-footer">\ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >index 5c2de9cbf3..047ccccebf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >@@ -50,7 +50,7 @@ > </form> > [% END %] > >- <h5>Reports dictionary</h5> >+ <h2>Reports dictionary</h2> > <ul> > <li><a href="/cgi-bin/koha/reports/dictionary.pl?phase=View%20Dictionary">View dictionary</a></li> > </ul> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27741
:
120192
|
120193
|
120194
|
120195
|
120197
|
120198
|
121344
|
121346
|
121347
|
121348
|
121349
|
121350
|
121351
|
121357
|
121358
|
121365
|
121400
|
121402
|
121403
|
121404
|
121509
|
121510
|
121521
|
121534
|
121560
|
121622
|
121642
|
121643
|
121644
|
121645
|
121646
|
121699
|
121700
|
121701
|
122018
|
127369
|
127370
|
127371
|
127372
|
127373
|
127374
|
127375
|
127376
|
127377
|
127378
|
127379
|
127380
|
127381
|
127382
|
127383
|
127384
|
127385
|
127386
|
127387
|
127388
|
127389
|
127390
|
127391
| 127392 |
127393
|
127394
|
127395