Attachment 127971 Details for Bug 29485 – Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail randomly

[patch] Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail randomly

Bug-29485-follow-up-Trying-to-prevent-administrati.patch (text/plain), 2.02 KB, created by Jonathan Druart on 2021-11-24 08:14:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-11-24 08:14:59 UTC

Size: 2.02 KB

patch

obsolete

>From ace66b7fcd97d3ebf7484f037b76c9afea9ca09a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 24 Nov 2021 09:12:16 +0100
>Subject: [PATCH] Bug 29485: (follow-up) Trying to prevent
> administration_tasks.t to fail randomly
>
>Recreated the problem after run #47
>Error while executing command: no such element: Unable to locate element: //*[@id="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411.
>
>With this patch I do not longer recreate the failure. It's ugly but,
>well, I don't have any other solutions. It seems that the accept_alert
>is taking too long and is async (??)
>---
> t/db_dependent/selenium/administration_tasks.t | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/selenium/administration_tasks.t b/t/db_dependent/selenium/administration_tasks.t
>index f46bbad412f..080400d2a32 100755
>--- a/t/db_dependent/selenium/administration_tasks.t
>+++ b/t/db_dependent/selenium/administration_tasks.t
>@@ -181,14 +181,14 @@ SKIP: {
>             }
>         );
>         $s->driver->accept_alert; # Accept the modal "Are you sure you want to delete this authorized value?"
>+
>+        # For an unknown reason the click on the next admin-home link does not work
>+        # We were still on the authorised value list view.
>+        # A workaround (and dirty fix) is to wait for 1 second and see if it fixes the problem
>+        sleep 1;
>     };
> 
>     { # Patron categories
>-        # For an unknown reason the click on the admin-home link does not work
>-        # At this point we were still on the authorised value list view.
>-        # A workaround (and dirty fix) is to logout/login and see if it fixes the problem
>-        $driver->get( $mainpage . q|?logout.x=1| );
>-        $s->auth;
>         $driver->get($mainpage);
>         $s->click( { href => '/admin/admin-home.pl', main => 'container-main' } ); # Koha administration
>         $s->click( { href => '/admin/categories.pl', main_class => 'main container-fluid' } ); # Patron categories
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29485: 127654 | 127971