Since bug 19185, and Koha_Master running the tests after t/db_dependent/selenium/01-installation.t is ran, t/db_dependent/selenium/administration_tasks.t is failing randomly with: 12:32:59 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:32:59 koha_1 | (eval 1710):1 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | (eval 1712):2 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) 12:32:59 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:170 in Selenium::Remote::Driver::find_element 12:32:59 koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in t::lib::Selenium::click I don't recreate it locally. The screenshot of the failure shows that the screen is still on the authorised value list view.
Created attachment 127654 [details] [review] Bug 29485: Trying to prevent administration_tasks.t to fail randomly Since bug 19185, and Koha_Master running the tests after t/db_dependent/selenium/01-installation.t is ran, t/db_dependent/selenium/administration_tasks.t is failing randomly with: 12:32:59 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:32:59 koha_1 | (eval 1710):1 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | (eval 1712):2 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) 12:32:59 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:170 in Selenium::Remote::Driver::find_element 12:32:59 koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in t::lib::Selenium::click I don't recreate it locally. The screenshot of the failure shows that the screen is still on the authorised value list view. This does not make a lot of sense, but I am failing to find a logic here.
Patch pushed to master for 21.11.00
thanks, I'll try to reproduce and see if that can still happen when I'll upgrade Selenium to v4. Fingers crossed to not need the dirty fix after that.
Pushed to 21.05.x for 21.05.05
I see it has been reverted from 21.05.x : 4107c8def4 Revert "Bug 29485: Trying to prevent administration_tasks.t to fail randomly"
(In reply to Fridolin Somers from comment #5) > I see it has been reverted from 21.05.x : > > 4107c8def4 Revert "Bug 29485: Trying to prevent administration_tasks.t to > fail randomly" Yes, my bad for not posting an update. Patched unit tests run and pass, but are superfluous as parent bug is not part of 21.05.x.
Created attachment 127971 [details] [review] Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail randomly Recreated the problem after run #47 Error while executing command: no such element: Unable to locate element: //*[@id="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411. With this patch I do not longer recreate the failure. It's ugly but, well, I don't have any other solutions. It seems that the accept_alert is taking too long and is async (??)
(In reply to Jonathan Druart from comment #7) > Created attachment 127971 [details] [review] [review] > Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail > randomly > > Recreated the problem after run #47 > Error while executing command: no such element: Unable to locate element: > //*[@id="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm > line 411. > > With this patch I do not longer recreate the failure. It's ugly but, > well, I don't have any other solutions. It seems that the accept_alert > is taking too long and is async (??) Patch pushed to master.