Bugzilla – Attachment 127973 Details for
Bug 29567
Cataloguing plugins are broken on the batch item mod tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins
Bug-29567-bug-28445-follow-up-Restore-cataloguing-.patch (text/plain), 2.05 KB, created by
Jonathan Druart
on 2021-11-24 10:58:52 UTC
(
hide
)
Description:
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-11-24 10:58:52 UTC
Size:
2.05 KB
patch
obsolete
>From 6083f87f55fd7f0447aec2e9a660da5caead58e1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 24 Nov 2021 11:56:52 +0100 >Subject: [PATCH] Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins > >Broken by bug 28445. > >See also the FIXME from > commit 86156da415141e32e16f2090477be32bda241afb > Bug 28445: Adjust code to handle regexs > >The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer >in somes page we have all the JS loaded at the end of the DOM >and so $ (jQuery) is not defined > >It's working on additem as we don't have the JS in the footer, but the >batch item mod tool has it there. > >Test plan: >Batch edit items and confirm that cataloguing are working correctly with >this patch applied. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 75402985f02..a7207e4b0b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -225,6 +225,7 @@ > [% INCLUDE 'datatables.inc' %] > [% Asset.js("js/pages/batchMod.js") | $raw %] > [% INCLUDE 'select2.inc' %] >+ [% INCLUDE 'calendar.inc' %] > <script> > // Prepare array of all column headers, incrementing each index by > // two to accommodate control and title columns >@@ -283,7 +284,7 @@ > [%- UNLESS (too_many_items_process) -%] > [%- FOREACH subfield IN subfields -%] > [% SET mv = subfield.marc_value %] >- [%- IF ( mv.type == 'text2' ) -%] >+ [%- IF ( mv.type == 'text_plugin' ) -%] > <!-- subfield[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %] --> > [% mv.javascript | $raw %] > [%- END -%] >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29567
:
127973
|
127974