Bugzilla – Attachment 130690 Details for
Bug 21225
Add Syndetics cover images to staff client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21225: (follow-up) Account for Syndetics lightbox
Bug-21225-follow-up-Account-for-Syndetics-lightbox.patch (text/plain), 2.81 KB, created by
Lucas Gass (lukeg)
on 2022-02-16 18:32:53 UTC
(
hide
)
Description:
Bug 21225: (follow-up) Account for Syndetics lightbox
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-02-16 18:32:53 UTC
Size:
2.81 KB
patch
obsolete
>From 889dbd2efbccab758dcd343c7c72486eef627c5c Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 16 Feb 2022 17:48:50 +0000 >Subject: [PATCH] Bug 21225: (follow-up) Account for Syndetics lightbox > >To test: >-Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. >-Turn on some other cover image services and make sure you can toggle through each of them. >--- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 14fc174d50..4fb6278d13 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -240,7 +240,7 @@ > [% IF ( SyndeticsCovers ) %] > [% IF ( content_identifier_exists ) %] > <div class="cover-image" id="syndetics-bookcoverimg"> >- <a title="Syndetics cover image"> >+ <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/LC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" title="Syndetics cover image"> > <img src="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/[% Koha.Preference('SyndeticsCoverImageSize') | html %].GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% normalized_upc | html %]&oclc=[% normalized_oclc | html %]" alt="" class="thumbnail" /> > </a> > <div class="hint">Image from Syndetics</div> >@@ -1089,7 +1089,10 @@ Note that permanent location is a code, and location may be an authval. > } else { > lightbox_descriptions.push("Custom cover image"); > } >- } else if( div.attr("id") == "coce-coverimg" ){ >+ } else if ( div.attr("id") == "syndetics-bookcoverimg" ){ >+ lightbox_descriptions.push(_("Syndetics cover image (<a href='%s'>see the original image</a>)").format($(img).data('link'))); >+ } >+ else if( div.attr("id") == "coce-coverimg" ){ > // Identify which service's image is being loaded by Coce > var coce_description; > if( $(img).attr("src").indexOf('amazon.com') >= 0 ){ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21225
:
116911
|
123581
|
130638
|
130640
|
130689
|
130690
|
130696
|
130697
|
130698
|
132357
|
132366
|
132367
|
132368
|
132369
|
132370