Bugzilla – Attachment 130909 Details for
Bug 29965
MARC preview for authority search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29965: (follow-up) Use a new class for the preview
Bug-29965-follow-up-Use-a-new-class-for-the-previe.patch (text/plain), 4.25 KB, created by
Katrin Fischer
on 2022-02-19 19:31:34 UTC
(
hide
)
Description:
Bug 29965: (follow-up) Use a new class for the preview
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-02-19 19:31:34 UTC
Size:
4.25 KB
patch
obsolete
>From 1881bc0e9859d2b6b9e3eda0e50ebe0e064de131 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 18 Feb 2022 17:31:04 +0000 >Subject: [PATCH] Bug 29965: (follow-up) Use a new class for the preview > >With previous patches everythign worked, however, clicking the heading in >authority search results now launched the preview instead of taking you to the >authority details > >This patch uses a new class to launch the modal and conditionally applies it to >authority results as we expect different behaviours when searching from the popup >vs authority module > >To test: >1 - Repeate previous tests, confirm they pass >2 - Search for authorities in the authority module >3 - COnfirm clicking on heading takes you to detail page for authority > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/includes/authorities-search-results.inc | 2 +- > .../prog/en/modules/authorities/searchresultlist-auth.tt | 2 +- > .../prog/en/modules/authorities/searchresultlist.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >index 3e0c4904f1..66d8c7f633 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >@@ -64,7 +64,7 @@ > [% UNLESS ( summary.summaryonly ) %] > <div class="authorizedheading"> > [% FOREACH authorize IN summary.authorized %] >- <span class="authorizedheading"> >+ <span class="authorizedheading [% IF auth_preview %]authority_preview[% END %]"> > <a data-authid="[% authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% authid | uri %]">[% authorize.heading | html %]</a> > </span> > [% UNLESS loop.last %] | [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >index f50e578a84..ea9754225a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >@@ -50,7 +50,7 @@ > </tr> > [% FOREACH resul IN result %] > <tr> >- <td>[% PROCESS authresult summary=resul.summary authid=resul.authid %]</td> >+ <td>[% PROCESS authresult summary=resul.summary authid=resul.authid auth_preview=1 %]</td> > <td>[% resul.summary.label | html %]</td> > <td>[% resul.used | html %] times</td> > <td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >index 3d36ed3b28..e5de11f17c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >@@ -79,7 +79,7 @@ > [% UNLESS ( resul.used ) %] > <li><a onclick='return confirm_deletion("[% resul.authid | html %]")'><i class="fa fa-trash"></i> Delete</a></li> > [% END %] >- <li class="authorizedheading"> >+ <li class="authority_preview"> > <a data-authid="[% resul.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% resul.authid | uri %]"><i class="fa fa-eye"></i> MARC preview</a> > </li> > </ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js b/koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js >index 26a314d00d..931cecd1f3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js >@@ -1,5 +1,5 @@ > $(document).ready(function(){ >- $(".authorizedheading a").on("click", function(e){ >+ $(".authority_preview a").on("click", function(e){ > e.preventDefault(); > var authid = $(this).data("authid"); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29965
:
129918
|
129983
|
130635
|
130880
|
130881
|
130882
|
130907
|
130908
| 130909 |
130910