Bug 12533 added a MARC preview for authority search results to the cataloguing authority finder plugin. This modal would be useful for the general authority search results as sometimes you want to compare authorities in the results list.
Created attachment 129918 [details] [review] Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the MARC preview button to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS
I think for consistency the preview button should be in the Actions menu (see cataloging search).
Created attachment 129983 [details] [review] Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS
Created attachment 130635 [details] [review] Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 130880 [details] [review] Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 130881 [details] [review] Bug 29965: (follow-up) Move repeated JS to its own file Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 130882 [details] [review] Bug 29965: (follow-up) Use a new class for the preview With previous patches everythign worked, however, clicking the heading in authority search results now launched the preview instead of taking you to the authority details This patch uses a new class to launch the modal and conditionally applies it to authority results as we expect different behaviours when searching from the popup vs authority module To test: 1 - Repeate previous tests, confirm they pass 2 - Search for authorities in the authority module 3 - COnfirm clicking on heading takes you to detail page for authority Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I added a bit, could use another QA eye
Created attachment 130907 [details] [review] Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 130908 [details] [review] Bug 29965: (follow-up) Move repeated JS to its own file Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 130909 [details] [review] Bug 29965: (follow-up) Use a new class for the preview With previous patches everythign worked, however, clicking the heading in authority search results now launched the preview instead of taking you to the authority details This patch uses a new class to launch the modal and conditionally applies it to authority results as we expect different behaviours when searching from the popup vs authority module To test: 1 - Repeate previous tests, confirm they pass 2 - Search for authorities in the authority module 3 - COnfirm clicking on heading takes you to detail page for authority Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 130910 [details] [review] Bug 29965: (QA follow-up) Fix translation issue in moved JS code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This is great :D
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
*** Bug 28247 has been marked as a duplicate of this bug. ***