Attachment 13144 Details for Bug 8707 – [SIGNED-OFF] Bug 8707 - tags always say approved

[patch] [SIGNED-OFF] Bug 8707 - tags always say approved

SIGNED-OFF-Bug-8707---tags-always-say-approved.patch (text/plain), 2.02 KB, created by Nicole C. Engard on 2012-10-31 14:51:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-10-31 14:51:10 UTC

Size: 2.02 KB

patch

obsolete

>From 1670bc38d2ae6f1e0b8076b2f2819a0c9002e911 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 30 Oct 2012 11:07:04 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8707 - tags always say approved
>
>Template scope error caused an incorrect state on the
>approval/rejection buttons when viewing rejected tags.
>
>To test, go to Tags and view the list of rejected tags.
>In the "Actions" column, the "rejected" button should be
>greyed out, and the "approve" button active.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/tags/review.tt   |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>index 4b68e13..4569525 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>@@ -209,7 +209,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
> 	<tr>
> 	    <td class="count">[% offset + loop.count %]
> 	    </td>
>-        [% IF ( approved == 0 ) %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" class="pending" /></span>
>+        [% IF ( tagloo.approved == 0 ) %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" class="pending" /></span>
>         [% ELSE %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" /></span>[% END %]
> 	    </td>
> 	    [% IF ( tagloo.approved == -1 ) %]<td class="red">rejected
>@@ -223,7 +223,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
> 	    </td>
> 		[% IF ( tagloo.approved ) %]
> 	    <td><span class="ajax_buttons" style="visibility:hidden">
>-			[% IF ( approved == -1 ) %]
>+            [% IF ( tagloo.approved == -1 ) %]
> 			<input class="ok"  type="submit" title="[% tagloo.term %]" value="Approve" name="approve" />
> 			<input class="rej" disabled="disabled" type="submit" title="[% tagloo.term %]" value="Rejected" name="reject" />
> 			[% ELSE %]
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8707: 11900 | 11901 | 13118 | 13144