Bug 8707 - tags always say approved
Summary: tags always say approved
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
Depends on:
Reported: 2012-08-31 00:47 UTC by Nicole C. Engard
Modified: 2013-12-05 20:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

rejected say approved (31.45 KB, image/png)
2012-08-31 00:47 UTC, Nicole C. Engard
rejected and approved all say approved (56.51 KB, image/png)
2012-08-31 00:48 UTC, Nicole C. Engard
Bug 8707 - tags always say approved (1.99 KB, patch)
2012-10-30 15:09 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8707 - tags always say approved (2.02 KB, patch)
2012-10-31 14:51 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-08-31 00:47:39 UTC
Created attachment 11900 [details]
rejected say approved

This happens in master and 3.8.4 (those are the ones I tested).

When you look at your tags there used to be tabs across the top for pending/approved/rejected - now there isn't, but this isn't as big a deal as the fact that tags that were rejected have the 'approved' box depressed.  See attached images.
Comment 1 Nicole C. Engard 2012-08-31 00:48:06 UTC
Created attachment 11901 [details]
rejected and approved all say approved

See the buttons on the right show approved no matter what.
Comment 2 Marc Véron 2012-09-24 21:15:18 UTC
Comment on attachment 11901 [details]
rejected and approved all say approved

Workaround I:

Check checkboxes next tags you want to approve again and use the "Approve" button at the bottom of the table.

Workaround II:

On the line of a rejected tag, click the "Reject" button. Thsi will activate the "Approved" button. 

Comment 3 Marc Véron 2012-09-24 21:19:09 UTC
...but with Workaround II the "Approved" button becomes active, but it does nothing...

Comment 4 Marc Véron 2012-09-24 22:03:47 UTC
...and some more findings:

The button I mentioned in Comment #3 only _seems_ to do nothing. As soon I reload the page or apply the filter again the status is changed.
Comment 5 Owen Leonard 2012-10-30 15:09:44 UTC Comment hidden (obsolete)
Comment 6 Nicole C. Engard 2012-10-31 14:51:10 UTC Comment hidden (obsolete)
Comment 7 Nicole C. Engard 2012-10-31 14:51:57 UTC
If this can go in to 3.10 and 3.8 that would be awesome!!
Comment 8 Jonathan Druart 2012-10-31 15:38:10 UTC
QA Comments:

Easy fix, just one 

I think this line could be removed in the review.pl file
  approved => 0,		# dummy value (also EXPR)

Marked as Passed QA.
Comment 9 Jared Camins-Esakov 2012-10-31 22:20:12 UTC
This patch has been pushed to master.
Comment 10 Paul Poulain 2012-11-01 19:28:24 UTC
Patch pushed to branch 3.10.x
Comment 11 Chris Cormack 2013-04-21 10:43:07 UTC
Released with 3.10.0