Bugzilla – Attachment 13185 Details for
Bug 8904
Plack variable scoping in tools/overduerules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5904 fix Plack scoping for overduerules.pl
Bug-5904-fix-Plack-scoping-for-overduerulespl.patch (text/plain), 1.16 KB, created by
Paul Poulain
on 2012-11-02 08:54:23 UTC
(
hide
)
Description:
Bug 5904 fix Plack scoping for overduerules.pl
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2012-11-02 08:54:23 UTC
Size:
1.16 KB
patch
obsolete
>From 213dc67686bcd2115300c901a92d4076dac2a701 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 2 Nov 2012 09:53:57 +0100 >Subject: [PATCH] Bug 5904 fix Plack scoping for overduerules.pl > >There are 2 Plack scoping errors in tools/overduerules.pl: >the local sub blank_row require that @rule_params and input are global > >http://bugs.koha-community.org/show_bug.cgi?id=8904 >--- > tools/overduerules.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/overduerules.pl b/tools/overduerules.pl >index 478a762..cc90d0b 100755 >--- a/tools/overduerules.pl >+++ b/tools/overduerules.pl >@@ -28,7 +28,7 @@ use C4::Branch; > use C4::Letters; > use C4::Members; > >-my $input = new CGI; >+our $input = new CGI; > my $dbh = C4::Context->dbh; > > my @categories = @{$dbh->selectall_arrayref( >@@ -36,7 +36,7 @@ my @categories = @{$dbh->selectall_arrayref( > { Slice => {} } > )}; > my @category_codes = map { $_->{categorycode} } @categories; >-my @rule_params = qw(delay letter debarred); >+our @rule_params = qw(delay letter debarred); > > # blank_row($category_code) - return true if the entire row is blank. > sub blank_row { >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8904
:
13185
|
13198