It's impossible to save overduerules when you're running plack. Plack logs say: Variable "@rule_params" is not available at /home/paul/koha.dev/koha-community/tools/overduerules.pl line 44. Variable "$input" is not available at /home/paul/koha.dev/koha-community/tools/overduerules.pl line 52.
Created attachment 13185 [details] [review] Bug 5904 fix Plack scoping for overduerules.pl There are 2 Plack scoping errors in tools/overduerules.pl: the local sub blank_row require that @rule_params and input are global
Upgrading severity to BLO, because it's a blocker for Plack
Created attachment 13198 [details] [review] Bug 8904: fix Plack scoping for overduerules.pl There are 2 Plack scoping errors in tools/overduerules.pl: the local sub blank_row require that @rule_params and input are global Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(In reply to comment #3) > Created attachment 13198 [details] [review] > Bug 8904: fix Plack scoping for overduerules.pl > > There are 2 Plack scoping errors in tools/overduerules.pl: > the local sub blank_row require that @rule_params and input are global > > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> patch looks good and works as stated, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit dcf4a9b) * fa2cf71 Bug 8904: fix Plack scoping for overduerules.pl tools/overduerules.pl * tools/overduerules.pl OK
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0