Bugzilla – Attachment 132042 Details for
Bug 30121
Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30121: Add relationship to borrowers.json
Bug-30121-Add-relationship-to-borrowersjson.patch (text/plain), 4.03 KB, created by
Fridolin Somers
on 2022-03-23 00:43:12 UTC
(
hide
)
Description:
Bug 30121: Add relationship to borrowers.json
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2022-03-23 00:43:12 UTC
Size:
4.03 KB
patch
obsolete
>From 62f337a3ba3427794e77e82ad08cab091c4f088d Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 17 Feb 2022 15:59:33 +0000 >Subject: [PATCH] Bug 30121: Add relationship to borrowers.json > >This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. >- BorrowerUnwantedField >- BorrowerMandatoryField >- PatronDuplicateMatchingAddFields >- PatronQuickAddFields > >- PatronSelfModificationBorrowerUnwantedField >- PatronSelfModificationMandatoryField >- PatronSelfRegistrationBorrowerMandatoryField >- PatronSelfRegistrationBorrowerUnwantedField > >To test: >1. Apply patch >2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. > >Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > .../prog/en/modules/admin/preferences/borrowers.json | 1 + > .../prog/en/modules/members/memberentrygen.tt | 9 ++++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json >index a15bcaacf9..b77b6ad16c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json >@@ -36,6 +36,7 @@ > "categorycode": "categorycode", > "contactname": "contactname", > "contactfirstname": "contactfirstname", >+ "relationship": "relationship", > "borrowernotes": "borrowernotes", > "sex": "sex", > "password": "password", >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index a8a9ad3f7e..f3edd4fc10 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -632,7 +632,11 @@ legend:hover { > [% UNLESS norelationship %] > [% IF possible_relationships %] > <li> >- <label for="relationship">Relationship: </label> >+ [% IF mandatoryrelationship %] >+ <label for="relationship" class="required">Relationship: </label> >+ [% ELSE %] >+ <label for="relationship">Relationship: </label> >+ [% END %] > <select class="relationship" name="relationship"> > <option value=""></option> > [% FOREACH pr IN possible_relationships.split('\|') %] >@@ -643,6 +647,9 @@ legend:hover { > [% END %] > [% END %] > </select> >+ [% IF mandatoryrelationship %] >+ <span class="required">Required</span> >+ [% END %] > </li> > [% END #/IF possible_relationships %] > [% END # /UNLESS norelationship %] >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30121
:
130762
|
132041
| 132042 |
132378