The options in the BorrowerUnwantedFields syspref don't include borrowers.relationship, which contains the relationship value for a non-patron guarantor. We should be able to hide this field if desired.
Created attachment 130762 [details] [review] Bug 30121: Add relationship to borrwers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them.
Created attachment 132041 [details] [review] Bug 30121: Add relationship to borrwers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 132042 [details] [review] Bug 30121: Add relationship to borrowers.json This patch addes the realtionship field to borrowers.json and therefore the various borrower related system preferences. - BorrowerUnwantedField - BorrowerMandatoryField - PatronDuplicateMatchingAddFields - PatronQuickAddFields - PatronSelfModificationBorrowerUnwantedField - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test: 1. Apply patch 2. Test adding and removing the relationship field from the various system preferences listed above, making sure it works correctly for each. Note: I belive for the self registration prefs that contactname, contactfirstname, and relationship should be excluded as choices. If so, I can provide a follow-up to exclude each of them. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Relationship option appears in PatronQuickAddFields but unchecking it doesn't work when adding kid or juvenile via Quick add new patron. The Relationship field is still mandatory (required) under the surname field. The relationship filed disappears if I emtpy borrowerRelationship but that is not a good option because then the relationship field disappers from the Patron guarantor also. (Sorry, I didn't know what to choose to the Status)
(In reply to Anneli Österman from comment #4) > Relationship option appears in PatronQuickAddFields but unchecking it > doesn't work when adding kid or juvenile via Quick add new patron. The > Relationship field is still mandatory (required) under the surname field. > > The relationship filed disappears if I emtpy borrowerRelationship but that > is not a good option because then the relationship field disappers from the > Patron guarantor also. > > (Sorry, I didn't know what to choose to the Status) Yes, that is a good catch. The field is not called relationship in the quick add field, instead it is called new_guarantor_relationship. So when we check relationship we get two fields new_guarantor_relationship and relationship. I think in this case we want to exclude relation ship for the PatronQuickAddFields pref.
Created attachment 132378 [details] [review] Bug 30121: (follow-up) exclude relationship from PatronQuickAddFields
(In reply to Lucas Gass from comment #5) > (In reply to Anneli Österman from comment #4) > > Relationship option appears in PatronQuickAddFields but unchecking it > > doesn't work when adding kid or juvenile via Quick add new patron. The > > Relationship field is still mandatory (required) under the surname field. > > > > The relationship filed disappears if I emtpy borrowerRelationship but that > > is not a good option because then the relationship field disappers from the > > Patron guarantor also. > > > > (Sorry, I didn't know what to choose to the Status) > > Yes, that is a good catch. The field is not called relationship in the quick > add field, instead it is called new_guarantor_relationship. > > So when we check relationship we get two fields new_guarantor_relationship > and relationship. > > I think in this case we want to exclude relation ship for the > PatronQuickAddFields pref. I'm still seeing this issue with the follow-up patch applied. "Relationship" shows in the Quick Add fields and is required even though it's not in BorrowerMandatory or PatronQuickAdd system preferences.
This patch must be reworked as the borrowers.json no longer exists in master.