Bugzilla – Attachment 132050 Details for
Bug 30031
Add lists to table settings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30031: (follow-up) Disable some DataTables options which don't apply
Bug-30031-follow-up-Disable-some-DataTables-option.patch (text/plain), 1.65 KB, created by
Séverine Queune
on 2022-03-23 09:49:05 UTC
(
hide
)
Description:
Bug 30031: (follow-up) Disable some DataTables options which don't apply
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2022-03-23 09:49:05 UTC
Size:
1.65 KB
patch
obsolete
>From b573e70e920c3415ce692b4b95567637aa5ddff9 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 16 Mar 2022 14:13:27 +0000 >Subject: [PATCH] Bug 30031: (follow-up) Disable some DataTables options which > don't apply >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The list contents view is sorted and paged server-side, so it doesn't >make sense to add DataTables ordering or paging to the rendered table. > >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> >--- > .../prog/en/modules/virtualshelves/shelves.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 199d567d22..6abb67bff9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -610,12 +610,10 @@ > $(document).ready(function(){ > var column_settings = [% TablesSettings.GetColumns( 'catalogue', 'lists', 'searchresults', 'json' ) | $raw %]; > KohaTable("searchresults", { >- "dom": 'lrt', >- "sorting": [[ 1, "asc" ]], >+ "dom": 't', > "autoWidth": false, >- "asColumnDefs": [ >- { "aTargets": [ 1 ], "sType": "nsb-nse" }, >- ] >+ "ordering": false, >+ "paging": false > }, column_settings ); > > Sticky = $("#searchheader"); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30031
:
130182
|
130183
|
131798
|
132037
|
132049
|
132050
|
132051
|
144887
|
144962
|
144966
|
158626
|
159084
|
159119
|
159859
|
162085
|
166716