Bug 30031 - Add lists to table settings
Summary: Add lists to table settings
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement with 1 vote (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-04 20:12 UTC by hebah
Modified: 2024-05-10 09:33 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes the columns for lists in the staff interface configurable.
Version(s) released in:


Attachments
Bug 30031: Add table settings to staff lists (op=view) (3.34 KB, patch)
2022-02-04 22:20 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add table settings to staff lists (op=view) (3.39 KB, patch)
2022-02-05 07:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 30031: (follow-up) Disable some DataTables options which don't apply (1.50 KB, patch)
2022-03-16 14:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30031: (follow-up) account for item-level_itypes (6.53 KB, patch)
2022-03-22 20:32 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add table settings to staff lists (op=view) (3.54 KB, patch)
2022-03-23 09:49 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30031: (follow-up) Disable some DataTables options which don't apply (1.65 KB, patch)
2022-03-23 09:49 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30031: (follow-up) account for item-level_itypes (6.68 KB, patch)
2022-03-23 09:49 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (9.67 KB, patch)
2022-12-29 16:11 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (21.27 KB, patch)
2023-01-03 23:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (21.32 KB, patch)
2023-01-04 01:16 UTC, David Nind
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (20.29 KB, patch)
2023-11-07 21:42 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (20.46 KB, patch)
2023-11-17 14:28 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (20.52 KB, patch)
2023-11-17 22:00 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (20.56 KB, patch)
2023-12-15 06:18 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 30031: Add column settings to list view (20.61 KB, patch)
2024-02-13 05:56 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description hebah 2022-02-04 20:12:54 UTC
The contents table of List columns in the staff client are not configurable via table settings and should be.
Comment 1 Lucas Gass 2022-02-04 22:20:15 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-02-05 07:18:57 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2022-03-16 14:22:54 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2022-03-16 14:26:33 UTC
This patch doesn't take into account the item type column which may be displayed depending on whether you have item-level_itypes set to "bibliographic record" or "specific item."

If you have it set to "bibliographic record" the table shows an item type column and column hiding hides the wrong column.
Comment 5 Lucas Gass 2022-03-22 20:32:26 UTC Comment hidden (obsolete)
Comment 6 Séverine Queune 2022-03-23 09:49:01 UTC
Created attachment 132049 [details] [review]
Bug 30031: Add table settings to staff lists (op=view)

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Catalog for lists.
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 7 Séverine Queune 2022-03-23 09:49:05 UTC
Created attachment 132050 [details] [review]
Bug 30031: (follow-up) Disable some DataTables options which don't apply

The list contents view is sorted and paged server-side, so it doesn't
make sense to add DataTables ordering or paging to the rendered table.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 8 Séverine Queune 2022-03-23 09:49:08 UTC
Created attachment 132051 [details] [review]
Bug 30031: (follow-up) account for item-level_itypes

To test:
To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Catalog for lists.
5. The search results table should be listed, with the ability to hide the author, date_added, or call_number
6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 9 Katrin Fischer 2022-04-24 11:35:54 UTC
1) Setting columns on the page

This part of the test plan doesn't work for me, as there is no "Columns" button:

6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )

Can you please have a look?


2) Configuration

I believe as Lists appears as it's own module, we should also have it's own section for it on administration > table configuration. What do you think?
Comment 10 Lucas Gass 2022-04-26 22:16:53 UTC
Cait,

I purposefully left out the 'Columns' button from the configuration options.  For Test Plan Step 7 I meant hide them via Table Setting. 

Do you think I should add the 'Columns' button to the top of the page? In that case should we also add the Export function? 


I am happy to move lists to its own module in Table Settings!
Comment 11 Katrin Fischer 2022-04-27 07:41:26 UTC
Hi Lucas,

this table doesn't look quite like our typical datatable, so I was not sure, how this was supposed to work. I am ok with the settings missing for now or to move it to a separate bug, depending on how much work it is for you.

Moving the config to a separate section in a follow-up would be great.
Comment 12 Lucas Gass 2022-12-29 16:11:30 UTC
Created attachment 144887 [details] [review]
Bug 30031: Add column settings to list view
Comment 13 Lucas Gass 2023-01-03 23:12:16 UTC
Created attachment 144962 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Catalog for lists.
5. The search results table should be listed, with the ability to hide the author, date_added, or call_number
6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now.

Note: I have also added the page-section class to this table.
Comment 14 Lucas Gass 2023-01-03 23:12:55 UTC
reset to 'Needs signoff'
Comment 15 David Nind 2023-01-04 01:16:13 UTC
Created attachment 144966 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Catalog for lists.
5. The search results table should be listed, with the ability to hide the author, date_added, or call_number
6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now.

Note: I have also added the page-section class to this table.

Signed-off-by: David Nind <david@davidnind.com>
Comment 16 Marcel de Rooy 2023-02-24 10:07:36 UTC
Looks good on the list detail form.
Two things:
Could you also add the main list form where you see your lists.
And could you move it to its own module. Lists is a module on the mainpage.
Comment 17 Todd Goatley 2023-08-11 18:39:49 UTC
What does this bug need to move forward? It shows signed off but FailedQA?
Comment 18 Katrin Fischer 2023-08-23 15:46:18 UTC
(In reply to Todd Goatley from comment #17)
> What does this bug need to move forward? It shows signed off but FailedQA?

Just in the comment above yours Marcel has asked for 2 changes as part of the QA step.
Comment 19 Lucas Gass 2023-08-23 15:50:16 UTC
(In reply to Todd Goatley from comment #17)
> What does this bug need to move forward? It shows signed off but FailedQA?

My apologies. I will try to get back around to this ASAP!
Comment 20 Lucas Gass 2023-11-07 21:42:56 UTC
Created attachment 158626 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Lists: Table id: searchresults
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
Comment 21 Lucas Gass 2023-11-07 21:45:32 UTC
> Could you also add the main list form where you see your lists.
Since I think that is out of scope, I filed a bug for this:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35281


> And could you move it to its own module. Lists is a module on the mainpage.
Yes, I have done so!
Comment 22 Anni Rajala 2023-11-17 12:02:48 UTC
I tested this and although this worked otherwise as described in latest test plan, there is a column "item_type" in the table settings that doesn't seem to have a purpose? The column "item_type" is not mentioned in test plan and it didn't seem to have any effect 'cause there isn't such colum in the list view.
Comment 23 Lucas Gass 2023-11-17 14:28:03 UTC
(In reply to Anni Rajala from comment #22)
> I tested this and although this worked otherwise as described in latest test
> plan, there is a column "item_type" in the table settings that doesn't seem
> to have a purpose? The column "item_type" is not mentioned in test plan and
> it didn't seem to have any effect 'cause there isn't such colum in the list
> view.

Thanks for testing Anni. I neglected to include item-level_itypes in my test plan. Patch incoming with an adjusted test plan.
Comment 24 Lucas Gass 2023-11-17 14:28:29 UTC
Created attachment 159084 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Lists: Table id: searchresults
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
8. Set item-level_itypes to 'bibliographic record' so the item type column will show.
9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
Comment 25 Andrew Fuerste-Henry 2023-11-17 22:00:35 UTC
Created attachment 159119 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Lists: Table id: searchresults
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
8. Set item-level_itypes to 'bibliographic record' so the item type column will show.
9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 26 PTFS Europe Sandboxes 2023-12-15 06:18:32 UTC
Created attachment 159859 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Lists: Table id: searchresults
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
8. Set item-level_itypes to 'bibliographic record' so the item type column will show.
9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Anni Rajala <anni.rajala@turku.fi>
Comment 27 PTFS Europe Sandboxes 2024-02-13 05:56:48 UTC
Created attachment 162085 [details] [review]
Bug 30031: Add column settings to list view

To test:
1. Apply patch and restart_all
2. Create a list
3. GO to Administration > Table settings
4. In Table settings look under Lists: Table id: searchresults
6. The search results table should be listed, with the ability to hide the author, date_added, or call_number
7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 )
8. Set item-level_itypes to 'bibliographic record' so the item type column will show.
9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Anni Rajala <anni.rajala@turku.fi>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>