The contents table of List columns in the staff client are not configurable via table settings and should be.
Created attachment 130182 [details] [review] Bug 30031: Add table settings to staff lists (op=view) To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
Created attachment 130183 [details] [review] Bug 30031: Add table settings to staff lists (op=view) To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 131798 [details] [review] Bug 30031: (follow-up) Disable some DataTables options which don't apply The list contents view is sorted and paged server-side, so it doesn't make sense to add DataTables ordering or paging to the rendered table.
This patch doesn't take into account the item type column which may be displayed depending on whether you have item-level_itypes set to "bibliographic record" or "specific item." If you have it set to "bibliographic record" the table shows an item type column and column hiding hides the wrong column.
Created attachment 132037 [details] [review] Bug 30031: (follow-up) account for item-level_itypes To test: To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now.
Created attachment 132049 [details] [review] Bug 30031: Add table settings to staff lists (op=view) To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132050 [details] [review] Bug 30031: (follow-up) Disable some DataTables options which don't apply The list contents view is sorted and paged server-side, so it doesn't make sense to add DataTables ordering or paging to the rendered table. Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132051 [details] [review] Bug 30031: (follow-up) account for item-level_itypes To test: To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
1) Setting columns on the page This part of the test plan doesn't work for me, as there is no "Columns" button: 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Can you please have a look? 2) Configuration I believe as Lists appears as it's own module, we should also have it's own section for it on administration > table configuration. What do you think?
Cait, I purposefully left out the 'Columns' button from the configuration options. For Test Plan Step 7 I meant hide them via Table Setting. Do you think I should add the 'Columns' button to the top of the page? In that case should we also add the Export function? I am happy to move lists to its own module in Table Settings!
Hi Lucas, this table doesn't look quite like our typical datatable, so I was not sure, how this was supposed to work. I am ok with the settings missing for now or to move it to a separate bug, depending on how much work it is for you. Moving the config to a separate section in a follow-up would be great.
Created attachment 144887 [details] [review] Bug 30031: Add column settings to list view
Created attachment 144962 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table.
reset to 'Needs signoff'
Created attachment 144966 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table. Signed-off-by: David Nind <david@davidnind.com>
Looks good on the list detail form. Two things: Could you also add the main list form where you see your lists. And could you move it to its own module. Lists is a module on the mainpage.
What does this bug need to move forward? It shows signed off but FailedQA?
(In reply to Todd Goatley from comment #17) > What does this bug need to move forward? It shows signed off but FailedQA? Just in the comment above yours Marcel has asked for 2 changes as part of the QA step.
(In reply to Todd Goatley from comment #17) > What does this bug need to move forward? It shows signed off but FailedQA? My apologies. I will try to get back around to this ASAP!
Created attachment 158626 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
> Could you also add the main list form where you see your lists. Since I think that is out of scope, I filed a bug for this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35281 > And could you move it to its own module. Lists is a module on the mainpage. Yes, I have done so!
I tested this and although this worked otherwise as described in latest test plan, there is a column "item_type" in the table settings that doesn't seem to have a purpose? The column "item_type" is not mentioned in test plan and it didn't seem to have any effect 'cause there isn't such colum in the list view.
(In reply to Anni Rajala from comment #22) > I tested this and although this worked otherwise as described in latest test > plan, there is a column "item_type" in the table settings that doesn't seem > to have a purpose? The column "item_type" is not mentioned in test plan and > it didn't seem to have any effect 'cause there isn't such colum in the list > view. Thanks for testing Anni. I neglected to include item-level_itypes in my test plan. Patch incoming with an adjusted test plan.
Created attachment 159084 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable )
Created attachment 159119 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 159859 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Anni Rajala <anni.rajala@turku.fi>
Created attachment 162085 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 166716 [details] [review] Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Anni Rajala <anni.rajala@turku.fi> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Unsetting the QA contact here since this one has been sitting quite a while. Still applies cleanly to main.