Bugzilla – Attachment 132051 Details for
Bug 30031
Add lists to table settings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30031: (follow-up) account for item-level_itypes
Bug-30031-follow-up-account-for-item-levelitypes.patch (text/plain), 6.68 KB, created by
Séverine Queune
on 2022-03-23 09:49:08 UTC
(
hide
)
Description:
Bug 30031: (follow-up) account for item-level_itypes
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2022-03-23 09:49:08 UTC
Size:
6.68 KB
patch
obsolete
>From 9a3cf445313b7f574aad53ab1de0aa87e835e96b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 22 Mar 2022 20:28:20 +0000 >Subject: [PATCH] Bug 30031: (follow-up) account for item-level_itypes >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >To test: >1. Apply patch and restart_all >2. Create a list >3. GO to Administration > Table settings >4. In Table settings look under Catalog for lists. >5. The search results table should be listed, with the ability to hide the author, date_added, or call_number >6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) >7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) >8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. > >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> >--- > admin/columns_settings.yml | 2 ++ > .../prog/en/modules/virtualshelves/shelves.tt | 35 ++++++++++--------- > 2 files changed, 20 insertions(+), 17 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index 014d599e97..e7d3f7b1e8 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -306,6 +306,8 @@ modules: > columnname: checkbox > cannot_be_toggled: 1 > cannot_be_modified: 1 >+ - >+ columnname: item_type > - > columnname: title > cannot_be_toggled: 1 >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 6abb67bff9..eec6b063de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -219,34 +219,34 @@ > <table id="searchresults" class="dataTable"> > <thead> > <tr> >- [% IF ( itemsloop ) %]<th class="checkall"> </th>[% END %] >+ [% IF ( itemsloop ) %]<th class="checkall" data-colname="checkbox"> </th>[% END %] > >- [% UNLESS ( item_level_itypes ) %]<th>Item type</th>[% END %] >+ [% UNLESS ( item_level_itypes ) %]<th data-colname="item_type">Item type</th>[% END %] > [% IF sortfield == 'title' %] >- <th class="sorting_[% direction | html %]"> >+ <th class="sorting_[% direction | html %]" data-colname="title"> > [% ELSE %] >- <th class="sorting"> >+ <th class="sorting" data-colname="title"> > [% END %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% shelf.shelfnumber | uri %]&sortfield=title&direction=[% IF sortfield != 'title' %]asc[% ELSE %][% new_direction | uri %][% END %]">Title</a> > </th> > [% IF sortfield == 'author' %] >- <th class="sorting_[% direction | html %]"> >+ <th class="sorting_[% direction | html %]" data-colname="author"> > [% ELSE %] >- <th class="sorting"> >+ <th class="sorting" data-colname="author"> > [% END %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% shelf.shelfnumber | uri %]&sortfield=author&direction=[% IF sortfield != 'author' %]asc[% ELSE %][% new_direction | uri %][% END %]">Author</a> > </th> > [% IF sortfield == 'dateadded' %] >- <th class="sorting_[% direction | html %]"> >+ <th class="sorting_[% direction | html %]" data-colname="date_added"> > [% ELSE %] >- <th class="sorting"> >+ <th class="sorting" data-colname="date_added"> > [% END %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% shelf.shelfnumber | uri %]&sortfield=dateadded&direction=[% IF sortfield != 'dateadded' %]asc[% ELSE %][% new_direction | uri %][% END %]">Date added</a> > </th> > [% IF sortfield == 'itemcallnumber' %] >- <th class="sorting_[% direction | html %]"> >+ <th class="sorting_[% direction | html %]" data-colname="call_number"> > [% ELSE %] >- <th class="sorting"> >+ <th class="sorting" data-colname="call_number"> > [% END %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% shelf.shelfnumber | uri %]&sortfield=itemcallnumber&direction=[% IF sortfield != 'itemcallnumber' %]asc[% ELSE %][% new_direction | uri %][% END %]">Call number</a> > </th> >@@ -255,14 +255,14 @@ > [% FOREACH itemsloo IN itemsloop %] > <tr> > [% IF itemsloop %] >- <td> >+ <td data-colname="checkbox"> > <input type="checkbox" class="selection" value="[% itemsloo.biblionumber | html %]" name="biblionumber" /> > </td> > [% END %] >- [% UNLESS ( item_level_itypes ) %]<td> >+ [% UNLESS ( item_level_itypes ) %]<td data-colname="item_type"> > [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />[% END %][% itemsloo.description | html %] > </td>[% END %] >- <td> >+ <td data-colname="title"> > [% IF ( itemsloo.XSLTBloc ) %] > [% itemsloo.XSLTBloc | $raw %] > [% ELSE %] >@@ -288,9 +288,9 @@ > [% END %] > </p> > </td> >- <td>[% itemsloo.author | html %]</td> >- <td>[% itemsloo.dateadded | $KohaDates%]</td> >- <td> >+ <td data-colname="author">[% itemsloo.author | html %]</td> >+ <td data-colname="date_added">[% itemsloo.dateadded | $KohaDates%]</td> >+ <td data-colname="call_number"> > <ul> > [% FOREACH result IN itemsloo.ITEM_RESULTS %] > <li> >@@ -613,7 +613,8 @@ > "dom": 't', > "autoWidth": false, > "ordering": false, >- "paging": false >+ "paging": false, >+ "bKohaColumnsUseNames": true, > }, column_settings ); > > Sticky = $("#searchheader"); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30031
:
130182
|
130183
|
131798
|
132037
|
132049
|
132050
|
132051
|
144887
|
144962
|
144966
|
158626
|
159084
|
159119
|
159859
|
162085
|
166716