Bugzilla – Attachment 132194 Details for
Bug 29103
reserves.desk_id for desk of waiting hold only updates when printing new hold slip
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29103: Change desk when checking in a waiting reserve
Bug-29103-Change-desk-when-checking-in-a-waiting-r.patch (text/plain), 2.03 KB, created by
Martin Renvoize (ashimema)
on 2022-03-24 17:07:47 UTC
(
hide
)
Description:
Bug 29103: Change desk when checking in a waiting reserve
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-03-24 17:07:47 UTC
Size:
2.03 KB
patch
obsolete
>From bdab936620b599671bbcdb6eced336be54ef71b0 Mon Sep 17 00:00:00 2001 >From: Nicolas Legrand <nicolas.legrand@bulac.fr> >Date: Tue, 18 Jan 2022 10:45:50 +0000 >Subject: [PATCH] Bug 29103: Change desk when checking in a waiting reserve > >A check in should relocate a waiting hold under the current desk. But >the current behaviour when confirming the hold is to dismiss the >modal, the item is still attached to the preceding desk. > >This patch mimicks the print and confirm behaviour to trigger the desk >change. > >Plan test: > >1. Add some desks to you library (syspref UseCirculationDesks and > Administration -> Patrons and circulation -> Circulation desks. > >2. Set a desk in your session (Circulation -> Set library and desk) > >3. Have some waiting hold attach to a desk (make a hold on a checked > out item and return it). > >4. Change your current desk. > >5. Check in again the item, click on confirm. > >6. Go to the item notice detail, it appears as waiting at your first > desk. > >7. Apply patch. > >8. Check in again the item. > >9. go to the item notice detail, it should appear at your current > desk. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index c5f6bc7e1f..467109cb19 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1327,6 +1327,11 @@ > this.form.submit(); > }); > >+ $('.approve').on("click",function(e){ >+ let barcode = document.getElementById('confirm-hold-barcode'); >+ if ( barcode ) barcode.remove(); >+ this.form.submit(); >+ }); > $('.cancel-hold').on("click",function(e){ > this.form.cancel_reserve.value = 1; > this.form.submit(); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29103
:
129546
|
129648
| 132194