To recreate: - turn on UseCirculationDesks and define at least 2 for your library - set yourself to a desk using "Set library and desk" - place a hold for pickup at your library - check the item in, confirm the hold and print slip - check reserves.desk_id, see it has updated to the desk you're at - change your desk - check the item in again, click Confirm - check reserves.desk_id, see it has not changed - check the item in a third again, click Confirm and Print Slip - check reserves.desk_id again, see it has changed
Thanks a lot Andrew! My colleagues just pointed me this one yesterday. I may try to fix it, but I'll have soon a new child so I'm not sure I'll have time to work on this one before November. I'll try next week.
Created attachment 129546 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk.
Created attachment 129648 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I don't really understand the change. Isn't it weird to force the submission when the button has a data-dismiss="modal"? Shouldn't we remove this "dismiss" attribute instead? We had lot of regressions on this page, I am a bit reluctant to submit when we were supposed not to...
Created attachment 132194 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, simple fix, works and no regressions found. Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05